{"id":25889,"url":"https://patchwork.libcamera.org/api/1.1/patches/25889/?format=json","web_url":"https://patchwork.libcamera.org/patch/25889/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260120144431.264758-1-barnabas.pocze@ideasonboard.com>","date":"2026-01-20T14:44:31","name":"[v1] libcamera: base: utils: join(): Don't use `const_iterator` directly","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"efa8aaed16a538eb8f4ce90115cea27120213bf5","submitter":{"id":216,"url":"https://patchwork.libcamera.org/api/1.1/people/216/?format=json","name":"Barnabás Pőcze","email":"barnabas.pocze@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/25889/mbox/","series":[{"id":5724,"url":"https://patchwork.libcamera.org/api/1.1/series/5724/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5724","date":"2026-01-20T14:44:31","name":"[v1] libcamera: base: utils: join(): Don't use `const_iterator` directly","version":1,"mbox":"https://patchwork.libcamera.org/series/5724/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/25889/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/25889/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 32215C3220\n\tfor ;\n\tTue, 20 Jan 2026 14:44:36 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E694061FCB;\n\tTue, 20 Jan 2026 15:44:35 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8C61D61FBF\n\tfor ;\n\tTue, 20 Jan 2026 15:44:34 +0100 (CET)","from pb-laptop.local (185.221.143.114.nat.pool.zt.hu\n\t[185.221.143.114])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 705EF2169\n\tfor ;\n\tTue, 20 Jan 2026 15:44:03 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"drOJ5z4Y\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1768920243;\n\tbh=P35ZL031wovg8BTxZu1wUC2cMnZSxL0Sy3ZpvLm6Ltg=;\n\th=From:To:Subject:Date:From;\n\tb=drOJ5z4YRUC9BZEae0qzJEq0PpOHTKLRFLgQ2/4BKbnkO56gpiPSZSAYiBzvSUJC4\n\t/s+xDrCHMtpQ0401wPdU0xsaxg6ry9asdPgc4cMXpIVZ/GwCQJ4NyHQ0XdoImWE2iO\n\tDs++4TeEzjx3iMinEJnq7lO4atg34c0HF8uIhUkY=","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","To":"libcamera-devel@lists.libcamera.org","Subject":"[PATCH v1] libcamera: base: utils: join(): Don't use\n\t`const_iterator` directly","Date":"Tue, 20 Jan 2026 15:44:31 +0100","Message-ID":"<20260120144431.264758-1-barnabas.pocze@ideasonboard.com>","X-Mailer":"git-send-email 2.52.0","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"For example, `std::span` does not have a `const_iterator` typedef before\nC++23, so compilation fails. Simply use `auto`, the `const` qualifier on\nthe `items` variable should already ensure that, if one exists, a \"const\"\niterator will be used.\n\nSigned-off-by: Barnabás Pőcze \n---\n include/libcamera/base/utils.h | 6 ++----\n 1 file changed, 2 insertions(+), 4 deletions(-)","diff":"diff --git a/include/libcamera/base/utils.h b/include/libcamera/base/utils.h\nindex 0b7407f77..2cb8e0a88 100644\n--- a/include/libcamera/base/utils.h\n+++ b/include/libcamera/base/utils.h\n@@ -110,8 +110,7 @@ std::string join(const Container &items, const std::string &sep, UnaryOp op)\n \tstd::ostringstream ss;\n \tbool first = true;\n \n-\tfor (typename Container::const_iterator it = std::begin(items);\n-\t it != std::end(items); ++it) {\n+\tfor (auto it = std::begin(items); it != std::end(items); ++it) {\n \t\tif (!first)\n \t\t\tss << sep;\n \t\telse\n@@ -129,8 +128,7 @@ std::string join(const Container &items, const std::string &sep)\n \tstd::ostringstream ss;\n \tbool first = true;\n \n-\tfor (typename Container::const_iterator it = std::begin(items);\n-\t it != std::end(items); ++it) {\n+\tfor (auto it = std::begin(items); it != std::end(items); ++it) {\n \t\tif (!first)\n \t\t\tss << sep;\n \t\telse\n","prefixes":["v1"]}