{"id":25884,"url":"https://patchwork.libcamera.org/api/1.1/patches/25884/?format=json","web_url":"https://patchwork.libcamera.org/patch/25884/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260120-sklug-lsc-resampling-v2-dev-v5-12-ef5cec7b299f@ideasonboard.com>","date":"2026-01-20T12:26:17","name":"[v5,12/15] ipa: rkisp1: lsc: Pass crop rectangle as parameter","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"3b099fc394166d1c48420b48f5e6893950045b50","submitter":{"id":184,"url":"https://patchwork.libcamera.org/api/1.1/people/184/?format=json","name":"Stefan Klug","email":"stefan.klug@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/25884/mbox/","series":[{"id":5722,"url":"https://patchwork.libcamera.org/api/1.1/series/5722/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5722","date":"2026-01-20T12:26:05","name":"Add resampling support for polynomial LSC data","version":5,"mbox":"https://patchwork.libcamera.org/series/5722/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/25884/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/25884/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 30C17BDCBF\n\tfor ;\n\tTue, 20 Jan 2026 12:26:48 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D9EE061FDA;\n\tTue, 20 Jan 2026 13:26:47 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8BB4E61FD5\n\tfor ;\n\tTue, 20 Jan 2026 13:26:46 +0100 (CET)","from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:b09a:fcc3:e9a4:a9a8])\n\tby perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id 7409A2169; \n\tTue, 20 Jan 2026 13:26:15 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"HQUjywJa\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1768911975;\n\tbh=XcwPc9jwY/s8ZT9ywCS9TdrSd8iAkWk+6EZyKCNVFE4=;\n\th=From:Date:Subject:References:In-Reply-To:To:Cc:From;\n\tb=HQUjywJakWCY4dkf8dIMgvaUgUbhWtGSSnwwlLFZVFwY5CHlnG5cD9FmiUcgOJdfb\n\tZVck3Rud40XcUk9RBITA7GL18jWXOE+UR7CJs2B4NhZqZrRcpgDWAnh0yZvVANBdix\n\taVAo86XJLdYzFwbDKrNTuWsYnJzqFzc8UB0wUFgk=","From":"Stefan Klug ","Date":"Tue, 20 Jan 2026 13:26:17 +0100","Subject":"[PATCH v5 12/15] ipa: rkisp1: lsc: Pass crop rectangle as parameter","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"8bit","Message-Id":"<20260120-sklug-lsc-resampling-v2-dev-v5-12-ef5cec7b299f@ideasonboard.com>","References":"<20260120-sklug-lsc-resampling-v2-dev-v5-0-ef5cec7b299f@ideasonboard.com>","In-Reply-To":"<20260120-sklug-lsc-resampling-v2-dev-v5-0-ef5cec7b299f@ideasonboard.com>","To":"libcamera-devel@lists.libcamera.org","Cc":"Stefan Klug , =?utf-8?q?Barnab=C3=A1s_P?=\n\t=?utf-8?b?xZFjemU=?= ,\n\tRui Wang ","X-Mailer":"b4 0.14.2","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"In preparation for the upcoming rework, pass the crop rectangle as\nparameter to samplePolynomial(). This patch contains no functional\nchange.\n\nSigned-off-by: Stefan Klug \nReviewed-by: Barnabás Pőcze \nReviewed-by: Rui Wang \n\n---\n\nChanges in v2:\n- Collected tags\n---\n src/ipa/rkisp1/algorithms/lsc.cpp | 22 ++++++++++++----------\n 1 file changed, 12 insertions(+), 10 deletions(-)","diff":"diff --git a/src/ipa/rkisp1/algorithms/lsc.cpp b/src/ipa/rkisp1/algorithms/lsc.cpp\nindex 4420fe72ab99398af6ec37dd03255e650e3e8447..f51c690c2020c8a046fbab8f1da31b9ba4a32ac0 100644\n--- a/src/ipa/rkisp1/algorithms/lsc.cpp\n+++ b/src/ipa/rkisp1/algorithms/lsc.cpp\n@@ -93,7 +93,8 @@ private:\n \tstd::vector sizesListToPositions(const std::vector &sizes);\n \tstd::vector samplePolynomial(const LscPolynomial &poly,\n \t\t\t\t\t Span xPositions,\n-\t\t\t\t\t Span yPositions);\n+\t\t\t\t\t Span yPositions,\n+\t\t\t\t\t const Rectangle &cropRectangle);\n \n \tSize sensorSize_;\n \tRectangle cropRectangle_;\n@@ -136,10 +137,10 @@ int LscPolynomialLoader::parseLscData(const YamlObject &yamlSets,\n \n \t\tstd::vector xPos = sizesListToPositions(xSizes_);\n \t\tstd::vector yPos = sizesListToPositions(ySizes_);\n-\t\tset.r = samplePolynomial(*pr, xPos, yPos);\n-\t\tset.gr = samplePolynomial(*pgr, xPos, yPos);\n-\t\tset.gb = samplePolynomial(*pgb, xPos, yPos);\n-\t\tset.b = samplePolynomial(*pb, xPos, yPos);\n+\t\tset.r = samplePolynomial(*pr, xPos, yPos, cropRectangle_);\n+\t\tset.gr = samplePolynomial(*pgr, xPos, yPos, cropRectangle_);\n+\t\tset.gb = samplePolynomial(*pgb, xPos, yPos, cropRectangle_);\n+\t\tset.b = samplePolynomial(*pb, xPos, yPos, cropRectangle_);\n \t}\n \n \tif (lscData.empty()) {\n@@ -178,13 +179,14 @@ std::vector LscPolynomialLoader::sizesListToPositions(const std::vector<\n \n std::vector LscPolynomialLoader::samplePolynomial(const LscPolynomial &poly,\n \t\t\t\t\t\t\t Span xPositions,\n-\t\t\t\t\t\t\t Span yPositions)\n+\t\t\t\t\t\t\t Span yPositions,\n+\t\t\t\t\t\t\t const Rectangle &cropRectangle)\n {\n \tdouble m = poly.getM();\n-\tdouble x0 = cropRectangle_.x / m;\n-\tdouble y0 = cropRectangle_.y / m;\n-\tdouble w = cropRectangle_.width / m;\n-\tdouble h = cropRectangle_.height / m;\n+\tdouble x0 = cropRectangle.x / m;\n+\tdouble y0 = cropRectangle.y / m;\n+\tdouble w = cropRectangle.width / m;\n+\tdouble h = cropRectangle.height / m;\n \tstd::vector samples;\n \n \tsamples.reserve(xPositions.size() * yPositions.size());\n","prefixes":["v5","12/15"]}