{"id":2588,"url":"https://patchwork.libcamera.org/api/1.1/patches/2588/?format=json","web_url":"https://patchwork.libcamera.org/patch/2588/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20200112010212.2609025-7-niklas.soderlund@ragnatech.se>","date":"2020-01-12T01:01:46","name":"[libcamera-devel,v4,06/32] v4l2: camera_proxy: Call V4L2Camera::getBufferFd() directly","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"45bda8ddc0116e83e79f63f51dd9db9ed5c4084a","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/1.1/people/5/?format=json","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/2588/mbox/","series":[{"id":617,"url":"https://patchwork.libcamera.org/api/1.1/series/617/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=617","date":"2020-01-12T01:01:40","name":"libcamera: Rework buffer API","version":4,"mbox":"https://patchwork.libcamera.org/series/617/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/2588/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/2588/checks/","tags":{},"headers":{"Return-Path":"","Received":["from bin-mail-out-05.binero.net (bin-mail-out-05.binero.net\n\t[195.74.38.228])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 14530606D0\n\tfor ;\n\tSun, 12 Jan 2020 02:03:03 +0100 (CET)","from bismarck.berto.se (p54ac5d7b.dip0.t-ipconnect.de\n\t[84.172.93.123]) by bin-vsp-out-02.atm.binero.net (Halon) with ESMTPA\n\tid 466f071e-34d7-11ea-b6d8-005056917f90;\n\tSun, 12 Jan 2020 02:02:59 +0100 (CET)"],"X-Halon-ID":"466f071e-34d7-11ea-b6d8-005056917f90","Authorized-sender":"niklas@soderlund.pp.se","From":"=?utf-8?q?Niklas_S=C3=B6derlund?= ","To":"libcamera-devel@lists.libcamera.org","Date":"Sun, 12 Jan 2020 02:01:46 +0100","Message-Id":"<20200112010212.2609025-7-niklas.soderlund@ragnatech.se>","X-Mailer":"git-send-email 2.24.1","In-Reply-To":"<20200112010212.2609025-1-niklas.soderlund@ragnatech.se>","References":"<20200112010212.2609025-1-niklas.soderlund@ragnatech.se>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v4 06/32] v4l2: camera_proxy: Call\n\tV4L2Camera::getBufferFd() directly","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Sun, 12 Jan 2020 01:03:03 -0000"},"content":"From: Laurent Pinchart \n\nThe V4L2Camera::getBufferFd() method doesn't need to run in the camera\nthread. Call it directly.\n\nSigned-off-by: Laurent Pinchart \nReviewed-by: Niklas Söderlund \n---\n src/v4l2/v4l2_camera_proxy.cpp | 3 +--\n 1 file changed, 1 insertion(+), 2 deletions(-)","diff":"diff --git a/src/v4l2/v4l2_camera_proxy.cpp b/src/v4l2/v4l2_camera_proxy.cpp\nindex b4a9e2107c0f9f28..e4aba33e6d33f21b 100644\n--- a/src/v4l2/v4l2_camera_proxy.cpp\n+++ b/src/v4l2/v4l2_camera_proxy.cpp\n@@ -92,8 +92,7 @@ void *V4L2CameraProxy::mmap(void *addr, size_t length, int prot, int flags,\n \t\treturn MAP_FAILED;\n \t}\n \n-\tFileDescriptor fd = vcam_->invokeMethod(&V4L2Camera::getBufferFd,\n-\t\t\t\t\t\tConnectionTypeBlocking, index);\n+\tFileDescriptor fd = vcam_->getBufferFd(index);\n \tif (!fd.isValid()) {\n \t\terrno = EINVAL;\n \t\treturn MAP_FAILED;\n","prefixes":["libcamera-devel","v4","06/32"]}