{"id":25863,"url":"https://patchwork.libcamera.org/api/1.1/patches/25863/?format=json","web_url":"https://patchwork.libcamera.org/patch/25863/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260120-sklug-lsc-resampling-v2-dev-v4-8-2411c4be6d6d@ideasonboard.com>","date":"2026-01-20T08:45:50","name":"[v4,08/14] ipa: rkisp1: lsc: Move local types into anonymous namespace","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"7d6e72bccedf650d034bc0e5451f718db59296dc","submitter":{"id":184,"url":"https://patchwork.libcamera.org/api/1.1/people/184/?format=json","name":"Stefan Klug","email":"stefan.klug@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/25863/mbox/","series":[{"id":5720,"url":"https://patchwork.libcamera.org/api/1.1/series/5720/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5720","date":"2026-01-20T08:45:42","name":"Add resampling support for polynomial LSC data","version":4,"mbox":"https://patchwork.libcamera.org/series/5720/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/25863/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/25863/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 2AE42BDCBF\n\tfor ;\n\tTue, 20 Jan 2026 08:46:19 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D6AB761FD8;\n\tTue, 20 Jan 2026 09:46:18 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5685161FCF\n\tfor ;\n\tTue, 20 Jan 2026 09:46:16 +0100 (CET)","from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:7f76:a386:d798:7544])\n\tby perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id 6438E177D; \n\tTue, 20 Jan 2026 09:45:45 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"U9haRQ4+\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1768898745;\n\tbh=0l6JnCw672jvY9tLeKTKm0Y+MPFLCOZ2jHu4Q8BNJ4o=;\n\th=From:Date:Subject:References:In-Reply-To:To:Cc:From;\n\tb=U9haRQ4+5ERH3IZmW14I2XiaS//MF2YKdSL7VRqgVpkaf5Cka3Ndpo7QpXz0L8cM+\n\tYLmdN3IZ/ZC0a7ReA9EgM8qP4jQV1Vx++tJA3R7vEPs+GJ2r6J4/8ae9mO1qneqPyG\n\t/rJnZdZ1+eMGCbBA0CRW3xEGw16kAB5dKmL7XxRA=","From":"Stefan Klug ","Date":"Tue, 20 Jan 2026 09:45:50 +0100","Subject":"[PATCH v4 08/14] ipa: rkisp1: lsc: Move local types into anonymous\n\tnamespace","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"8bit","Message-Id":"<20260120-sklug-lsc-resampling-v2-dev-v4-8-2411c4be6d6d@ideasonboard.com>","References":"<20260120-sklug-lsc-resampling-v2-dev-v4-0-2411c4be6d6d@ideasonboard.com>","In-Reply-To":"<20260120-sklug-lsc-resampling-v2-dev-v4-0-2411c4be6d6d@ideasonboard.com>","To":"libcamera-devel@lists.libcamera.org","Cc":"Stefan Klug , Kieran Bingham\n\t, =?utf-8?q?Barnab=C3=A1s_P=C5=91cze?=\n\t","X-Mailer":"b4 0.14.2","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Move all local helpers into an anonymous namespace and drop a static\nmodifier that is no longer needed.\n\nSigned-off-by: Stefan Klug \nReviewed-by: Kieran Bingham \nReviewed-by: Barnabás Pőcze \n\n---\n\nChanges in v3:\n- Collected tags\n\nChanges in v2:\n- Added this patch\n---\n src/ipa/rkisp1/algorithms/lsc.cpp | 12 ++++++++----\n 1 file changed, 8 insertions(+), 4 deletions(-)","diff":"diff --git a/src/ipa/rkisp1/algorithms/lsc.cpp b/src/ipa/rkisp1/algorithms/lsc.cpp\nindex 1962d18d148b4abac6e601ec36e0c68944a6191c..c42f74557c7364935254d75ee1fb923d176e0dbd 100644\n--- a/src/ipa/rkisp1/algorithms/lsc.cpp\n+++ b/src/ipa/rkisp1/algorithms/lsc.cpp\n@@ -27,8 +27,6 @@ namespace libcamera {\n \n namespace ipa {\n \n-constexpr int kColourTemperatureChangeThreshhold = 10;\n-\n template\n void interpolateVector(const std::vector &a, const std::vector &b,\n \t\t std::vector &dest, double lambda)\n@@ -70,6 +68,10 @@ namespace ipa::rkisp1::algorithms {\n \n LOG_DEFINE_CATEGORY(RkISP1Lsc)\n \n+namespace {\n+\n+constexpr int kColourTemperatureChangeThreshhold = 10;\n+\n class LscPolynomialLoader\n {\n public:\n@@ -276,8 +278,8 @@ std::vector LscTableLoader::parseTable(const YamlObject &tuningData,\n \treturn table;\n }\n \n-static std::vector parseSizes(const YamlObject &tuningData,\n-\t\t\t\t const char *prop)\n+std::vector parseSizes(const YamlObject &tuningData,\n+\t\t\t const char *prop)\n {\n \tstd::vector sizes =\n \t\ttuningData[prop].getList().value_or(std::vector{});\n@@ -306,6 +308,8 @@ static std::vector parseSizes(const YamlObject &tuningData,\n \treturn sizes;\n }\n \n+} /* namespace */\n+\n LensShadingCorrection::LensShadingCorrection()\n \t: lastAppliedCt_(0), lastAppliedQuantizedCt_(0)\n {\n","prefixes":["v4","08/14"]}