{"id":25761,"url":"https://patchwork.libcamera.org/api/1.1/patches/25761/?format=json","web_url":"https://patchwork.libcamera.org/patch/25761/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260113174642.1185403-6-rui.wang@ideasonboard.com>","date":"2026-01-13T17:46:41","name":"[v7,5/6] ipa: rkisp1: algorithms: dpf: Add detailed config logging","commit_ref":null,"pull_url":null,"state":"deferred","archived":false,"hash":"855e6f5a374c1f5c4c0e5ab30ec0765d0148e789","submitter":{"id":241,"url":"https://patchwork.libcamera.org/api/1.1/people/241/?format=json","name":"Rui Wang","email":"rui.wang@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/25761/mbox/","series":[{"id":5704,"url":"https://patchwork.libcamera.org/api/1.1/series/5704/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5704","date":"2026-01-13T17:46:36","name":"refactor DPF parsing and initialization","version":7,"mbox":"https://patchwork.libcamera.org/series/5704/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/25761/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/25761/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 83CC2C3274\n\tfor ;\n\tTue, 13 Jan 2026 17:47:57 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C9D2D61FB7;\n\tTue, 13 Jan 2026 18:47:56 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6CF5A61FA3\n\tfor ;\n\tTue, 13 Jan 2026 18:47:55 +0100 (CET)","from rui-Precision-7560.local (unknown [209.216.103.65])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id DEADC73B;\n\tTue, 13 Jan 2026 18:47:28 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Hm0fs3vP\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1768326449;\n\tbh=8+o1zc+tpwQFL0Q1nP4D3IiKs9tzV4Do+1fQLqJCItQ=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=Hm0fs3vPKIK/efLDsLB2cCqpmNNWSay/yy4mu47q2yMTXbspi3VuA3Qmr3rcoCN2+\n\tI9dUUxWqgr0UUiF2dsj4RACWbUx16OzWDR4TAULxL14kADdpPcoKspB6TS7NoQHeE1\n\tQuMYXB52O+usmPZF5KhhtGfJ2p+PE0yZOHoLH+d8=","From":"Rui Wang ","To":"libcamera-devel@lists.libcamera.org","Cc":"Rui Wang ,\n\tJacopo Mondi ","Subject":"[PATCH v7 5/6] ipa: rkisp1: algorithms: dpf: Add detailed config\n\tlogging","Date":"Tue, 13 Jan 2026 12:46:41 -0500","Message-ID":"<20260113174642.1185403-6-rui.wang@ideasonboard.com>","X-Mailer":"git-send-email 2.43.0","In-Reply-To":"<20260113174642.1185403-1-rui.wang@ideasonboard.com>","References":"<20260113174642.1185403-1-rui.wang@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Add logConfig() helper function to log DPF configuration\nupdates when they occur. This provides visibility into the active\nDPF parameters including:\n\n- Control mode and denoise enable state\n- Filter sizes (9x9 vs 13x9 for rb)\n- NLL scale mode (linear vs logarithmic)\n- Gain mode\n- Strength values (r, g, b)\n- Spatial filter coefficients (g and rb arrays)\n- Noise level lookup table coefficients\n\nThe logging is triggered in prepareEnabledMode() whenever the\nconfiguration is updated, helping with debugging and tuning.\n\nSigned-off-by: Rui Wang \nReviewed-by: Jacopo Mondi \n\n---\nchangelog since v5:\n - remove curly bracket in single state if-else\n\n Reviewed-by tags from v5 are carried over (no function changes).\n\nchangelog since v6: No change\n---\n src/ipa/rkisp1/algorithms/dpf.cpp | 44 +++++++++++++++++++++++++++++++\n src/ipa/rkisp1/algorithms/dpf.h | 1 +\n 2 files changed, 45 insertions(+)","diff":"diff --git a/src/ipa/rkisp1/algorithms/dpf.cpp b/src/ipa/rkisp1/algorithms/dpf.cpp\nindex 7e615e3b..1d388886 100644\n--- a/src/ipa/rkisp1/algorithms/dpf.cpp\n+++ b/src/ipa/rkisp1/algorithms/dpf.cpp\n@@ -267,6 +267,47 @@ bool Dpf::loadReductionConfig(int32_t mode)\n \treturn true;\n }\n \n+void Dpf::logConfig(const IPAFrameContext &frameContext)\n+{\n+\tstd::ostringstream ss;\n+\n+\tss << \"DPF config update: \";\n+\tss << \" control mode=\" << kModesMap.at(runningMode_);\n+\tss << \", denoise=\" << (frameContext.dpf.denoise ? \"enabled\" : \"disabled\");\n+\n+\tss << \", rb_fltsize=\"\n+\t << (config_.rb_flt.fltsize == RKISP1_CIF_ISP_DPF_RB_FILTERSIZE_13x9 ? \"13x9\" : \"9x9\");\n+\tss << \", nll_scale=\"\n+\t << (config_.nll.scale_mode == RKISP1_CIF_ISP_NLL_SCALE_LOGARITHMIC ? \"log\" : \"linear\");\n+\tss << \", gain_mode=\" << config_.gain.mode;\n+\tss << \", strength=\" << int(strengthConfig_.r) << ',' << int(strengthConfig_.g) << ',' << int(strengthConfig_.b);\n+\n+\tss << \", g=[\";\n+\tfor (size_t i = 0; i < RKISP1_CIF_ISP_DPF_MAX_SPATIAL_COEFFS; ++i) {\n+\t\tif (i)\n+\t\t\tss << ',';\n+\t\tss << int(config_.g_flt.spatial_coeff[i]);\n+\t}\n+\tss << \"]\";\n+\n+\tss << \", rb=[\";\n+\tfor (size_t i = 0; i < RKISP1_CIF_ISP_DPF_MAX_SPATIAL_COEFFS; ++i) {\n+\t\tif (i)\n+\t\t\tss << ',';\n+\t\tss << int(config_.rb_flt.spatial_coeff[i]);\n+\t}\n+\tss << \"]\";\n+\n+\tss << \", nll=[\";\n+\tfor (size_t i = 0; i < RKISP1_CIF_ISP_DPF_MAX_NLF_COEFFS; ++i) {\n+\t\tif (i)\n+\t\t\tss << ',';\n+\t\tss << int(config_.nll.coeff[i]);\n+\t}\n+\tss << \"]\";\n+\tLOG(RkISP1Dpf, Debug) << ss.str();\n+}\n+\n /**\n * \\copydoc libcamera::ipa::Algorithm::queueRequest\n */\n@@ -375,6 +416,9 @@ void Dpf::prepareEnabledMode(IPAContext &context, [[maybe_unused]] const uint32_\n \tauto strengthConfig = params->block();\n \tstrengthConfig.setEnabled(true);\n \t*strengthConfig = strengthConfig_;\n+\n+\tif (frameContext.dpf.update)\n+\t\tlogConfig(frameContext);\n }\n \n REGISTER_IPA_ALGORITHM(Dpf, \"Dpf\")\ndiff --git a/src/ipa/rkisp1/algorithms/dpf.h b/src/ipa/rkisp1/algorithms/dpf.h\nindex fcf121cb..1821da39 100644\n--- a/src/ipa/rkisp1/algorithms/dpf.h\n+++ b/src/ipa/rkisp1/algorithms/dpf.h\n@@ -43,6 +43,7 @@ private:\n \t\t\t rkisp1_cif_isp_dpf_strength_config &strengthConfig);\n \n \tbool loadReductionConfig(int32_t mode);\n+\tvoid logConfig(const IPAFrameContext &frameContext);\n \n \tvoid prepareDisabledMode(IPAContext &context, const uint32_t frame,\n \t\t\t\t IPAFrameContext &frameContext,\n","prefixes":["v7","5/6"]}