{"id":25754,"url":"https://patchwork.libcamera.org/api/1.1/patches/25754/?format=json","web_url":"https://patchwork.libcamera.org/patch/25754/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260113000808.15395-35-laurent.pinchart@ideasonboard.com>","date":"2026-01-13T00:08:06","name":"[34/36] libcamera: software_isp: Rename \"measure\" option to \"benchmark\"","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"63747bcf7f27d2f63f38aa347d71ec92204e1763","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/1.1/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/25754/mbox/","series":[{"id":5703,"url":"https://patchwork.libcamera.org/api/1.1/series/5703/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5703","date":"2026-01-13T00:07:32","name":"libcamera: Global configuration file improvements","version":1,"mbox":"https://patchwork.libcamera.org/series/5703/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/25754/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/25754/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E44A0C3285\n\tfor ;\n\tTue, 13 Jan 2026 00:09:27 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8128C61FBF;\n\tTue, 13 Jan 2026 01:09:27 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6DBE661FBF\n\tfor ;\n\tTue, 13 Jan 2026 01:09:25 +0100 (CET)","from pendragon.ideasonboard.com (81-175-209-152.bb.dnainternet.fi\n\t[81.175.209.152])\n\tby perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id B51F766B\n\tfor ;\n\tTue, 13 Jan 2026 01:08:59 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"WDNaBwD/\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1768262939;\n\tbh=8/sokydaSp9DC91XqA2Wrrga4MkaoJf/swqM7LXZYFQ=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=WDNaBwD/OWbULLr1d2jnbTsy6pLMh9gWtKjkr0b4e8/GgRU3pHaYbt8I266rxVB9O\n\tzQgxYi/u+LpqW0R1I8WP3Hb7iIm2fWNTdK0QYiz5fr1BOaBO9zyUMDz+DUPb9mE2XA\n\tcRYZ41T0Sjz6fD+NvQqyxta/N5KwNqIzGuMI1Mkc=","From":"Laurent Pinchart ","To":"libcamera-devel@lists.libcamera.org","Subject":"[PATCH 34/36] libcamera: software_isp: Rename \"measure\" option to\n\t\"benchmark\"","Date":"Tue, 13 Jan 2026 02:08:06 +0200","Message-ID":"<20260113000808.15395-35-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.51.2","In-Reply-To":"<20260113000808.15395-1-laurent.pinchart@ideasonboard.com>","References":"<20260113000808.15395-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The software ISP \"measure\" configuration option doesn't clearly indicate\nwhat it measures. Rename it to \"benchmark\" to match the name of the\nclass that handles it and make it self-explicit.\n\nWhile at it, improve the documentation slightly by replacing \"per-frame\ntime measurement\" with \"performance measurement\".\n\nSigned-off-by: Laurent Pinchart \n---\n Documentation/runtime_configuration.rst | 10 +++++-----\n src/libcamera/software_isp/benchmark.cpp | 10 +++++-----\n 2 files changed, 10 insertions(+), 10 deletions(-)","diff":"diff --git a/Documentation/runtime_configuration.rst b/Documentation/runtime_configuration.rst\nindex b4386cd2ef4b..8c920978648d 100644\n--- a/Documentation/runtime_configuration.rst\n+++ b/Documentation/runtime_configuration.rst\n@@ -48,7 +48,7 @@ file structure:\n software_isp: # true/false\n software_isp:\n copy_input_buffer: # true/false\n- measure:\n+ benchmark:\n skip: # non-negative integer, frames to skip initially\n number: # non-negative integer, frames to measure\n \n@@ -81,7 +81,7 @@ Configuration file example\n software_isp: true\n software_isp:\n copy_input_buffer: false\n- measure:\n+ benchmark:\n skip: 50\n number: 30\n \n@@ -155,13 +155,13 @@ software_isp.copy_input_buffer\n \n Example value: ``false``\n \n-software_isp.measure.skip, software_isp.measure.number\n- Define per-frame time measurement parameters in software ISP. `skip`\n+software_isp.benchmark.skip, software_isp.benchmark.number\n+ Define performance measurement parameters for the software ISP. `skip`\n defines how many initial frames are skipped before starting the\n measurement; `number` defines how many frames then participate in the\n measurement.\n \n- Set `software_isp.measure.number` to 0 to disable the measurement.\n+ Set `software_isp.benchmark.number` to 0 to disable the measurement.\n \n Example `skip` value: ``50``\n \ndiff --git a/src/libcamera/software_isp/benchmark.cpp b/src/libcamera/software_isp/benchmark.cpp\nindex b15ddd66e26f..47bd58727ac3 100644\n--- a/src/libcamera/software_isp/benchmark.cpp\n+++ b/src/libcamera/software_isp/benchmark.cpp\n@@ -34,11 +34,11 @@ Benchmark::Benchmark(const CameraManager &cm)\n \tconst GlobalConfiguration &configuration = cm._d()->configuration();\n \n \tskipBeforeMeasure_ = configuration.option(\n-\t\t\t\t\t\t{ \"software_isp\", \"measure\", \"skip\" })\n-\t\t\t\t\t\t\t.value_or(skipBeforeMeasure_);\n-\tframesToMeasure_ = configuration.option(\n-\t\t\t\t\t\t{ \"software_isp\", \"measure\", \"number\" })\n-\t\t\t\t\t\t\t.value_or(framesToMeasure_);\n+\t\t\t\t\t\t{ \"software_isp\", \"benchmark\", \"skip\" })\n+\t\t\t\t\t .value_or(skipBeforeMeasure_);\n+ framesToMeasure_ = configuration.option(\n+\t\t\t\t\t\t{ \"software_isp\", \"benchmark\", \"number\" })\n+\t\t\t\t\t.value_or(framesToMeasure_);\n }\n \n Benchmark::~Benchmark()\n","prefixes":["34/36"]}