{"id":25743,"url":"https://patchwork.libcamera.org/api/1.1/patches/25743/?format=json","web_url":"https://patchwork.libcamera.org/patch/25743/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260113000808.15395-24-laurent.pinchart@ideasonboard.com>","date":"2026-01-13T00:07:55","name":"[23/36] libcamera: global_configuration: Rename yamlConfiguration_","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"c3d30f1e0a53f615d9a77090aeb52e7ef4c4127d","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/1.1/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/25743/mbox/","series":[{"id":5703,"url":"https://patchwork.libcamera.org/api/1.1/series/5703/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5703","date":"2026-01-13T00:07:32","name":"libcamera: Global configuration file improvements","version":1,"mbox":"https://patchwork.libcamera.org/series/5703/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/25743/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/25743/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 4D6F5C32C1\n\tfor ;\n\tTue, 13 Jan 2026 00:09:10 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0644761FFF;\n\tTue, 13 Jan 2026 01:09:10 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id DCE6F61FFB\n\tfor ;\n\tTue, 13 Jan 2026 01:09:07 +0100 (CET)","from pendragon.ideasonboard.com (81-175-209-152.bb.dnainternet.fi\n\t[81.175.209.152])\n\tby perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id 3699A66B\n\tfor ;\n\tTue, 13 Jan 2026 01:08:42 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"mmsD5+Lv\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1768262922;\n\tbh=QS/ejGv2+4tMwSD3Jl6b3tK5qdQ/xT7e+v/yuetD8vw=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=mmsD5+Lv0JgbqiV7iibzy75ko8oNcrd9dlhpLtOG9f+jSxgugbLhYSImTJrlKMUZ5\n\t4wEuyHtwJxh+b1iV2gxFbZBK2bAxg3i+4BIwzbYQKrF28eJcurKtTix9xcQEURSlpr\n\t6qYZ50PHZZ0mUjeWrZGDUlEAxHbsaony26kiyqLY=","From":"Laurent Pinchart ","To":"libcamera-devel@lists.libcamera.org","Subject":"[PATCH 23/36] libcamera: global_configuration: Rename\n\tyamlConfiguration_","Date":"Tue, 13 Jan 2026 02:07:55 +0200","Message-ID":"<20260113000808.15395-24-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.51.2","In-Reply-To":"<20260113000808.15395-1-laurent.pinchart@ideasonboard.com>","References":"<20260113000808.15395-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Once parsed, the global configuration isn't a YAML file anymore. Rename\nthe yamlConfiguration_ to configuration_.\n\nSigned-off-by: Laurent Pinchart \n---\n include/libcamera/internal/global_configuration.h | 2 +-\n src/libcamera/global_configuration.cpp | 6 +++---\n 2 files changed, 4 insertions(+), 4 deletions(-)","diff":"diff --git a/include/libcamera/internal/global_configuration.h b/include/libcamera/internal/global_configuration.h\nindex 80b57b38ba03..5c907ee92bfe 100644\n--- a/include/libcamera/internal/global_configuration.h\n+++ b/include/libcamera/internal/global_configuration.h\n@@ -56,7 +56,7 @@ private:\n \tvoid load();\n \tbool loadFile(const std::filesystem::path &fileName);\n \n-\tstd::unique_ptr yamlConfiguration_ =\n+\tstd::unique_ptr configuration_ =\n \t\tstd::make_unique();\n };\n \ndiff --git a/src/libcamera/global_configuration.cpp b/src/libcamera/global_configuration.cpp\nindex 44ed206de78f..ee7d9c185b80 100644\n--- a/src/libcamera/global_configuration.cpp\n+++ b/src/libcamera/global_configuration.cpp\n@@ -125,7 +125,7 @@ bool GlobalConfiguration::loadFile(const std::filesystem::path &fileName)\n \t\treturn true;\n \t}\n \n-\tyamlConfiguration_ = std::move(configuration);\n+\tconfiguration_ = std::move(configuration);\n \treturn true;\n }\n \n@@ -141,7 +141,7 @@ bool GlobalConfiguration::loadFile(const std::filesystem::path &fileName)\n */\n unsigned int GlobalConfiguration::version() const\n {\n-\treturn (*yamlConfiguration_)[\"version\"].get().value_or(0);\n+\treturn (*configuration_)[\"version\"].get().value_or(0);\n }\n \n /**\n@@ -160,7 +160,7 @@ unsigned int GlobalConfiguration::version() const\n */\n GlobalConfiguration::Configuration GlobalConfiguration::configuration() const\n {\n-\treturn (*yamlConfiguration_)[\"configuration\"];\n+\treturn (*configuration_)[\"configuration\"];\n }\n \n /**\n","prefixes":["23/36"]}