{"id":25730,"url":"https://patchwork.libcamera.org/api/1.1/patches/25730/?format=json","web_url":"https://patchwork.libcamera.org/patch/25730/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260113000808.15395-11-laurent.pinchart@ideasonboard.com>","date":"2026-01-13T00:07:42","name":"[10/36] libcamera: yaml_parser: Rename Getter to Accessor","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"944602aae546129b782c6d917e20c3d3eef11731","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/1.1/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/25730/mbox/","series":[{"id":5703,"url":"https://patchwork.libcamera.org/api/1.1/series/5703/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5703","date":"2026-01-13T00:07:32","name":"libcamera: Global configuration file improvements","version":1,"mbox":"https://patchwork.libcamera.org/series/5703/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/25730/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/25730/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 004C4BDCBF\n\tfor ;\n\tTue, 13 Jan 2026 00:08:46 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8EE9061FD9;\n\tTue, 13 Jan 2026 01:08:46 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D001061FD1\n\tfor ;\n\tTue, 13 Jan 2026 01:08:44 +0100 (CET)","from pendragon.ideasonboard.com (81-175-209-152.bb.dnainternet.fi\n\t[81.175.209.152])\n\tby perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id 275DF50A\n\tfor ;\n\tTue, 13 Jan 2026 01:08:19 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"BwYVPv/c\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1768262899;\n\tbh=dcgyHiAYwxc6UdyxdPeoYi9mEglAy8imsqnuuKRslNc=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=BwYVPv/ckMcCjkGfDmO37kd3L0HqHIikQPYsT0s3al5PoLTCBegvN5G4B9EgZCm34\n\tE/Y32ZQdAHlFAOHV3kb9/C3fOT25J/cWx6fuyuFgucxXOgHX0iEvXR3LGVEexW2bXU\n\t/9u71oqPpijqEvz55k6XFWG2hRdhgx6ha6LGwwwg=","From":"Laurent Pinchart ","To":"libcamera-devel@lists.libcamera.org","Subject":"[PATCH 10/36] libcamera: yaml_parser: Rename Getter to Accessor","Date":"Tue, 13 Jan 2026 02:07:42 +0200","Message-ID":"<20260113000808.15395-11-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.51.2","In-Reply-To":"<20260113000808.15395-1-laurent.pinchart@ideasonboard.com>","References":"<20260113000808.15395-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"In preparation for support to set the value of a YamlObject, rename the\nGetter structure to Accessor. The structure will be extended with a\nset() function.\n\nSigned-off-by: Laurent Pinchart \n---\n include/libcamera/internal/matrix.h | 2 +-\n include/libcamera/internal/vector.h | 2 +-\n include/libcamera/internal/yaml_parser.h | 6 +++---\n src/ipa/libipa/lsc_polynomial.h | 2 +-\n src/ipa/libipa/pwl.cpp | 2 +-\n src/libcamera/yaml_parser.cpp | 24 ++++++++++++------------\n 6 files changed, 19 insertions(+), 19 deletions(-)","diff":"diff --git a/include/libcamera/internal/matrix.h b/include/libcamera/internal/matrix.h\nindex 1842389f2b22..67761cb6037d 100644\n--- a/include/libcamera/internal/matrix.h\n+++ b/include/libcamera/internal/matrix.h\n@@ -200,7 +200,7 @@ std::ostream &operator<<(std::ostream &out, const Matrix &m)\n }\n \n template\n-struct YamlObject::Getter> {\n+struct YamlObject::Accessor> {\n \tstd::optional> get(const YamlObject &obj) const\n \t{\n \t\tif (!matrixValidateYaml(obj, Rows * Cols))\ndiff --git a/include/libcamera/internal/vector.h b/include/libcamera/internal/vector.h\nindex 16b6aef0b38f..cfd8882ce0e6 100644\n--- a/include/libcamera/internal/vector.h\n+++ b/include/libcamera/internal/vector.h\n@@ -347,7 +347,7 @@ std::ostream &operator<<(std::ostream &out, const Vector &v)\n }\n \n template\n-struct YamlObject::Getter> {\n+struct YamlObject::Accessor> {\n \tstd::optional> get(const YamlObject &obj) const\n \t{\n \t\tif (!vectorValidateYaml(obj, Rows))\ndiff --git a/include/libcamera/internal/yaml_parser.h b/include/libcamera/internal/yaml_parser.h\nindex 03d6a05e2d0f..0ff026706682 100644\n--- a/include/libcamera/internal/yaml_parser.h\n+++ b/include/libcamera/internal/yaml_parser.h\n@@ -173,7 +173,7 @@ public:\n \ttemplate\n \tstd::optional get() const\n \t{\n-\t\treturn Getter{}.get(*this);\n+\t\treturn Accessor{}.get(*this);\n \t}\n \n \ttemplate\n@@ -213,7 +213,7 @@ private:\n \tLIBCAMERA_DISABLE_COPY_AND_MOVE(YamlObject)\n \n \ttemplate\n-\tfriend struct Getter;\n+\tfriend struct Accessor;\n \tfriend class YamlParserContext;\n \n \tenum class Type {\n@@ -224,7 +224,7 @@ private:\n \t};\n \n \ttemplate\n-\tstruct Getter {\n+\tstruct Accessor {\n \t\tstd::optional get(const YamlObject &obj) const;\n \t};\n \ndiff --git a/src/ipa/libipa/lsc_polynomial.h b/src/ipa/libipa/lsc_polynomial.h\nindex c898faeb13db..df3a0d4b39c4 100644\n--- a/src/ipa/libipa/lsc_polynomial.h\n+++ b/src/ipa/libipa/lsc_polynomial.h\n@@ -81,7 +81,7 @@ private:\n #ifndef __DOXYGEN__\n \n template<>\n-struct YamlObject::Getter {\n+struct YamlObject::Accessor {\n \tstd::optional get(const YamlObject &obj) const\n \t{\n \t\tstd::optional cx = obj[\"cx\"].get();\ndiff --git a/src/ipa/libipa/pwl.cpp b/src/ipa/libipa/pwl.cpp\nindex 72b63c4d068d..f38573e69c13 100644\n--- a/src/ipa/libipa/pwl.cpp\n+++ b/src/ipa/libipa/pwl.cpp\n@@ -435,7 +435,7 @@ std::string Pwl::toString() const\n */\n template<>\n std::optional\n-YamlObject::Getter::get(const YamlObject &obj) const\n+YamlObject::Accessor::get(const YamlObject &obj) const\n {\n \t/* Treat a single value as single point PWL. */\n \tif (obj.isValue()) {\ndiff --git a/src/libcamera/yaml_parser.cpp b/src/libcamera/yaml_parser.cpp\nindex 72580e901ddd..a21e589fdd86 100644\n--- a/src/libcamera/yaml_parser.cpp\n+++ b/src/libcamera/yaml_parser.cpp\n@@ -134,7 +134,7 @@ std::size_t YamlObject::size() const\n \n template<>\n std::optional\n-YamlObject::Getter::get(const YamlObject &obj) const\n+YamlObject::Accessor::get(const YamlObject &obj) const\n {\n \tif (obj.type_ != Type::Value)\n \t\treturn std::nullopt;\n@@ -148,7 +148,7 @@ YamlObject::Getter::get(const YamlObject &obj) const\n }\n \n template\n-struct YamlObject::Getter ||\n \tstd::is_same_v ||\n \tstd::is_same_v ||\n@@ -173,23 +173,23 @@ struct YamlObject::Getter;\n-template struct YamlObject::Getter;\n-template struct YamlObject::Getter;\n-template struct YamlObject::Getter;\n-template struct YamlObject::Getter;\n-template struct YamlObject::Getter;\n+template struct YamlObject::Accessor;\n+template struct YamlObject::Accessor;\n+template struct YamlObject::Accessor;\n+template struct YamlObject::Accessor;\n+template struct YamlObject::Accessor;\n+template struct YamlObject::Accessor;\n \n template<>\n std::optional\n-YamlObject::Getter::get(const YamlObject &obj) const\n+YamlObject::Accessor::get(const YamlObject &obj) const\n {\n \treturn obj.get();\n }\n \n template<>\n std::optional\n-YamlObject::Getter::get(const YamlObject &obj) const\n+YamlObject::Accessor::get(const YamlObject &obj) const\n {\n \tif (obj.type_ != Type::Value)\n \t\treturn std::nullopt;\n@@ -210,7 +210,7 @@ YamlObject::Getter::get(const YamlObject &obj) const\n \n template<>\n std::optional\n-YamlObject::Getter::get(const YamlObject &obj) const\n+YamlObject::Accessor::get(const YamlObject &obj) const\n {\n \tif (obj.type_ != Type::Value)\n \t\treturn std::nullopt;\n@@ -220,7 +220,7 @@ YamlObject::Getter::get(const YamlObject &obj) const\n \n template<>\n std::optional\n-YamlObject::Getter::get(const YamlObject &obj) const\n+YamlObject::Accessor::get(const YamlObject &obj) const\n {\n \tif (obj.type_ != Type::List)\n \t\treturn std::nullopt;\n","prefixes":["10/36"]}