{"id":25721,"url":"https://patchwork.libcamera.org/api/1.1/patches/25721/?format=json","web_url":"https://patchwork.libcamera.org/patch/25721/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260113000808.15395-2-laurent.pinchart@ideasonboard.com>","date":"2026-01-13T00:07:33","name":"[01/36] libcamera: Drop unneeded usage of this pointer","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"c075be8ebeabd2136bdb24b46030a94c8a599df5","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/1.1/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/25721/mbox/","series":[{"id":5703,"url":"https://patchwork.libcamera.org/api/1.1/series/5703/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5703","date":"2026-01-13T00:07:32","name":"libcamera: Global configuration file improvements","version":1,"mbox":"https://patchwork.libcamera.org/series/5703/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/25721/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/25721/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D54B0C323E\n\tfor ;\n\tTue, 13 Jan 2026 00:08:34 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id CB73661FA0;\n\tTue, 13 Jan 2026 01:08:33 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 667B761FA0\n\tfor ;\n\tTue, 13 Jan 2026 01:08:31 +0100 (CET)","from pendragon.ideasonboard.com (81-175-209-152.bb.dnainternet.fi\n\t[81.175.209.152])\n\tby perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id B576B50A\n\tfor ;\n\tTue, 13 Jan 2026 01:08:05 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"MuL46d3p\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1768262885;\n\tbh=PAtzAHaKdBlO6Tkd0aWC59iMcw81Se8BXhuUX59gAIk=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=MuL46d3ptVlny98mAm5UMMgwd5opEw6Ny0wqC7Iu3Gv4b19C9vpjSVEp3lX7THPnu\n\t7gic0j8FrWsXF0thMziywilqLYhGGdsEGdLnwurnLMJ2hffnUJ2WQ40vAiP4LgpJbk\n\t5B3V9NRLVo4FBwSEv7j7BkIcQD5OLawFVayxKzyU=","From":"Laurent Pinchart ","To":"libcamera-devel@lists.libcamera.org","Subject":"[PATCH 01/36] libcamera: Drop unneeded usage of this pointer","Date":"Tue, 13 Jan 2026 02:07:33 +0200","Message-ID":"<20260113000808.15395-2-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.51.2","In-Reply-To":"<20260113000808.15395-1-laurent.pinchart@ideasonboard.com>","References":"<20260113000808.15395-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"A few unneeded usages of the this pointer to quality access to class\nmembers have been introduced over time. Drop them.\n\nSigned-off-by: Laurent Pinchart \n---\n include/libcamera/internal/shared_mem_object.h | 4 ++--\n src/libcamera/camera_manager.cpp | 2 +-\n src/libcamera/shared_mem_object.cpp | 8 ++++----\n 3 files changed, 7 insertions(+), 7 deletions(-)","diff":"diff --git a/include/libcamera/internal/shared_mem_object.h b/include/libcamera/internal/shared_mem_object.h\nindex e9f1dacd731d..21e025513fdf 100644\n--- a/include/libcamera/internal/shared_mem_object.h\n+++ b/include/libcamera/internal/shared_mem_object.h\n@@ -79,7 +79,7 @@ public:\n \tSharedMemObject(SharedMemObject &&rhs)\n \t\t: SharedMem(std::move(rhs))\n \t{\n-\t\tthis->obj_ = rhs.obj_;\n+\t\tobj_ = rhs.obj_;\n \t\trhs.obj_ = nullptr;\n \t}\n \n@@ -92,7 +92,7 @@ public:\n \tSharedMemObject &operator=(SharedMemObject &&rhs)\n \t{\n \t\tSharedMem::operator=(std::move(rhs));\n-\t\tthis->obj_ = rhs.obj_;\n+\t\tobj_ = rhs.obj_;\n \t\trhs.obj_ = nullptr;\n \t\treturn *this;\n \t}\ndiff --git a/src/libcamera/camera_manager.cpp b/src/libcamera/camera_manager.cpp\nindex 23185467ba02..fc6e490bc476 100644\n--- a/src/libcamera/camera_manager.cpp\n+++ b/src/libcamera/camera_manager.cpp\n@@ -41,7 +41,7 @@ LOG_DEFINE_CATEGORY(Camera)\n CameraManager::Private::Private()\n \t: Thread(\"CameraManager\"), initialized_(false)\n {\n-\tipaManager_ = std::make_unique(this->configuration());\n+\tipaManager_ = std::make_unique(configuration());\n }\n \n int CameraManager::Private::start()\ndiff --git a/src/libcamera/shared_mem_object.cpp b/src/libcamera/shared_mem_object.cpp\nindex d9b61d37dd43..6edab045d47e 100644\n--- a/src/libcamera/shared_mem_object.cpp\n+++ b/src/libcamera/shared_mem_object.cpp\n@@ -80,8 +80,8 @@ SharedMem::SharedMem(const std::string &name, std::size_t size)\n */\n SharedMem::SharedMem(SharedMem &&rhs)\n {\n-\tthis->fd_ = std::move(rhs.fd_);\n-\tthis->mem_ = rhs.mem_;\n+\tfd_ = std::move(rhs.fd_);\n+\tmem_ = rhs.mem_;\n \trhs.mem_ = {};\n }\n \n@@ -109,8 +109,8 @@ SharedMem::~SharedMem()\n */\n SharedMem &SharedMem::operator=(SharedMem &&rhs)\n {\n-\tthis->fd_ = std::move(rhs.fd_);\n-\tthis->mem_ = rhs.mem_;\n+\tfd_ = std::move(rhs.fd_);\n+\tmem_ = rhs.mem_;\n \trhs.mem_ = {};\n \treturn *this;\n }\n","prefixes":["01/36"]}