{"id":25707,"url":"https://patchwork.libcamera.org/api/1.1/patches/25707/?format=json","web_url":"https://patchwork.libcamera.org/patch/25707/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260110170927.79918-2-robert.mader@collabora.com>","date":"2026-01-10T17:09:24","name":"[1/4] egl: Remove unused functions","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"baf30219069c0b626ef5bcec8d53d9bb4cae5942","submitter":{"id":140,"url":"https://patchwork.libcamera.org/api/1.1/people/140/?format=json","name":"Robert Mader","email":"robert.mader@collabora.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/25707/mbox/","series":[{"id":5698,"url":"https://patchwork.libcamera.org/api/1.1/series/5698/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5698","date":"2026-01-10T17:09:23","name":"GPUISP cleanups","version":1,"mbox":"https://patchwork.libcamera.org/series/5698/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/25707/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/25707/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 97B05BE08B\n\tfor ;\n\tSat, 10 Jan 2026 17:10:20 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4EA6A61FA0;\n\tSat, 10 Jan 2026 18:10:20 +0100 (CET)","from sender4-pp-f112.zoho.com (sender4-pp-f112.zoho.com\n\t[136.143.188.112])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E25D861A35\n\tfor ;\n\tSat, 10 Jan 2026 18:10:18 +0100 (CET)","by mx.zohomail.com with SMTPS id 1768065013843292.75368789859726; \n\tSat, 10 Jan 2026 09:10:13 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=collabora.com\n\theader.i=robert.mader@collabora.com header.b=\"FMouCjkq\"; \n\tdkim-atps=neutral","ARC-Seal":"i=1; a=rsa-sha256; t=1768065015; cv=none; \n\td=zohomail.com; s=zohoarc; \n\tb=DpRfOWe6RzJofbBK7AgnEtZoyUW4u22s+GX27fY04afCy9hgK5H0Ce4c3xkg5qCuu/3vW1rb0vu/F7P3cX7ROa7xIrJthxZy7gnPGg+ZiBdBLoFBWeBNUshbxvIWjFFyhaiZHSkH/21jkwqJ2l6T4ZHwss0g6c5MZODbTj7xNUs=","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; \n\ts=zohoarc; t=1768065015;\n\th=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To;\n\tbh=bFFrq++5ofhqy9jPSw2PTaF8NtQ+WlvlI5/s/WvKYVw=; \n\tb=hHBiLut7Ok5k5o6p7V7RryuibA1vxIUgok5icLzGhHRP1NYSEShb4r+U5WMNhNNzWENl/thQsv782WzAqJNbbV06EgbcV+WO33gYFpl2ZQD7KGcdQDLeaWr75EVppO4MTwJRRoOrdoEXCqQNdCYVLIF4LhkUjc8NIAk6ER8dtP4=","ARC-Authentication-Results":"i=1; mx.zohomail.com;\n\tdkim=pass header.i=collabora.com;\n\tspf=pass smtp.mailfrom=robert.mader@collabora.com;\n\tdmarc=pass header.from=","DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1768065015;\n\ts=zohomail; d=collabora.com; i=robert.mader@collabora.com;\n\th=From:From:To:To:Cc:Cc:Subject:Subject:Date:Date:Message-ID:In-Reply-To:References:MIME-Version:Content-Transfer-Encoding:Message-Id:Reply-To;\n\tbh=bFFrq++5ofhqy9jPSw2PTaF8NtQ+WlvlI5/s/WvKYVw=;\n\tb=FMouCjkqh4F0qFzr/jfzli+MJhP0UD46BdXexuVNr68Eh8kiNQWBVuEkh7n76YiG\n\tZ9V4mPOj/iMsWRasF56xBQXih5lh4rJGUPWMj29SUZVSmqRSm1Odsipk0kNIM6TLkRI\n\tRCdSrRzgdFNsMPw5BqhwIvqiGu4ssxpnb7j3iJxA=","From":"Robert Mader ","To":"libcamera-devel@lists.libcamera.org","Cc":"Robert Mader ","Subject":"[PATCH 1/4] egl: Remove unused functions","Date":"Sat, 10 Jan 2026 18:09:24 +0100","Message-ID":"<20260110170927.79918-2-robert.mader@collabora.com>","X-Mailer":"git-send-email 2.52.0","In-Reply-To":"<20260110170927.79918-1-robert.mader@collabora.com>","References":"<20260110170927.79918-1-robert.mader@collabora.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"They are left-overs from older iterations of the GPU-ISP.\n\nSigned-off-by: Robert Mader \n---\n include/libcamera/internal/egl.h | 10 ----------\n src/libcamera/egl.cpp | 10 ----------\n src/libcamera/software_isp/debayer_egl.cpp | 2 --\n 3 files changed, 22 deletions(-)","diff":"diff --git a/include/libcamera/internal/egl.h b/include/libcamera/internal/egl.h\nindex a92921123..7b810773c 100644\n--- a/include/libcamera/internal/egl.h\n+++ b/include/libcamera/internal/egl.h\n@@ -64,15 +64,6 @@ public:\n \t\tglGenFramebuffers(1, &fbo_);\n \t}\n \n-\t/**\n-\t * \\brief Construct an eGLImage with automatic stride calculation\n-\t */\n-\teGLImage(uint32_t width, uint32_t height, uint32_t bpp, GLenum texture_unit, uint32_t texture_unit_uniform_id)\n-\t\t: eGLImage(width, height, bpp, utils::alignUp(width * bpp / 8, 256),\n-\t\t\t texture_unit, texture_unit_uniform_id)\n-\t{\n-\t}\n-\n \t/**\n \t * \\brief Destroy the eGLImage\n \t *\n@@ -108,7 +99,6 @@ public:\n \t~eGL();\n \n \tint initEGLContext(GBM *gbmContext);\n-\tvoid cleanUp();\n \n \tint createInputDMABufTexture2D(eGLImage &eglImage, int fd);\n \tint createOutputDMABufTexture2D(eGLImage &eglImage, int fd);\ndiff --git a/src/libcamera/egl.cpp b/src/libcamera/egl.cpp\nindex 0544056bd..fcaf7c58f 100644\n--- a/src/libcamera/egl.cpp\n+++ b/src/libcamera/egl.cpp\n@@ -349,16 +349,6 @@ fail:\n \treturn -ENODEV;\n }\n \n-/**\n- * \\brief Clean up EGL resources\n- *\n- * Destroys the EGL sync object. Must be called from the same thread\n- * that created the EGL context.\n- */\n-void eGL::cleanUp()\n-{\n-}\n-\n /**\n * \\brief Make the EGL context current for the calling thread\n *\ndiff --git a/src/libcamera/software_isp/debayer_egl.cpp b/src/libcamera/software_isp/debayer_egl.cpp\nindex 8e0890323..1c13b72a5 100644\n--- a/src/libcamera/software_isp/debayer_egl.cpp\n+++ b/src/libcamera/software_isp/debayer_egl.cpp\n@@ -615,8 +615,6 @@ void DebayerEGL::stop()\n \n \tif (programId_)\n \t\tglDeleteProgram(programId_);\n-\n-\tegl_.cleanUp();\n }\n \n SizeRange DebayerEGL::sizes(PixelFormat inputFormat, const Size &inputSize)\n","prefixes":["1/4"]}