{"id":25659,"url":"https://patchwork.libcamera.org/api/1.1/patches/25659/?format=json","web_url":"https://patchwork.libcamera.org/patch/25659/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260106170059.56193-6-bryan.odonoghue@linaro.org>","date":"2026-01-06T17:00:40","name":"[v11,05/24] libcamera: shaders: Rename bayer_8 to bayer_unpacked","commit_ref":"c31d6dba0386dbe0763072b69d5bf417c37744df","pull_url":null,"state":"accepted","archived":false,"hash":"35a6d78fdb97510d821282384ecb89af3e2b1926","submitter":{"id":175,"url":"https://patchwork.libcamera.org/api/1.1/people/175/?format=json","name":"Bryan O'Donoghue","email":"bryan.odonoghue@linaro.org"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/25659/mbox/","series":[{"id":5689,"url":"https://patchwork.libcamera.org/api/1.1/series/5689/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5689","date":"2026-01-06T17:00:35","name":"Add GLES 2.0 GPUISP to libcamera","version":10,"mbox":"https://patchwork.libcamera.org/series/5689/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/25659/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/25659/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 8A3EDC3213\n\tfor ;\n\tTue, 6 Jan 2026 17:01:15 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 32A0F6200B;\n\tTue, 6 Jan 2026 18:01:15 +0100 (CET)","from mail-wr1-x42c.google.com (mail-wr1-x42c.google.com\n\t[IPv6:2a00:1450:4864:20::42c])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6A29861FD2\n\tfor ;\n\tTue, 6 Jan 2026 18:01:11 +0100 (CET)","by mail-wr1-x42c.google.com with SMTP id\n\tffacd0b85a97d-42b3d7c1321so696795f8f.3\n\tfor ;\n\tTue, 06 Jan 2026 09:01:11 -0800 (PST)","from inspiron14p-linux.ht.home (188-141-3-146.dynamic.upc.ie.\n\t[188.141.3.146]) by smtp.gmail.com with ESMTPSA id\n\tffacd0b85a97d-432bd0dadcfsm5515322f8f.3.2026.01.06.09.01.08\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tTue, 06 Jan 2026 09:01:08 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"WW73P4nU\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=linaro.org; s=google; t=1767718871; x=1768323671;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=dsnpPU/LrCFQHtN8Cq9/x2B3nNAbe5b+r69TX5DJM4Y=;\n\tb=WW73P4nUYU2db9m2ELM//PFdK6PNDUb3tUyuSq38E0oCL0BuMMfFBmU/ph1TMh89TU\n\t37bpCmPP/dPgwg1M6a/QVyzhEnt/MDbnVHrKDHMCd+aMJ5Jp87DvxzN8VQYkBRGzBaAS\n\tMVwgFUj+TOcdwUNunGHejwkUG7grmzBDs+7Ystnw47bI+99C7jA3OemWo0llDM8rZIMX\n\tdhgn5uRpXTZjBhduaLUz0VsoMI9HfbvUWOpeIKB05N2JkFU5DJwQYROpmEg1BHzoNiNK\n\txQ/k90l3FwcXQG/keTYh02gjv/4qT7WcOxJudNNpeLkPctvgPGKLfOWwRa6cLgNs/HFA\n\tB6jw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1767718871; x=1768323671;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n\t:to:cc:subject:date:message-id:reply-to;\n\tbh=dsnpPU/LrCFQHtN8Cq9/x2B3nNAbe5b+r69TX5DJM4Y=;\n\tb=IQ4VCymwAksiRfV9QDnO5Fq1vHr8DRJZSrTduf3YJc+knEmqkCQQzmH23RRF4x0iot\n\tR9LknSHHRCpI2vrbvAIB73cfFxP6PQG9bjLwWEleP8jrVSlDLqdVlvMXU+NxkeGmlGX8\n\twvMb7HObfJ08IGunFmSXZ8PN7YBmgA/i6eRB/iYQvqpE3khTYADqG8IBoXl+T8vFDoHk\n\th1qHG3BOiZOe+BkRDKu+YQ8umFmd9rk8p936nSM1h9+/vYryPTS1WAkUl8DmX/wuOxYA\n\tM3rFKp4Vytzb6+cYPQVlcxip41DoLJ7whK/Wn5DOu/wrYYpQwy0owZYIq8CoAzUCqTE4\n\tVf6g==","X-Gm-Message-State":"AOJu0YxvSWc0Lv9kXadzZ2LDmk2jvEJJzm+TvhNkXuM3MnheTsyi1dHA\n\tBuLbDssB9xKwnkmQB60tg3E7M/hpsY/9bvPFgFy4KaRehWZ6u7t/Y7KaWY+LvF/QHi12m14tMvl\n\tEsD0YY5s=","X-Gm-Gg":"AY/fxX4mFL1ftvuIueZaQT0qO8/CKjkaIzTkrfrMf5Z0Bs7IZD69fVXyXkEhi5TKVdh\n\tF6TaPwuAwSl5uUg84eL4b7Owlz+hTRMa++cqUeDT84jxUpaUi1Yh/5mjDv0EHJyApt4gwbWxnAQ\n\t0reO0cHwBPpfcwcyGXR0l9QgETpCBFOtFSeQm0Wi+Uol96aLkvtx/FtS6RMD/AxfnxJvY2XNpYT\n\tlGSxUj6Ii7ewYSku07tPqI0kdwfAccHHJDnrHuJjI9ZhJuCMQhKEfaroveugh2+dX1oj2X1GFov\n\tl1remnnTW0rDuyqP6FoharP3YN9lwXumi+nSTDLxSJTsRmXvuWSkRj3t5Rcm3OnaZetIi41LArH\n\tMgbQzoH1d8g82DHfKdhIfmn70XLj6yH7bu/HOiZTh3Y0ttxQh6rG2+1MXtZ6E58d37b0P19gzBj\n\ta8oaLj19WzyA8Fa/Xv5xsH0Ys9OcD2Tj3goyG78TyGAYlYndWBRvU4F4CsRhjpqKnlVpE=","X-Google-Smtp-Source":"AGHT+IEkCiNe5TJa+bkQk6UUXwXrfVz/J+QVkfoecD2ildZitOsx8dYn1yWY7y+JURWbufuGvH+U0g==","X-Received":"by 2002:a05:6000:220f:b0:430:f5ed:83f3 with SMTP id\n\tffacd0b85a97d-432bc9cc8a6mr4321999f8f.9.1767718868978; \n\tTue, 06 Jan 2026 09:01:08 -0800 (PST)","From":"Bryan O'Donoghue ","To":"libcamera-devel@lists.libcamera.org","Cc":"pavel@ucw.cz, Milan Zamazal ,\n\tKieran Bingham ,\n\tBryan O'Donoghue ","Subject":"[PATCH v11 05/24] libcamera: shaders: Rename bayer_8 to\n\tbayer_unpacked","Date":"Tue, 6 Jan 2026 17:00:40 +0000","Message-ID":"<20260106170059.56193-6-bryan.odonoghue@linaro.org>","X-Mailer":"git-send-email 2.52.0","In-Reply-To":"<20260106170059.56193-1-bryan.odonoghue@linaro.org>","References":"<20260106170059.56193-1-bryan.odonoghue@linaro.org>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"From: Milan Zamazal \n\nbayer_8.* shaders are now used for all unpacked sensor data formats,\nregardless of the pixel bit width. Let's rename the \"8-bit\" shaders to\navoid confusion.\n\nSigned-off-by: Milan Zamazal \nReviewed-by: Kieran Bingham \nSigned-off-by: Bryan O'Donoghue \n---\n src/apps/qcam/assets/shader/shaders.qrc | 4 ++--\n src/apps/qcam/viewfinder_gl.cpp | 16 ++++++++--------\n .../{bayer_8.frag => bayer_unpacked.frag} | 0\n .../{bayer_8.vert => bayer_unpacked.vert} | 0\n src/libcamera/shaders/meson.build | 4 ++--\n 5 files changed, 12 insertions(+), 12 deletions(-)\n rename src/libcamera/shaders/{bayer_8.frag => bayer_unpacked.frag} (100%)\n rename src/libcamera/shaders/{bayer_8.vert => bayer_unpacked.vert} (100%)","diff":"diff --git a/src/apps/qcam/assets/shader/shaders.qrc b/src/apps/qcam/assets/shader/shaders.qrc\nindex 7369cdbe8..f11a68ef2 100644\n--- a/src/apps/qcam/assets/shader/shaders.qrc\n+++ b/src/apps/qcam/assets/shader/shaders.qrc\n@@ -6,8 +6,8 @@\n \t../../../../../src/libcamera/shaders/YUV_3_planes.frag\n \t../../../../../src/libcamera/shaders/YUV_packed.frag\n \t../../../../../src/libcamera/shaders/bayer_1x_packed.frag\n-\t../../../../../src/libcamera/shaders/bayer_8.frag\n-\t../../../../../src/libcamera/shaders/bayer_8.vert\n+\t../../../../../src/libcamera/shaders/bayer_unpacked.frag\n+\t../../../../../src/libcamera/shaders/bayer_unpacked.vert\n \t../../../../../src/libcamera/shaders/identity.vert\n \n \ndiff --git a/src/apps/qcam/viewfinder_gl.cpp b/src/apps/qcam/viewfinder_gl.cpp\nindex 0d06122f6..1d3f48917 100644\n--- a/src/apps/qcam/viewfinder_gl.cpp\n+++ b/src/apps/qcam/viewfinder_gl.cpp\n@@ -235,29 +235,29 @@ bool ViewFinderGL::selectFormat(const libcamera::PixelFormat &format)\n \tcase libcamera::formats::SBGGR8:\n \t\tfirstRed_.setX(1.0);\n \t\tfirstRed_.setY(1.0);\n-\t\tvertexShaderFile_ = \":src/libcamera/shaders/bayer_8.vert\";\n-\t\tfragmentShaderFile_ = \":src/libcamera/shaders/bayer_8.frag\";\n+\t\tvertexShaderFile_ = \":src/libcamera/shaders/bayer_unpacked.vert\";\n+\t\tfragmentShaderFile_ = \":src/libcamera/shaders/bayer_unpacked.frag\";\n \t\ttextureMinMagFilters_ = GL_NEAREST;\n \t\tbreak;\n \tcase libcamera::formats::SGBRG8:\n \t\tfirstRed_.setX(0.0);\n \t\tfirstRed_.setY(1.0);\n-\t\tvertexShaderFile_ = \":src/libcamera/shaders/bayer_8.vert\";\n-\t\tfragmentShaderFile_ = \":src/libcamera/shaders/bayer_8.frag\";\n+\t\tvertexShaderFile_ = \":src/libcamera/shaders/bayer_unpacked.vert\";\n+\t\tfragmentShaderFile_ = \":src/libcamera/shaders/bayer_unpacked.frag\";\n \t\ttextureMinMagFilters_ = GL_NEAREST;\n \t\tbreak;\n \tcase libcamera::formats::SGRBG8:\n \t\tfirstRed_.setX(1.0);\n \t\tfirstRed_.setY(0.0);\n-\t\tvertexShaderFile_ = \":src/libcamera/shaders/bayer_8.vert\";\n-\t\tfragmentShaderFile_ = \":src/libcamera/shaders/bayer_8.frag\";\n+\t\tvertexShaderFile_ = \":src/libcamera/shaders/bayer_unpacked.vert\";\n+\t\tfragmentShaderFile_ = \":src/libcamera/shaders/bayer_unpacked.frag\";\n \t\ttextureMinMagFilters_ = GL_NEAREST;\n \t\tbreak;\n \tcase libcamera::formats::SRGGB8:\n \t\tfirstRed_.setX(0.0);\n \t\tfirstRed_.setY(0.0);\n-\t\tvertexShaderFile_ = \":src/libcamera/shaders/bayer_8.vert\";\n-\t\tfragmentShaderFile_ = \":src/libcamera/shaders/bayer_8.frag\";\n+\t\tvertexShaderFile_ = \":src/libcamera/shaders/bayer_unpacked.vert\";\n+\t\tfragmentShaderFile_ = \":src/libcamera/shaders/bayer_unpacked.frag\";\n \t\ttextureMinMagFilters_ = GL_NEAREST;\n \t\tbreak;\n \tcase libcamera::formats::SBGGR10_CSI2P:\ndiff --git a/src/libcamera/shaders/bayer_8.frag b/src/libcamera/shaders/bayer_unpacked.frag\nsimilarity index 100%\nrename from src/libcamera/shaders/bayer_8.frag\nrename to src/libcamera/shaders/bayer_unpacked.frag\ndiff --git a/src/libcamera/shaders/bayer_8.vert b/src/libcamera/shaders/bayer_unpacked.vert\nsimilarity index 100%\nrename from src/libcamera/shaders/bayer_8.vert\nrename to src/libcamera/shaders/bayer_unpacked.vert\ndiff --git a/src/libcamera/shaders/meson.build b/src/libcamera/shaders/meson.build\nindex 386b342d0..dd441a577 100644\n--- a/src/libcamera/shaders/meson.build\n+++ b/src/libcamera/shaders/meson.build\n@@ -4,7 +4,7 @@\n # for the purposes of inclusion in OpenGL debayering\n shader_files = files([\n 'bayer_1x_packed.frag',\n- 'bayer_8.frag',\n- 'bayer_8.vert',\n+ 'bayer_unpacked.frag',\n+ 'bayer_unpacked.vert',\n 'identity.vert',\n ])\n","prefixes":["v11","05/24"]}