{"id":25658,"url":"https://patchwork.libcamera.org/api/1.1/patches/25658/?format=json","web_url":"https://patchwork.libcamera.org/patch/25658/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260106170059.56193-7-bryan.odonoghue@linaro.org>","date":"2026-01-06T17:00:41","name":"[v11,06/24] libcamera: shaders: Use highp not mediump for float precision","commit_ref":"c9954de93d77526eb7ea4a53322f535a5282c49d","pull_url":null,"state":"accepted","archived":false,"hash":"6c6d01298168b7fdda1e1bf9b659e20aec8e0b4b","submitter":{"id":175,"url":"https://patchwork.libcamera.org/api/1.1/people/175/?format=json","name":"Bryan O'Donoghue","email":"bryan.odonoghue@linaro.org"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/25658/mbox/","series":[{"id":5689,"url":"https://patchwork.libcamera.org/api/1.1/series/5689/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5689","date":"2026-01-06T17:00:35","name":"Add GLES 2.0 GPUISP to libcamera","version":10,"mbox":"https://patchwork.libcamera.org/series/5689/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/25658/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/25658/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 8178EBDCC0\n\tfor ;\n\tTue, 6 Jan 2026 17:01:14 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 36D8C62001;\n\tTue, 6 Jan 2026 18:01:14 +0100 (CET)","from mail-wr1-x429.google.com (mail-wr1-x429.google.com\n\t[IPv6:2a00:1450:4864:20::429])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id DEE6A61FD8\n\tfor ;\n\tTue, 6 Jan 2026 18:01:10 +0100 (CET)","by mail-wr1-x429.google.com with SMTP id\n\tffacd0b85a97d-430f9ffd4e8so12048f8f.0\n\tfor ;\n\tTue, 06 Jan 2026 09:01:10 -0800 (PST)","from inspiron14p-linux.ht.home (188-141-3-146.dynamic.upc.ie.\n\t[188.141.3.146]) by smtp.gmail.com with ESMTPSA id\n\tffacd0b85a97d-432bd0dadcfsm5515322f8f.3.2026.01.06.09.01.09\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tTue, 06 Jan 2026 09:01:09 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"HbyTje2Q\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=linaro.org; s=google; t=1767718870; x=1768323670;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=FdyTcK0Xun67yTvAExHcO9DNNAcWNw/aYg3LzuhT/Zc=;\n\tb=HbyTje2Qt3bypbGQ+MKR2A1lhOly6h/tw6TNjaon0T1Fc49Krm1iP/Z5KaLE1pgrkK\n\tB14pVyBX5mW+PFHdwmxWb4XvyK7pil2R5Vra/90JCWXuIiZEd7druHP5bHe//WUov17v\n\t5c+qF+RFBCWwV2us6QsxycJLR8hZujjFaFFWZgS3kqegbSWeMK6174S5IEYFa/LF31DP\n\tTTKY2tfA92tCMNEcZOK/R7wb5gGySWQB7/gxSFihzGmXutOz3rFLo/9zkBKVNOMB3bg9\n\tHdZqACJGm79eEL7enmSoR//tjprr6wNb4BpOAGHn1Xq8UXybg/ws63avMj9nNhlTJi1j\n\tB5UQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1767718870; x=1768323670;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n\t:to:cc:subject:date:message-id:reply-to;\n\tbh=FdyTcK0Xun67yTvAExHcO9DNNAcWNw/aYg3LzuhT/Zc=;\n\tb=wEHli2nxpDRd2XCZsS3p38sQmYnH3oRkL/sqD9f/lGARFCJF7u1Y1k5DOo5gTkBL19\n\tnG6PXe55p7KgWSuoFLFEn2uAdOUTMzJXsJaAd5Ov2ROYybWgjzczEHF/36soFEDMmL3G\n\tTh/sT5/6PCUeQCX09974HydbsLuWfa2iab5irQ6fdqKZRndrYqtQG4wWWyX/maYdkpuu\n\t15V9aUsNMjzNEaF4UoApKx2Znr+HVuVX3Mx2R2X0a5y/tGPj+VDug064QMVTL222HZnT\n\tBxpJ4RpHTR+Wg7GnnA2w52IXU8OXZzTPN4F6pNGbjdDc8u8mV4OmoBCoLon/YgZrmxRj\n\t6k2w==","X-Gm-Message-State":"AOJu0YxIlyjJXv2BoWA7umfb2V3HsIa8O1CuU0ABT5eLp4ROEhp5FRKc\n\tD3vpg5hraQCNfBsEKFK+yflRTTXxSXT2QPQnuGh83hTwB+kADTX4Zz0vc3H3jOyXzG2KkEk6iaR\n\tVO9N2huc=","X-Gm-Gg":"AY/fxX4HvvAEdPXFLdy3wGyxceDhdd0dv7slty3aPXIW76qJetG8FLJRI8CINhRmfds\n\twh2rwGKvbh+bZ+l0FrbtVMR1zT/P49thuxp/Pq6TgqTh+/qc+oPKe/TqqSfojNqdjKZvwe/p3qf\n\td2lIaeU+xnmo5L8HXK+ihQFvxMBQ6JRMCETTZYrZEPTwVbpAEUjKgsnVRPJR1gUFZeRc7Uz7d2H\n\tkG++6v3N9bCGkPoZOnDVhtJlGBctA5/z3ZRH9JItaVkht/QsHKFEdxtpLUgYoYiZ7iUJCuxLO9S\n\tr9nTaVFxbjg+KhCMbJc641Bmm9T7Jee+Txu4ygvu71sjGLIxrCeqBL1t55qNuln643Y07itdWpy\n\txjpNAqDYTewo4e9Yolw95r2zzvoy+I++krfq9015dARSVvoWgoPRrcAVbe/T4AwDepkBty50PW2\n\t2b19UsTxvWdQckNstvn0/VgOZrQ0CJERxlHWN3GrsBd84OQ/pr2VhAdz8q50OSks26j0I=","X-Google-Smtp-Source":"AGHT+IGA3h8/j0K6YrgdG79neI22XcE/kolLhlAEY4OCLvXgzRRCxOe+ckTu2IzZMdiNAgdisF2TEA==","X-Received":"by 2002:a05:6000:3107:b0:430:f593:aa34 with SMTP id\n\tffacd0b85a97d-432bcfd3d38mr4146306f8f.17.1767718869930; \n\tTue, 06 Jan 2026 09:01:09 -0800 (PST)","From":"Bryan O'Donoghue ","To":"libcamera-devel@lists.libcamera.org","Cc":"pavel@ucw.cz, Bryan O'Donoghue ,\n\tKieran Bingham ,\n\tMilan Zamazal ","Subject":"[PATCH v11 06/24] libcamera: shaders: Use highp not mediump for\n\tfloat precision","Date":"Tue, 6 Jan 2026 17:00:41 +0000","Message-ID":"<20260106170059.56193-7-bryan.odonoghue@linaro.org>","X-Mailer":"git-send-email 2.52.0","In-Reply-To":"<20260106170059.56193-1-bryan.odonoghue@linaro.org>","References":"<20260106170059.56193-1-bryan.odonoghue@linaro.org>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"mediump gives 10 bits of mantissa as the resolution. At higher resolutions\n10 bits of accuracy is insufficient - for example at a width of 1928 bytes\nwe need log2(1928) = ~11 bit resolution.\n\nSwitching to highp gives us 23 bits of mantissa giving a sample width\nprecision of about 2^23 ~ 8,388,608.\n\nAcked-by: Kieran Bingham \nReviewed-by: Milan Zamazal \nSigned-off-by: Bryan O'Donoghue \n---\n src/libcamera/shaders/RGB.frag | 2 +-\n src/libcamera/shaders/YUV_2_planes.frag | 2 +-\n src/libcamera/shaders/YUV_3_planes.frag | 2 +-\n src/libcamera/shaders/YUV_packed.frag | 2 +-\n src/libcamera/shaders/bayer_1x_packed.frag | 2 +-\n src/libcamera/shaders/bayer_unpacked.frag | 2 +-\n 6 files changed, 6 insertions(+), 6 deletions(-)","diff":"diff --git a/src/libcamera/shaders/RGB.frag b/src/libcamera/shaders/RGB.frag\nindex 4c374ac98..724395894 100644\n--- a/src/libcamera/shaders/RGB.frag\n+++ b/src/libcamera/shaders/RGB.frag\n@@ -6,7 +6,7 @@\n */\n \n #ifdef GL_ES\n-precision mediump float;\n+precision highp float;\n #endif\n \n varying vec2 textureOut;\ndiff --git a/src/libcamera/shaders/YUV_2_planes.frag b/src/libcamera/shaders/YUV_2_planes.frag\nindex 1d5d12062..d286f1179 100644\n--- a/src/libcamera/shaders/YUV_2_planes.frag\n+++ b/src/libcamera/shaders/YUV_2_planes.frag\n@@ -6,7 +6,7 @@\n */\n \n #ifdef GL_ES\n-precision mediump float;\n+precision highp float;\n #endif\n \n varying vec2 textureOut;\ndiff --git a/src/libcamera/shaders/YUV_3_planes.frag b/src/libcamera/shaders/YUV_3_planes.frag\nindex 8f788e90a..8e3e0b4a5 100644\n--- a/src/libcamera/shaders/YUV_3_planes.frag\n+++ b/src/libcamera/shaders/YUV_3_planes.frag\n@@ -6,7 +6,7 @@\n */\n \n #ifdef GL_ES\n-precision mediump float;\n+precision highp float;\n #endif\n \n varying vec2 textureOut;\ndiff --git a/src/libcamera/shaders/YUV_packed.frag b/src/libcamera/shaders/YUV_packed.frag\nindex b9ef9d41b..3c9e3e397 100644\n--- a/src/libcamera/shaders/YUV_packed.frag\n+++ b/src/libcamera/shaders/YUV_packed.frag\n@@ -6,7 +6,7 @@\n */\n \n #ifdef GL_ES\n-precision mediump float;\n+precision highp float;\n #endif\n \n varying vec2 textureOut;\ndiff --git a/src/libcamera/shaders/bayer_1x_packed.frag b/src/libcamera/shaders/bayer_1x_packed.frag\nindex f53f55758..19b13ad08 100644\n--- a/src/libcamera/shaders/bayer_1x_packed.frag\n+++ b/src/libcamera/shaders/bayer_1x_packed.frag\n@@ -20,7 +20,7 @@\n */\n \n #ifdef GL_ES\n-precision mediump float;\n+precision highp float;\n #endif\n \n /*\ndiff --git a/src/libcamera/shaders/bayer_unpacked.frag b/src/libcamera/shaders/bayer_unpacked.frag\nindex 7e35ca88e..aa7a1b004 100644\n--- a/src/libcamera/shaders/bayer_unpacked.frag\n+++ b/src/libcamera/shaders/bayer_unpacked.frag\n@@ -16,7 +16,7 @@ Copyright (C) 2021, Linaro\n \n //Pixel Shader\n #ifdef GL_ES\n-precision mediump float;\n+precision highp float;\n #endif\n \n /** Monochrome RGBA or GL_LUMINANCE Bayer encoded texture.*/\n","prefixes":["v11","06/24"]}