{"id":25641,"url":"https://patchwork.libcamera.org/api/1.1/patches/25641/?format=json","web_url":"https://patchwork.libcamera.org/patch/25641/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260106165754.1759831-12-barnabas.pocze@ideasonboard.com>","date":"2026-01-06T16:57:43","name":"[v4,11/22] libcamera: request: Store `MetadataList`","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"b9caf847af0a558a701872b51865538765a6bb2e","submitter":{"id":216,"url":"https://patchwork.libcamera.org/api/1.1/people/216/?format=json","name":"Barnabás Pőcze","email":"barnabas.pocze@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/25641/mbox/","series":[{"id":5688,"url":"https://patchwork.libcamera.org/api/1.1/series/5688/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5688","date":"2026-01-06T16:57:32","name":"libcamera: Add `MetadataList`","version":4,"mbox":"https://patchwork.libcamera.org/series/5688/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/25641/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/25641/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 8EF59BDCBF\n\tfor ;\n\tTue, 6 Jan 2026 16:58:17 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 6FC8361FEC;\n\tTue, 6 Jan 2026 17:58:10 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id DB2E461FCC\n\tfor ;\n\tTue, 6 Jan 2026 17:58:00 +0100 (CET)","from pb-laptop.local (185.221.143.114.nat.pool.zt.hu\n\t[185.221.143.114])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id CB5F51924;\n\tTue, 6 Jan 2026 17:57:39 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"dTfR8L/j\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1767718659;\n\tbh=uo7flEGhas2heoe8Xah3bBOF4KdVGGGD9l326H5HN2Y=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=dTfR8L/jSBfNvrm+fKmWpS/OrmufO/XdZVZhj75RFC4ZT4JYMh8MhGlERjNShV6N6\n\tHHair4H+2tzoAm+B370lL+jL0d6+X5Ly7EXZGc4fMPTBjNmNxYHkDgamyXJRqf9lpJ\n\tEG47RXgRk1gYjPYHaNQvV0hhgRJth9NE8LTBIgmQ=","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","To":"libcamera-devel@lists.libcamera.org","Cc":"Jacopo Mondi ,\n\tPaul Elder ","Subject":"[PATCH v4 11/22] libcamera: request: Store `MetadataList`","Date":"Tue, 6 Jan 2026 17:57:43 +0100","Message-ID":"<20260106165754.1759831-12-barnabas.pocze@ideasonboard.com>","X-Mailer":"git-send-email 2.52.0","In-Reply-To":"<20260106165754.1759831-1-barnabas.pocze@ideasonboard.com>","References":"<20260106165754.1759831-1-barnabas.pocze@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Add a `MetadataList` to the `Request` object to store the metadata items\nreturned by the camera. The metadata list is initialized using the camera's\n`MetadataListPlan` object, which is supposed to be filled by the pipeline\nhandlers.\n\nThis new list is exposed as `metadata2`, and the old `ControlList` is\nstill present for now.\n\nSigned-off-by: Barnabás Pőcze \nReviewed-by: Jacopo Mondi \nReviewed-by: Paul Elder \n---\n include/libcamera/internal/request.h | 5 +++++\n include/libcamera/request.h | 5 +++++\n src/libcamera/request.cpp | 11 ++++++++++-\n 3 files changed, 20 insertions(+), 1 deletion(-)","diff":"diff --git a/include/libcamera/internal/request.h b/include/libcamera/internal/request.h\nindex 693097ee9..3e10ae051 100644\n--- a/include/libcamera/internal/request.h\n+++ b/include/libcamera/internal/request.h\n@@ -16,6 +16,7 @@\n #include \n #include \n \n+#include \n #include \n \n using namespace std::chrono_literals;\n@@ -37,6 +38,9 @@ public:\n \tbool hasPendingBuffers() const;\n \n \tControlList &metadata() { return metadata_; }\n+#ifndef __DOXYGEN__\n+\t[[nodiscard]] MetadataList &metadata2() { return metadata2_; }\n+#endif\n \n \tbool completeBuffer(FrameBuffer *buffer);\n \tvoid complete();\n@@ -64,6 +68,7 @@ private:\n \tstd::map notifiers_;\n \tstd::unique_ptr timer_;\n \tControlList metadata_;\n+\tMetadataList metadata2_;\n };\n \n } /* namespace libcamera */\ndiff --git a/include/libcamera/request.h b/include/libcamera/request.h\nindex 290983f61..96755a655 100644\n--- a/include/libcamera/request.h\n+++ b/include/libcamera/request.h\n@@ -24,6 +24,7 @@ namespace libcamera {\n class Camera;\n class CameraControlValidator;\n class FrameBuffer;\n+class MetadataList;\n class Stream;\n \n class Request : public Extensible\n@@ -51,6 +52,10 @@ public:\n \n \tControlList &controls() { return controls_; }\n \tconst ControlList &metadata() const;\n+#ifndef __DOXYGEN__\n+\t[[nodiscard]] const MetadataList &metadata2() const;\n+#endif\n+\n \tconst BufferMap &buffers() const { return bufferMap_; }\n \tint addBuffer(const Stream *stream, FrameBuffer *buffer,\n \t\t std::unique_ptr &&fence = {});\ndiff --git a/src/libcamera/request.cpp b/src/libcamera/request.cpp\nindex 57f1f060d..6d44c6749 100644\n--- a/src/libcamera/request.cpp\n+++ b/src/libcamera/request.cpp\n@@ -57,7 +57,8 @@ LOG_DEFINE_CATEGORY(Request)\n * \\todo Add a validator for metadata controls.\n */\n Request::Private::Private(Camera *camera)\n-\t: camera_(camera), cancelled_(false), metadata_(controls::controls)\n+\t: camera_(camera), cancelled_(false), metadata_(controls::controls),\n+\t metadata2_(camera->metadata())\n {\n }\n \n@@ -405,6 +406,7 @@ void Request::reuse(ReuseFlag flags)\n \n \tcontrols_.clear();\n \t_d()->metadata_.clear();\n+\t_d()->metadata2_.clear();\n }\n \n /**\n@@ -432,6 +434,13 @@ const ControlList &Request::metadata() const\n \treturn _d()->metadata_;\n }\n \n+#ifndef __DOXYGEN__\n+const MetadataList &Request::metadata2() const\n+{\n+\treturn _d()->metadata2_;\n+}\n+#endif\n+\n /**\n * \\fn Request::buffers()\n * \\brief Retrieve the request's streams to buffers map\n","prefixes":["v4","11/22"]}