{"id":25581,"url":"https://patchwork.libcamera.org/api/1.1/patches/25581/?format=json","web_url":"https://patchwork.libcamera.org/patch/25581/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20251217100138.82525-9-bryan.odonoghue@linaro.org>","date":"2025-12-17T10:01:20","name":"[v9,08/26] libcamera: shaders: Add support for black level compensation","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"1e4d840dcfd8f9799dd645f70a5f669ba26f823b","submitter":{"id":175,"url":"https://patchwork.libcamera.org/api/1.1/people/175/?format=json","name":"Bryan O'Donoghue","email":"bryan.odonoghue@linaro.org"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/25581/mbox/","series":[{"id":5669,"url":"https://patchwork.libcamera.org/api/1.1/series/5669/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5669","date":"2025-12-17T10:01:12","name":"Add GLES 2.0 GPUISP to libcamera","version":9,"mbox":"https://patchwork.libcamera.org/series/5669/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/25581/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/25581/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E2097C3274\n\tfor ;\n\tWed, 17 Dec 2025 10:02:04 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 41B0A61A4E;\n\tWed, 17 Dec 2025 11:02:04 +0100 (CET)","from mail-wm1-x329.google.com (mail-wm1-x329.google.com\n\t[IPv6:2a00:1450:4864:20::329])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A552961A61\n\tfor ;\n\tWed, 17 Dec 2025 11:01:52 +0100 (CET)","by mail-wm1-x329.google.com with SMTP id\n\t5b1f17b1804b1-4775ae77516so65869655e9.1\n\tfor ;\n\tWed, 17 Dec 2025 02:01:52 -0800 (PST)","from inspiron14p-linux.ht.home (188-141-3-146.dynamic.upc.ie.\n\t[188.141.3.146]) by smtp.gmail.com with ESMTPSA id\n\t5b1f17b1804b1-47bdc1583fbsm32292585e9.0.2025.12.17.02.01.50\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tWed, 17 Dec 2025 02:01:51 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"NODkQbXl\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=linaro.org; s=google; t=1765965712; x=1766570512;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=5qjoeAop1GzrvnIG7vvLvJkbwSmYKtE+YPe2MFgINpo=;\n\tb=NODkQbXl1JrepZVGUlixpxv9hjhhmuYVS+CNKBUNaYGQyKtyw5L3HfAz5NP6uPQQwT\n\tQAPAhfhUU4czsdvzFA9dxwWLLJm05cIwzMmpP/3REBpxQrrAuBSdBJbRF7H44898luPx\n\tA9nM3iChDqg95wG5+XlzZ9N1YwmI5exa9kzg1tW19byH8ifnfsWJ9A2/If8gFkfW/y88\n\tc5cccH68LsXpLzpNlorx2xyZai4rt3smkBAHLZQ/UbSkVCgnOeXapR/mox/gyUMuHsEr\n\t0B4wZW3eMrJxPJB6dwLBMzH6LRbo9nkcfZpHdDQTS9W1iWleMWZmyKebt1EAq6zHr33E\n\tM/rg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1765965712; x=1766570512;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n\t:to:cc:subject:date:message-id:reply-to;\n\tbh=5qjoeAop1GzrvnIG7vvLvJkbwSmYKtE+YPe2MFgINpo=;\n\tb=NZFK/1ZAuFvuSnKjl74NrPeD6zZ371zGBJf2tKd95On2EAiS6Jq6ki4wP6KbGZOUvg\n\tjh5M7vZ7QzPwIuVM9UuHMEGBkELch7LSuKbXcV3gqOpZnDhcfTfFE0Nk77WsxssU4mS5\n\tBlLdp/qu1EbCzx5kuPjo7LleVri1eNP8dUMltVQffrzgIOxcC/9CFPHRXN6J8k6Eb5OG\n\tLcK8ZUwDiUy8hQjv3Bp/uAHXP3G42BVVyoalCqGe1/s3uRb6AVENxSutMEMM7XDTxnVG\n\tPQyBi1Hyq1SoOKIrd56lNFu1Oy2sgkXtCcSeJVPUCF2E+m+Gjydip8CxPEb3oCgca7vC\n\ttgPw==","X-Gm-Message-State":"AOJu0YwRhukMq6aeyMhAZYTHfxzUS5Nyj1LINWx8U30ZgJ+utg+1MGrs\n\t5FoWYRRdl/5Rk4pzj/ZdI4ECwMG15JWrir8TRR5IZWkKzX32fhMKN7Y4rLC5xHLKwqq+qRB8DaP\n\twj+e6","X-Gm-Gg":"AY/fxX4r2dKkbUz8+mT2Hp9bJkuXb9z5qQ1VaJhbT40c6gDWJPlZJR8I/Zcd/5l7xQK\n\tkm0rErp32ULO92VoFYEbFFVGTJ4DXlwHOoDNVF1ea2WJiwNIegr8Vfj+AICVqThwQmDzM3E/gXu\n\ttAfqfevQYhZ/RVTNTDjFAAU4hNJnruIUWBy8hpm2DB34RcZR4u5rU2Ltco1WNUXS053ACRZ+Q3k\n\tVZGgWrGzNeO2Nx6VEASI7xjIHPpPf+u4PG/jqBxxPKO51BaFJIQek2ajiKLjac2sozitWTwR+Pv\n\t7GdlV9mzd3k8FgXCWtXuv3nLkEeIf8MjCe4dbZDPeFK6pXh1WApfcM1z0/Wz/uFNK0kdXYjWc+z\n\tRgk07dV9i62n7hImCJJ6PDDLmRq5zzJ4Ay5jbLo6US0aBhhO8+On3ASDvVnKZAdKJTmT6rBXy4Q\n\tPG/K8s4SrJMyo/exDgy2VzC4zXyJUMSuOm34g3Jvvfje229Wm5ZbTr5PhmZcAyEo4mZYM=","X-Google-Smtp-Source":"AGHT+IEbxmVj6iJaJeRujXAOmxO50UzzfHACot43NZJhcDF8OMis0J/Ok6txdUtyMYRYf4KNR2hh6Q==","X-Received":"by 2002:a05:600c:45cb:b0:477:9d54:58d7 with SMTP id\n\t5b1f17b1804b1-47be01a441dmr3730945e9.29.1765965711717; \n\tWed, 17 Dec 2025 02:01:51 -0800 (PST)","From":"Bryan O'Donoghue ","To":"libcamera-devel@lists.libcamera.org","Cc":"pavel@ucw.cz, Bryan O'Donoghue ,\n\tMilan Zamazal ","Subject":"[PATCH v9 08/26] libcamera: shaders: Add support for black level\n\tcompensation","Date":"Wed, 17 Dec 2025 10:01:20 +0000","Message-ID":"<20251217100138.82525-9-bryan.odonoghue@linaro.org>","X-Mailer":"git-send-email 2.52.0","In-Reply-To":"<20251217100138.82525-1-bryan.odonoghue@linaro.org>","References":"<20251217100138.82525-1-bryan.odonoghue@linaro.org>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Add the ability to apply a int blacklevel gain against the demosaiced data\nprior to application of colour correction data.\n\nReviewed-by: Milan Zamazal \nSigned-off-by: Bryan O'Donoghue \n---\n src/libcamera/shaders/bayer_1x_packed.frag | 3 +++\n src/libcamera/shaders/bayer_unpacked.frag | 3 +++\n 2 files changed, 6 insertions(+)","diff":"diff --git a/src/libcamera/shaders/bayer_1x_packed.frag b/src/libcamera/shaders/bayer_1x_packed.frag\nindex db8c2a0b3..7036fe278 100644\n--- a/src/libcamera/shaders/bayer_1x_packed.frag\n+++ b/src/libcamera/shaders/bayer_1x_packed.frag\n@@ -66,6 +66,7 @@ uniform vec2 tex_bayer_first_red;\n \n uniform sampler2D tex_y;\n uniform mat3 ccm;\n+uniform vec3 blacklevel;\n \n void main(void)\n {\n@@ -213,6 +214,8 @@ void main(void)\n \t\t\tvec3(patterns.y, C, patterns.x) :\n \t\t\tvec3(patterns.wz, C));\n \n+\trgb = rgb - blacklevel;\n+\n \t/*\n \t * CCM is a 3x3 in the format\n \t *\ndiff --git a/src/libcamera/shaders/bayer_unpacked.frag b/src/libcamera/shaders/bayer_unpacked.frag\nindex 06d80f3dd..f0d8cd1e2 100644\n--- a/src/libcamera/shaders/bayer_unpacked.frag\n+++ b/src/libcamera/shaders/bayer_unpacked.frag\n@@ -25,6 +25,7 @@ varying vec4 center;\n varying vec4 yCoord;\n varying vec4 xCoord;\n uniform mat3 ccm;\n+uniform vec3 blacklevel;\n \n void main(void) {\n vec3 rgb;\n@@ -108,6 +109,8 @@ void main(void) {\n vec3(PATTERN.w, C, PATTERN.z) :\n vec3(PATTERN.yx, C));\n \n+ rgb = rgb - blacklevel;\n+\n /*\n * CCM is a 3x3 in the format\n *\n","prefixes":["v9","08/26"]}