{"id":25553,"url":"https://patchwork.libcamera.org/api/1.1/patches/25553/?format=json","web_url":"https://patchwork.libcamera.org/patch/25553/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20251214181646.573675-6-rui.wang@ideasonboard.com>","date":"2025-12-14T18:16:45","name":"[v5,5/6] ipa: rkisp1: algorithms: dpf: Add detailed config logging","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"e8c1cdbc8763fe5ba42073013df61e76f745b28e","submitter":{"id":241,"url":"https://patchwork.libcamera.org/api/1.1/people/241/?format=json","name":"Rui Wang","email":"rui.wang@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/25553/mbox/","series":[{"id":5660,"url":"https://patchwork.libcamera.org/api/1.1/series/5660/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5660","date":"2025-12-14T18:16:40","name":"refactor DPF parsing and initialization","version":5,"mbox":"https://patchwork.libcamera.org/series/5660/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/25553/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/25553/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id DE35AC3257\n\tfor ;\n\tSun, 14 Dec 2025 18:17:19 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8F80561958;\n\tSun, 14 Dec 2025 19:17:19 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 18F7D61950\n\tfor ;\n\tSun, 14 Dec 2025 19:17:18 +0100 (CET)","from rui-Precision-7560.local (unknown [209.216.103.65])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 8133455A;\n\tSun, 14 Dec 2025 19:17:13 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"BSPmGpHh\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1765736233;\n\tbh=1RTDCGDamw35PEZimgQBrU7HsGLi8g0OGodDM1peVQg=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=BSPmGpHhUjXjqh6Z2YP1gNiyFfzc2wBCpjOubZKPrinVNBYa6bJhltoW70ZK6+a1L\n\tHfPB8bZ648ZoLayzNj6XTgp8aLDKh1FPaEYptScSgTbPENWyvTamdOuseji2Dl4tQF\n\t9PQyH9JCnd+B/9zpIOfMvMdh4YqjBup/T6Ekr4tI=","From":"Rui Wang ","To":"libcamera-devel@lists.libcamera.org","Cc":"Rui Wang ","Subject":"[PATCH v5 5/6] ipa: rkisp1: algorithms: dpf: Add detailed config\n\tlogging","Date":"Sun, 14 Dec 2025 13:16:45 -0500","Message-ID":"<20251214181646.573675-6-rui.wang@ideasonboard.com>","X-Mailer":"git-send-email 2.43.0","In-Reply-To":"<20251214181646.573675-1-rui.wang@ideasonboard.com>","References":"<20251214181646.573675-1-rui.wang@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Add logConfig() helper function to log DPF configuration\nupdates when they occur. This provides visibility into the active\nDPF parameters including:\n\n- Control mode and denoise enable state\n- Filter sizes (9x9 vs 13x9 for rb)\n- NLL scale mode (linear vs logarithmic)\n- Gain mode\n- Strength values (r, g, b)\n- Spatial filter coefficients (g and rb arrays)\n- Noise level lookup table coefficients\n\nThe logging is triggered in prepareEnabledMode() whenever the\nconfiguration is updated, helping with debugging and tuning.\n\nSigned-off-by: Rui Wang \n---\n\nchangelog :\n\n- Renamed logConfigIfChanged to logConfig and updated implementation: \n Moved the update check (if (update)) from inner to outer\n\n src/ipa/rkisp1/algorithms/dpf.cpp | 47 +++++++++++++++++++++++++++++++\n src/ipa/rkisp1/algorithms/dpf.h | 1 +\n 2 files changed, 48 insertions(+)","diff":"diff --git a/src/ipa/rkisp1/algorithms/dpf.cpp b/src/ipa/rkisp1/algorithms/dpf.cpp\nindex 4818ef28..4342e580 100644\n--- a/src/ipa/rkisp1/algorithms/dpf.cpp\n+++ b/src/ipa/rkisp1/algorithms/dpf.cpp\n@@ -271,6 +271,50 @@ bool Dpf::loadReductionConfig(int32_t mode)\n \treturn true;\n }\n \n+void Dpf::logConfig(const IPAFrameContext &frameContext)\n+{\n+\tstd::ostringstream ss;\n+\n+\tss << \"DPF config update: \";\n+\tss << \" control mode=\" << kModesMap.at(runningMode_);\n+\tss << \", denoise=\" << (frameContext.dpf.denoise ? \"enabled\" : \"disabled\");\n+\n+\tss << \", rb_fltsize=\"\n+\t << (config_.rb_flt.fltsize == RKISP1_CIF_ISP_DPF_RB_FILTERSIZE_13x9 ? \"13x9\" : \"9x9\");\n+\tss << \", nll_scale=\"\n+\t << (config_.nll.scale_mode == RKISP1_CIF_ISP_NLL_SCALE_LOGARITHMIC ? \"log\" : \"linear\");\n+\tss << \", gain_mode=\" << config_.gain.mode;\n+\tss << \", strength=\" << int(strengthConfig_.r) << ',' << int(strengthConfig_.g) << ',' << int(strengthConfig_.b);\n+\n+\tss << \", g=[\";\n+\tfor (size_t i = 0; i < RKISP1_CIF_ISP_DPF_MAX_SPATIAL_COEFFS; ++i) {\n+\t\tif (i) {\n+\t\t\tss << ',';\n+\t\t}\n+\t\tss << int(config_.g_flt.spatial_coeff[i]);\n+\t}\n+\tss << \"]\";\n+\n+\tss << \", rb=[\";\n+\tfor (size_t i = 0; i < RKISP1_CIF_ISP_DPF_MAX_SPATIAL_COEFFS; ++i) {\n+\t\tif (i) {\n+\t\t\tss << ',';\n+\t\t}\n+\t\tss << int(config_.rb_flt.spatial_coeff[i]);\n+\t}\n+\tss << \"]\";\n+\n+\tss << \", nll=[\";\n+\tfor (size_t i = 0; i < RKISP1_CIF_ISP_DPF_MAX_NLF_COEFFS; ++i) {\n+\t\tif (i) {\n+\t\t\tss << ',';\n+\t\t}\n+\t\tss << int(config_.nll.coeff[i]);\n+\t}\n+\tss << \"]\";\n+\tLOG(RkISP1Dpf, Debug) << ss.str();\n+}\n+\n /**\n * \\copydoc libcamera::ipa::Algorithm::queueRequest\n */\n@@ -379,6 +423,9 @@ void Dpf::prepareEnabledMode(IPAContext &context, [[maybe_unused]] const uint32_\n \tauto strengthConfig = params->block();\n \tstrengthConfig.setEnabled(true);\n \t*strengthConfig = strengthConfig_;\n+\n+\tif (frameContext.dpf.update)\n+\t\tlogConfig(frameContext);\n }\n \n REGISTER_IPA_ALGORITHM(Dpf, \"Dpf\")\ndiff --git a/src/ipa/rkisp1/algorithms/dpf.h b/src/ipa/rkisp1/algorithms/dpf.h\nindex fcf121cb..1821da39 100644\n--- a/src/ipa/rkisp1/algorithms/dpf.h\n+++ b/src/ipa/rkisp1/algorithms/dpf.h\n@@ -43,6 +43,7 @@ private:\n \t\t\t rkisp1_cif_isp_dpf_strength_config &strengthConfig);\n \n \tbool loadReductionConfig(int32_t mode);\n+\tvoid logConfig(const IPAFrameContext &frameContext);\n \n \tvoid prepareDisabledMode(IPAContext &context, const uint32_t frame,\n \t\t\t\t IPAFrameContext &frameContext,\n","prefixes":["v5","5/6"]}