{"id":25510,"url":"https://patchwork.libcamera.org/api/1.1/patches/25510/?format=json","web_url":"https://patchwork.libcamera.org/patch/25510/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20251211232246.31330-17-bryan.odonoghue@linaro.org>","date":"2025-12-11T23:22:41","name":"[v5,16/20] libcamera: software_isp: debayer: Make the debayer_ object of type class Debayer not DebayerCpu","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"00cb24c2259f1fa42548d27252359da091be1156","submitter":{"id":175,"url":"https://patchwork.libcamera.org/api/1.1/people/175/?format=json","name":"Bryan O'Donoghue","email":"bryan.odonoghue@linaro.org"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/25510/mbox/","series":[{"id":5656,"url":"https://patchwork.libcamera.org/api/1.1/series/5656/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5656","date":"2025-12-11T23:22:25","name":"GPUISP precursor series","version":5,"mbox":"https://patchwork.libcamera.org/series/5656/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/25510/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/25510/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 35B9AC3257\n\tfor ;\n\tThu, 11 Dec 2025 23:24:07 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id EDD5A61667;\n\tFri, 12 Dec 2025 00:24:06 +0100 (CET)","from mail-pf1-x430.google.com (mail-pf1-x430.google.com\n\t[IPv6:2607:f8b0:4864:20::430])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 84A7761623\n\tfor ;\n\tFri, 12 Dec 2025 00:24:05 +0100 (CET)","by mail-pf1-x430.google.com with SMTP id\n\td2e1a72fcca58-7bab7c997eeso761970b3a.0\n\tfor ;\n\tThu, 11 Dec 2025 15:24:05 -0800 (PST)","from inspiron14p-linux (M106185144161.v4.enabler.ne.jp.\n\t[106.185.144.161]) by smtp.gmail.com with ESMTPSA id\n\td2e1a72fcca58-7f4c4ab52aasm3399933b3a.38.2025.12.11.15.24.00\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tThu, 11 Dec 2025 15:24:03 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"c+4/aKfw\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=linaro.org; s=google; t=1765495444; x=1766100244;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=+PkMvzCnM9G5wbdm2DgdHRiNaN/qiCPxWjNd922vzx0=;\n\tb=c+4/aKfwKrQM95lt53CoN3/b3+6OLtnQvyxdTi/oMiawFt1pdeIgdCLOs8qTZgW8Uh\n\tbSQJSqeFltQLa64osxe8b46vilBMkreNhS6mgy2Wk1wBRLNvsRel+tq4YvBwUxQQY8ML\n\tn/lpWcxHCuTnvai3wkjQ8dRdSZGy8Xniq6kP5nC9n4wmQINiKH5RMGAATw6c8ZyJivbW\n\tfu4pWbV4ygTI1wno4yZWad1nO8IVz/mZkmfUWgGrY+PLiDc1KRXhf90wZcSb5GbasKSZ\n\td2yqDktDNpGozIsfTPoUBC7hKIEQn+acD4GZ3fiAzBcls/VuNknr6vuwEzS0i5ULn3C2\n\tHo9w==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1765495444; x=1766100244;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n\t:to:cc:subject:date:message-id:reply-to;\n\tbh=+PkMvzCnM9G5wbdm2DgdHRiNaN/qiCPxWjNd922vzx0=;\n\tb=o7Rbglaa9GmhaauETrFoE/+0VSF9pBDpF2T+IpDIlcvJPNVfYCN3LFzwJWCK5vW2vg\n\tyL6ofHMQEB4+U8Dcj1bjJBX+CBrVGIjmrlpEuMM+oIJbLwiSSFBOqwZWioQyoQD+gLW4\n\tqurmN1HNPnVBsZZGDwcIkEyQdE/D3OJw5NoM9fHfHQXsFiqzu8MqmhxbZ2DR8Zv3QZ11\n\tkPAGs23SvkDijuupT0iHbf34uRGz/buCIzMsymvNvnrVbCcQ9U/RRv56x+xsx2auXWM4\n\tR/YAhtGOm84cRpfTlz1LrI7IxWXYna6xNVlL0SVS7ltnxIGfFY//or4WU73DRGN8Azfj\n\tkt7g==","X-Gm-Message-State":"AOJu0YyzyNtQQISgnEmfz04I2S89ebhqKruD5vjNeD/bUQvHgg0Jq/Xy\n\trNMwBhQmfKerI54J3iaH1mWjVijvyX+HM2dXHQ2jRVCv0jCCpCzHsSXbeXBxkQrIF9IGGVkjIL3\n\tcNitY","X-Gm-Gg":"AY/fxX7Xd1MZE0axF++oo70rRuPKQ6kU8DBrai4zyuiOsajX7pAUn9J74TMx8uJb99I\n\tVJ6ln4UZzxmLbCULg4Y0PDPoYrsGZUCj+PNVZ1+CCZaV5YkFXsAxjfQ80gcG7MFt4GPJ9lI0GIK\n\tZnRWQ1XBPl42NOFGdS56GVzfZUhRUulua923/2L12P7haPh9h4ynbTDIu8hAhGKary5j8g4Sus2\n\tqguSEYGMJpqcnd5/TisT1zJjjHt2Hk8jR4fVptEUDUB4Sp4VfOsQl6NjN7ZfbziFlf4g0IoYFvd\n\tKuktN2eiiVq1+s5HL8Gq6pEood/e1WSsBfBP7k9QIh5luqByUnV4ryGslIAy2JoP/mKZfrCwKuV\n\t85WtkCLz/zY7w2UJ7RuM2jAlenP0FfFK1jZFt4K2gH2eHM2HOBnW6aRObUiUvQls8mbfHtZXp7U\n\tyFeh+p9zzj3vhKThYKCJ26j9TPjO9jdtO6VBt8wHnpyc1N14iNyAlT0x+ZxM+Byw==","X-Google-Smtp-Source":"AGHT+IER8oGAiRxKjIB+zvgd3sYh4rV/lz7tmlNDxB2LkBQFQQQF6epwLuP5xbRlhYWZz9H7Kn+dBA==","X-Received":"by 2002:a05:6a00:300d:b0:7e8:4471:ae74 with SMTP id\n\td2e1a72fcca58-7f669e80288mr174678b3a.64.1765495443835; \n\tThu, 11 Dec 2025 15:24:03 -0800 (PST)","From":"Bryan O'Donoghue ","To":"libcamera-devel@lists.libcamera.org","Cc":"pavel@ucw.cz, Bryan O'Donoghue ,\n\tKieran Bingham ,\n\tMilan Zamazal ","Subject":"[PATCH v5 16/20] libcamera: software_isp: debayer: Make the debayer_\n\tobject of type class Debayer not DebayerCpu","Date":"Thu, 11 Dec 2025 23:22:41 +0000","Message-ID":"<20251211232246.31330-17-bryan.odonoghue@linaro.org>","X-Mailer":"git-send-email 2.52.0","In-Reply-To":"<20251211232246.31330-1-bryan.odonoghue@linaro.org>","References":"<20251211232246.31330-1-bryan.odonoghue@linaro.org>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Make the type of object Debayer not DebayerCpu thus allowing us to assign\nthe object to either DebayerCpu or DebayerEGL.\n\nReviewed-by: Kieran Bingham \nReviewed-by: Milan Zamazal \nSigned-off-by: Bryan O'Donoghue \n---\n include/libcamera/internal/software_isp/software_isp.h | 5 ++---\n src/libcamera/software_isp/software_isp.cpp | 6 +++---\n 2 files changed, 5 insertions(+), 6 deletions(-)","diff":"diff --git a/include/libcamera/internal/software_isp/software_isp.h b/include/libcamera/internal/software_isp/software_isp.h\nindex 786246592..ad89c9b3c 100644\n--- a/include/libcamera/internal/software_isp/software_isp.h\n+++ b/include/libcamera/internal/software_isp/software_isp.h\n@@ -37,7 +37,7 @@\n \n namespace libcamera {\n \n-class DebayerCpu;\n+class Debayer;\n class FrameBuffer;\n class PixelFormat;\n class Stream;\n@@ -94,8 +94,7 @@ private:\n \tvoid statsReady(uint32_t frame, uint32_t bufferId);\n \tvoid inputReady(FrameBuffer *input);\n \tvoid outputReady(FrameBuffer *output);\n-\n-\tstd::unique_ptr debayer_;\n+\tstd::unique_ptr debayer_;\n \tThread ispWorkerThread_;\n \tSharedMemObject sharedParams_;\n \tDebayerParams debayerParams_;\ndiff --git a/src/libcamera/software_isp/software_isp.cpp b/src/libcamera/software_isp/software_isp.cpp\nindex 7c9ad9160..b31a374d8 100644\n--- a/src/libcamera/software_isp/software_isp.cpp\n+++ b/src/libcamera/software_isp/software_isp.cpp\n@@ -348,7 +348,7 @@ int SoftwareIsp::start()\n \n \tispWorkerThread_.start();\n \n-\treturn debayer_->invokeMethod(&DebayerCpu::start,\n+\treturn debayer_->invokeMethod(&Debayer::start,\n \t\t\t\t ConnectionTypeBlocking);\n }\n \n@@ -360,7 +360,7 @@ int SoftwareIsp::start()\n */\n void SoftwareIsp::stop()\n {\n-\tdebayer_->invokeMethod(&DebayerCpu::stop,\n+\tdebayer_->invokeMethod(&Debayer::stop,\n \t\t\t ConnectionTypeBlocking);\n \n \tispWorkerThread_.exit();\n@@ -394,7 +394,7 @@ void SoftwareIsp::stop()\n void SoftwareIsp::process(uint32_t frame, FrameBuffer *input, FrameBuffer *output)\n {\n \tipa_->computeParams(frame);\n-\tdebayer_->invokeMethod(&DebayerCpu::process,\n+\tdebayer_->invokeMethod(&Debayer::process,\n \t\t\t ConnectionTypeQueued, frame, input, output, debayerParams_);\n }\n \n","prefixes":["v5","16/20"]}