{"id":25382,"url":"https://patchwork.libcamera.org/api/1.1/patches/25382/?format=json","web_url":"https://patchwork.libcamera.org/patch/25382/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20251208004808.1274417-5-rui.wang@ideasonboard.com>","date":"2025-12-08T00:48:05","name":"[v4,4/7] ipa: rkisp1: algorithms: dpf: Simplify YAML key names","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"0f16b1ca30c2fba8b92ddf7c4886955eafb4a1c3","submitter":{"id":241,"url":"https://patchwork.libcamera.org/api/1.1/people/241/?format=json","name":"Rui Wang","email":"rui.wang@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/25382/mbox/","series":[{"id":5641,"url":"https://patchwork.libcamera.org/api/1.1/series/5641/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5641","date":"2025-12-08T00:48:01","name":"rebase_dpf_refactory_patch_v4","version":4,"mbox":"https://patchwork.libcamera.org/series/5641/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/25382/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/25382/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 23FEBC3257\n\tfor ;\n\tMon, 8 Dec 2025 00:48:49 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id DB0E3613EB;\n\tMon, 8 Dec 2025 01:48:48 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 053C9613F6\n\tfor ;\n\tMon, 8 Dec 2025 01:48:46 +0100 (CET)","from localhost.localdomain (unknown [209.216.103.65])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id BA6EE1E29;\n\tMon, 8 Dec 2025 01:46:27 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"XfT+zQ8K\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1765154788;\n\tbh=6a2CTYcYxffrUGgL2egvtIROzXsSsMuDi55nPXccj0Y=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=XfT+zQ8KAbvAsI8Y4MOkc/5SezGrUZrbFl8iwoy0wZCjh86HomHCc+73Pa1Tw70gZ\n\tLkJaPwZ3MxB65cnTlu+g2lSkbWzsWnt2dv9ObdRMCuh4a9CsWw2nfmzpZ1ni7wU2JN\n\tqwAdLvuAy+769mZKUmc6n4xZmEQRKyueqejWTLxE=","From":"Rui Wang ","To":"libcamera-devel@lists.libcamera.org","Cc":"Rui Wang ","Subject":"[PATCH v4 4/7] ipa: rkisp1: algorithms: dpf: Simplify YAML key names","Date":"Sun, 7 Dec 2025 19:48:05 -0500","Message-ID":"<20251208004808.1274417-5-rui.wang@ideasonboard.com>","X-Mailer":"git-send-email 2.43.0","In-Reply-To":"<20251208004808.1274417-1-rui.wang@ideasonboard.com>","References":"<20251208004808.1274417-1-rui.wang@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Rename DPF tuning file keys to shorter, more concise names:\n- DomainFilter -> filter\n- NoiseLevelFunction -> nll\n- FilterStrength -> strength\n\nThis improves readability and reduces verbosity in tuning files\nwhile maintaining the same functionality. Error messages are\nupdated accordingly to reflect the new key names.\n\nSigned-off-by: Rui Wang \n---\nchangelog:\n - Move V3's Yaml rename Implementation into one sperate patch for highlight\n\n src/ipa/rkisp1/algorithms/dpf.cpp | 14 +++++++-------\n 1 file changed, 7 insertions(+), 7 deletions(-)","diff":"diff --git a/src/ipa/rkisp1/algorithms/dpf.cpp b/src/ipa/rkisp1/algorithms/dpf.cpp\nindex edb4c2bf..dea04cc3 100644\n--- a/src/ipa/rkisp1/algorithms/dpf.cpp\n+++ b/src/ipa/rkisp1/algorithms/dpf.cpp\n@@ -123,7 +123,7 @@ bool Dpf::parseSingleConfig(const YamlObject &tuningData,\n \t * The domain kernel is configured with a 9x9 kernel for the green\n \t * pixels, and a 13x9 or 9x9 kernel for red and blue pixels.\n \t */\n-\tconst YamlObject &dFObject = tuningData[\"DomainFilter\"];\n+\tconst YamlObject &dFObject = tuningData[\"filter\"];\n \n \t/*\n \t * For the green component, we have the 9x9 kernel specified\n@@ -145,7 +145,7 @@ bool Dpf::parseSingleConfig(const YamlObject &tuningData,\n \tvalues = dFObject[\"g\"].getList().value_or(std::vector{});\n \tif (values.size() != RKISP1_CIF_ISP_DPF_MAX_SPATIAL_COEFFS) {\n \t\tLOG(RkISP1Dpf, Error)\n-\t\t\t<< \"Invalid 'DomainFilter:g': expected \"\n+\t\t\t<< \"Invalid 'filter:g': expected \"\n \t\t\t<< RKISP1_CIF_ISP_DPF_MAX_SPATIAL_COEFFS\n \t\t\t<< \" elements, got \" << values.size();\n \t\treturn false;\n@@ -182,7 +182,7 @@ bool Dpf::parseSingleConfig(const YamlObject &tuningData,\n \tif (values.size() != RKISP1_CIF_ISP_DPF_MAX_SPATIAL_COEFFS &&\n \t values.size() != RKISP1_CIF_ISP_DPF_MAX_SPATIAL_COEFFS - 1) {\n \t\tLOG(RkISP1Dpf, Error)\n-\t\t\t<< \"Invalid 'DomainFilter:rb': expected \"\n+\t\t\t<< \"Invalid 'filter:rb': expected \"\n \t\t\t<< RKISP1_CIF_ISP_DPF_MAX_SPATIAL_COEFFS - 1\n \t\t\t<< \" or \" << RKISP1_CIF_ISP_DPF_MAX_SPATIAL_COEFFS\n \t\t\t<< \" elements, got \" << values.size();\n@@ -204,13 +204,13 @@ bool Dpf::parseSingleConfig(const YamlObject &tuningData,\n \t * which stores a piecewise linear function that characterizes the\n \t * sensor noise profile as a noise level function curve (NLF).\n \t */\n-\tconst YamlObject &rFObject = tuningData[\"NoiseLevelFunction\"];\n+\tconst YamlObject &rFObject = tuningData[\"nll\"];\n \n \tstd::vector nllValues;\n \tnllValues = rFObject[\"coeff\"].getList().value_or(std::vector{});\n \tif (nllValues.size() != RKISP1_CIF_ISP_DPF_MAX_NLF_COEFFS) {\n \t\tLOG(RkISP1Dpf, Error)\n-\t\t\t<< \"Invalid 'RangeFilter:coeff': expected \"\n+\t\t\t<< \"Invalid 'nll:coeff': expected \"\n \t\t\t<< RKISP1_CIF_ISP_DPF_MAX_NLF_COEFFS\n \t\t\t<< \" elements, got \" << nllValues.size();\n \t\treturn false;\n@@ -226,13 +226,13 @@ bool Dpf::parseSingleConfig(const YamlObject &tuningData,\n \t\tconfig.nll.scale_mode = RKISP1_CIF_ISP_NLL_SCALE_LOGARITHMIC;\n \t} else {\n \t\tLOG(RkISP1Dpf, Error)\n-\t\t\t<< \"Invalid 'RangeFilter:scale-mode': expected \"\n+\t\t\t<< \"Invalid 'nll:scale-mode': expected \"\n \t\t\t<< \"'linear' or 'logarithmic' value, got \"\n \t\t\t<< scaleMode;\n \t\treturn false;\n \t}\n \n-\tconst YamlObject &fSObject = tuningData[\"FilterStrength\"];\n+\tconst YamlObject &fSObject = tuningData[\"strength\"];\n \n \tstrengthConfig.r = fSObject[\"r\"].get().value_or(64);\n \tstrengthConfig.g = fSObject[\"g\"].get().value_or(64);\n","prefixes":["v4","4/7"]}