{"id":25376,"url":"https://patchwork.libcamera.org/api/1.1/patches/25376/?format=json","web_url":"https://patchwork.libcamera.org/patch/25376/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20251205-mali-cru-v1-6-d81bb5ffe73a@ideasonboard.com>","date":"2025-12-05T14:52:12","name":"[6/7] libcamera: mali-c55: Fix sensor size computation","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"6c316a80ebcbf0901c3362311a408f227862c38e","submitter":{"id":143,"url":"https://patchwork.libcamera.org/api/1.1/people/143/?format=json","name":"Jacopo Mondi","email":"jacopo.mondi@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/25376/mbox/","series":[{"id":5640,"url":"https://patchwork.libcamera.org/api/1.1/series/5640/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5640","date":"2025-12-05T14:52:06","name":"libcamera: mali-c55: Add support for memory-to-memory","version":1,"mbox":"https://patchwork.libcamera.org/series/5640/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/25376/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/25376/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 5F6B0C32DE\n\tfor ;\n\tFri, 5 Dec 2025 14:52:41 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2766161400;\n\tFri, 5 Dec 2025 15:52:38 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D6853613A4\n\tfor ;\n\tFri, 5 Dec 2025 15:52:31 +0100 (CET)","from [192.168.1.4] (net-93-65-100-155.cust.vodafonedsl.it\n\t[93.65.100.155])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id A7FCC558;\n\tFri, 5 Dec 2025 15:50:15 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"umLkbG4T\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1764946215;\n\tbh=GaTpeR6Ev0sWnhJLRy/0ww3MNJ37XvE6rxX0o9HyIOY=;\n\th=From:Date:Subject:References:In-Reply-To:To:Cc:From;\n\tb=umLkbG4TfEBJrxfYQUKMB9alVYJ2M8CWGpMJ6yT99ZVSndj+SJ7NIni5KxS/HxRY2\n\t/Jpg1n+cITViSTH9otNViBOmOlzsvtxMtSJs3yNJHylr2duvxiQhWc+cvfONsBMh+b\n\tyXr1aWhX5DhEiZUjwgmkKwnM8Luq0W6geTnxi2J4=","From":"Jacopo Mondi ","Date":"Fri, 05 Dec 2025 15:52:12 +0100","Subject":"[PATCH 6/7] libcamera: mali-c55: Fix sensor size computation","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"7bit","Message-Id":"<20251205-mali-cru-v1-6-d81bb5ffe73a@ideasonboard.com>","References":"<20251205-mali-cru-v1-0-d81bb5ffe73a@ideasonboard.com>","In-Reply-To":"<20251205-mali-cru-v1-0-d81bb5ffe73a@ideasonboard.com>","To":"Daniel Scally , \n\tlibcamera-devel@lists.libcamera.org","Cc":"Jacopo Mondi ","X-Mailer":"b4 0.14.2","X-Developer-Signature":"v=1; a=openpgp-sha256; l=1004;\n\ti=jacopo.mondi@ideasonboard.com; h=from:subject:message-id;\n\tbh=GaTpeR6Ev0sWnhJLRy/0ww3MNJ37XvE6rxX0o9HyIOY=;\n\tb=owEBbQKS/ZANAwAKAXI0Bo8WoVY8AcsmYgBpMvGt5rPmI8V3p0XhUrTKGPuJQkvN4bnBZg4GL\n\t3mfcAN7jHKJAjMEAAEKAB0WIQS1xD1IgJogio9YOMByNAaPFqFWPAUCaTLxrQAKCRByNAaPFqFW\n\tPMNfEACMvcrhN0shAlAfxJ1CXvPVvW15Y2sfxOS7BOJjlzPWo1xDVgMhBYscO/Rtwwh2NkAHEsd\n\txY6Z80Lfct0qCpMMfwqy+zl2o06AjpWnvKeNopXoaJi8iNEr+x7vgZ1Fgmh1evjyKIm6gpCrqab\n\t09YcJdJbBnFQzwVuHmj62CktTKQS3dojqn3xjyBX41mEkInCCnGde9ejDEtGT3VoYAokubAFdPM\n\tEmJ1/cEjtE8Xtbrqx9ohTo1YWj4OPj3jRK6v3UhYTMPhAtIZ2sUt5CbZbefXKci8iVJ0F/qFSL/\n\t04zRQ/h/x9N/TUc2EEGPDqAjnQUL8qi4HMATtAtzGMXooptIi8zRUW+RxCkPD3e8Ib9QIhc6+sb\n\tMKrnozVGsGGbuo18RROVD3iy0ijPVkrfgt5BxkfGf5NsabVmqP55OcQ9lqx3vPRdRj+BSGwgopL\n\t0HEr6thEUN+ugMLYV1uCx5mjPmoh5dckF8u+1mf93utknmixIaNaMQdbV4UsrXJW4u0IxorC0Af\n\t/Qqtfs7hBeVzQNEOwiJ4uSwbMzCotlV933BbzO0agdBBdYf04gNY/mIuBEIM0Ihc1bgy4Xt2Dft\n\tix867cmGGck54KRxR9MzlvGtqg1nASvxhoqPElZkv8nQ50LHxMdr8PQI3h9mkhMA3B9D8oGBdnF\n\tvVn9Q1oZlkXQ2nA==","X-Developer-Key":"i=jacopo.mondi@ideasonboard.com; a=openpgp;\n\tfpr=72392EDC88144A65C701EA9BA5826A2587AD026B","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The sensor size computation routine doesn't work well. Even if a\nmore appriate size for a sensor is available, the largest one is\nalways selected.\n\nFix the size computation procedure which has an inverted assignment.\n\nSigned-off-by: Jacopo Mondi \n---\n src/libcamera/pipeline/mali-c55/mali-c55.cpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)","diff":"diff --git a/src/libcamera/pipeline/mali-c55/mali-c55.cpp b/src/libcamera/pipeline/mali-c55/mali-c55.cpp\nindex 46ef5e7735a30a0d4ae9bb6f8d671bbd2dff3f51..a0a880f26281e5cd9ec176153970a2dd1d230496 100644\n--- a/src/libcamera/pipeline/mali-c55/mali-c55.cpp\n+++ b/src/libcamera/pipeline/mali-c55/mali-c55.cpp\n@@ -666,7 +666,7 @@ CameraConfiguration::Status MaliC55CameraConfiguration::validate()\n \t\t\t\tstd::abs(static_cast(minSensorSize.height) -\n \t\t\t\t\t static_cast(size.height));\n \t\tif (dist < distance) {\n-\t\t\tdist = distance;\n+\t\t\tdistance = dist;\n \t\t\tbestSize = size;\n \t\t}\n \t}\n","prefixes":["6/7"]}