{"id":25326,"url":"https://patchwork.libcamera.org/api/1.1/patches/25326/?format=json","web_url":"https://patchwork.libcamera.org/patch/25326/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20251202134544.662446-18-bryan.odonoghue@linaro.org>","date":"2025-12-02T13:45:37","name":"[v6,17/24] ipa: Add a new Algorithm::init() to support self-initalising algorithms","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"4b2aa67f0f47febb4837278cc2ddf6b434724493","submitter":{"id":175,"url":"https://patchwork.libcamera.org/api/1.1/people/175/?format=json","name":"Bryan O'Donoghue","email":"bryan.odonoghue@linaro.org"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/25326/mbox/","series":[{"id":5631,"url":"https://patchwork.libcamera.org/api/1.1/series/5631/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5631","date":"2025-12-02T13:45:20","name":"Add GLES 2.0 GPUISP to libcamera","version":6,"mbox":"https://patchwork.libcamera.org/series/5631/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/25326/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/25326/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 56419C32F6\n\tfor ;\n\tTue, 2 Dec 2025 13:46:26 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2ADAA60F3A;\n\tTue, 2 Dec 2025 14:46:25 +0100 (CET)","from mail-wm1-x32c.google.com (mail-wm1-x32c.google.com\n\t[IPv6:2a00:1450:4864:20::32c])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B443160E3E\n\tfor ;\n\tTue, 2 Dec 2025 14:46:17 +0100 (CET)","by mail-wm1-x32c.google.com with SMTP id\n\t5b1f17b1804b1-477b198f4bcso40709035e9.3\n\tfor ;\n\tTue, 02 Dec 2025 05:46:17 -0800 (PST)","from inspiron14p-linux.ht.home (188-141-3-146.dynamic.upc.ie.\n\t[188.141.3.146]) by smtp.gmail.com with ESMTPSA id\n\t5b1f17b1804b1-47926f0ec69sm19383375e9.1.2025.12.02.05.46.16\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tTue, 02 Dec 2025 05:46:16 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"i6K9mtxT\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=linaro.org; s=google; t=1764683177; x=1765287977;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=Cd4Lu/rRh8VWoA0Rmsx0kqTDJoCB3bfU/VXyPDYvPPU=;\n\tb=i6K9mtxTyiewTnoSFnfb2tF2i3y8H2nRhIFf67Wtw4eiAUvfg7pXOiHgmoY9JSghBC\n\tXM0onFF6jG3ThltSwZP2Rb8jYpN8CmmovshfJ/2ojezOHtii4voA8T8MCxEiv8OJthEW\n\tCzVpDHRSHwTIp4eeNsRIO/lTg2pCiEYuBfOE33Uu2sQIzzunC6y9bWsvZVZ7pM6Hxax8\n\tJvdQtg41GF8V9Do67FP8tckNFcGmhCRlJd7lHWfHA+7BJa9Eap/VgSk1ENk/68MI/45h\n\tQK6EMxh+SWQuKPhBnTD2iMaUpokWkZ4Emk4x1CUt/E5766kDjR8E9d0cihUiJXTT5H0m\n\tV/Pg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1764683177; x=1765287977;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n\t:to:cc:subject:date:message-id:reply-to;\n\tbh=Cd4Lu/rRh8VWoA0Rmsx0kqTDJoCB3bfU/VXyPDYvPPU=;\n\tb=tFhRLwXiQM5gsgr89vDAxaTb79umS3WugdBU1QxlLsYfmL2lemGzyM6olEJCMHBzc7\n\t/DlmEPKYT8feDNUwx8GndesLl0PSrnUBVY6Nh7hSmXEZ4ewGFWqPxSpPaUWCVwKip2xT\n\tXKXCyK310VEKnctBp2Q+BKIu3OWG2meCN4tvcgG3+AlE9BGQ/+GAE7RqxIUb83uGq+xJ\n\tr67uzsar4UnBikHnHKRdCo6qfN28F99vqC/w/pkn23c4t9Zm2qQMcnuL9fZRW5EHo/1J\n\tJxw6J9zVUs/GiEvExtfX4ySwfQCpN/x6CIBXuU7OWuMXQoNHrf6WUNOm/urLpwcwD23D\n\tqLyQ==","X-Gm-Message-State":"AOJu0YxzOfcNj04+80lo1HPopn84Sr9wye8wnk5q4tvA28j7mtW4tkZI\n\txPRv859nr9VhWPkwo6d8n5LI+TTkrWnlJM9sBKUmUI+DcQE7sfFuiJJNd3izoYGtGvAiD5Tz3kG\n\tKWbtF","X-Gm-Gg":"ASbGncu/C1+vmIKjW+6EvFYZt61BjgdoIpL7LaG6fq2zk7qHe17Gtd0hW6SE32+sC1k\n\tQ9Av8BmbGWeS4149b4eaSo8XNpJQm9S8jy6o2NhMvYAXnZdt1YhxS9Vr5PDVuk5NLZztwozRxZf\n\tMhLQ7JfjfqFw8v/prE0F9JE9eHwgYpbJN/yLNSa/pLh0mlSK6xipIC0g+60mVvVNMrgFWfckpJq\n\tJyzPFMHvFjopnmtkm9ixr5JyEPVDsPdWVhgy4BNP6aBz/IFpKVeDQ8O/1W3AsO6k3RxDVpxqgu6\n\tcm1Nu4IoIb0TFYBKSH/KaUTFN3Iiw5M0jTFJzaY+Y3jOF2lQlO5m/PtJkyy+AFd7N/dMWSPazfV\n\tNQvwenq2+fGkZExGqWcTnOgIjwXBkNPBp5yXy8OKhVmndluwSI5sAPxJir1DLAnHov6abnztwp4\n\tbiuwSjNBtslZV8JiBEmm/AdTBmyda1dMmpW8FtljWpryRNqgcydmWqPyfuZNYSBJZa4qM=","X-Google-Smtp-Source":"AGHT+IFbTH/idGfHRNb1xaMvM0Pjd32yq6G5UtU19LwiV0W/63ilRELll6aD4JFxt0V01+BVBF+86Q==","X-Received":"by 2002:a05:600c:4e8e:b0:477:9f34:17b8 with SMTP id\n\t5b1f17b1804b1-477c0165bf3mr408139665e9.1.1764683177017; \n\tTue, 02 Dec 2025 05:46:17 -0800 (PST)","From":"Bryan O'Donoghue ","To":"libcamera-devel@lists.libcamera.org","Cc":"pavel@ucw.cz,\n\tBryan O'Donoghue ","Subject":"[PATCH v6 17/24] ipa: Add a new Algorithm::init() to support\n\tself-initalising algorithms","Date":"Tue, 2 Dec 2025 13:45:37 +0000","Message-ID":"<20251202134544.662446-18-bryan.odonoghue@linaro.org>","X-Mailer":"git-send-email 2.52.0","In-Reply-To":"<20251202134544.662446-1-bryan.odonoghue@linaro.org>","References":"<20251202134544.662446-1-bryan.odonoghue@linaro.org>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Add in an algorithm init() routine which can be called in the absence of a\nYaml input. Do this to allow an algorithm to set up a default set of\nparameters.\n\nSigned-off-by: Bryan O'Donoghue \n---\n src/ipa/libipa/algorithm.cpp | 13 ++++++++++++-\n src/ipa/libipa/algorithm.h | 5 +++++\n 2 files changed, 17 insertions(+), 1 deletion(-)","diff":"diff --git a/src/ipa/libipa/algorithm.cpp b/src/ipa/libipa/algorithm.cpp\nindex 201efdfdb..da44c77ca 100644\n--- a/src/ipa/libipa/algorithm.cpp\n+++ b/src/ipa/libipa/algorithm.cpp\n@@ -38,7 +38,7 @@ namespace ipa {\n */\n \n /**\n- * \\fn Algorithm::init()\n+ * \\fn Algorithm::init(typename Module::Context &context, const YamlObject &tuningData)\n * \\brief Initialize the Algorithm with tuning data\n * \\param[in] context The shared IPA context\n * \\param[in] tuningData The tuning data for the algorithm\n@@ -50,6 +50,17 @@ namespace ipa {\n * \\return 0 if successful, an error code otherwise\n */\n \n+/**\n+ * \\fn Algorithm::init(typename Module::Context &context)\n+ * \\brief Initialize the algorithm with default parameters\n+ *\n+ * This method is called when no tuning data is available. The algorithm\n+ * should initialize with sensible default values.\n+ *\n+ * \\param context The IPA context containing algorithm state\n+ * \\return 0 on success, negative error code on failure\n+ */\n+\n /**\n * \\fn Algorithm::configure()\n * \\brief Configure the Algorithm given an IPAConfigInfo\ndiff --git a/src/ipa/libipa/algorithm.h b/src/ipa/libipa/algorithm.h\nindex 9a19dbd61..9fcbe23a9 100644\n--- a/src/ipa/libipa/algorithm.h\n+++ b/src/ipa/libipa/algorithm.h\n@@ -32,6 +32,11 @@ public:\n \t\treturn 0;\n \t}\n \n+\tvirtual int init([[maybe_unused]] typename Module::Context &context)\n+\t{\n+\t\treturn 0;\n+\t}\n+\n \tvirtual int configure([[maybe_unused]] typename Module::Context &context,\n \t\t\t [[maybe_unused]] const typename Module::Config &configInfo)\n \t{\n","prefixes":["v6","17/24"]}