{"id":25318,"url":"https://patchwork.libcamera.org/api/1.1/patches/25318/?format=json","web_url":"https://patchwork.libcamera.org/patch/25318/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20251202134544.662446-10-bryan.odonoghue@linaro.org>","date":"2025-12-02T13:45:29","name":"[v6,09/24] libcamera: shaders: Add support for Gamma","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"3b84f0f5b603856659bfecac8e4eaaab2a6d7aa8","submitter":{"id":175,"url":"https://patchwork.libcamera.org/api/1.1/people/175/?format=json","name":"Bryan O'Donoghue","email":"bryan.odonoghue@linaro.org"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/25318/mbox/","series":[{"id":5631,"url":"https://patchwork.libcamera.org/api/1.1/series/5631/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5631","date":"2025-12-02T13:45:20","name":"Add GLES 2.0 GPUISP to libcamera","version":6,"mbox":"https://patchwork.libcamera.org/series/5631/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/25318/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/25318/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C0884C32EA\n\tfor ;\n\tTue, 2 Dec 2025 13:46:13 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 42EA860D36;\n\tTue, 2 Dec 2025 14:46:13 +0100 (CET)","from mail-wm1-x332.google.com (mail-wm1-x332.google.com\n\t[IPv6:2a00:1450:4864:20::332])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2C60D60D22\n\tfor ;\n\tTue, 2 Dec 2025 14:46:06 +0100 (CET)","by mail-wm1-x332.google.com with SMTP id\n\t5b1f17b1804b1-477632b0621so34570105e9.2\n\tfor ;\n\tTue, 02 Dec 2025 05:46:06 -0800 (PST)","from inspiron14p-linux.ht.home (188-141-3-146.dynamic.upc.ie.\n\t[188.141.3.146]) by smtp.gmail.com with ESMTPSA id\n\t5b1f17b1804b1-47926f0ec69sm19383375e9.1.2025.12.02.05.46.04\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tTue, 02 Dec 2025 05:46:04 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"Dlw2tWJG\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=linaro.org; s=google; t=1764683165; x=1765287965;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=20MMXTnFm6SHHWDjaqh8aMbgaaC551tC4RzFJEsLOHE=;\n\tb=Dlw2tWJGShfvohzQBYBoyrKvcKs2TZBmoMydxdQYHWFsGQNZmCDwSPT8wLICmOIB/0\n\tBbgGlNAPXSsAqJWwWWBIvfop/Yu7VGZBDi4tx+HsM7iDAQGptCbkKD02HOU8wLqVY7+f\n\tUHoPJyojEPdFO3jUfTp+KlioxwVsfhmybHMw5jpE/P8geV4qE3nTTJR3ZrPSnsQ6tqug\n\t3nCunlBwWnnmU7KPYH7amlVaw1jPJFYtrn4zYw6FQeUNxqwPEQ1s6L3Se9zG2nz4i98+\n\t2GXiIP3RbbRN5TfCWz82vvcLLAelaFyTQ74wNGv6DMD7qRew+nap9poSByCXgiZAFJB8\n\tLcGQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1764683165; x=1765287965;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n\t:to:cc:subject:date:message-id:reply-to;\n\tbh=20MMXTnFm6SHHWDjaqh8aMbgaaC551tC4RzFJEsLOHE=;\n\tb=ST1PrtvROM38bKu/aQ9BciHjmWIsYnmBlch5/cGiFaOs7ef150GV6OHhlmkPf2NQ9V\n\tMyghuCLTriyWQTJgWwdZutd0zwRKXimA4k7h9nyZKHLwIPEa+sva4If/wRPwKwZsblKk\n\tM1R0hixSIoYF/k7bgeTsJbb3R2Uoy1TdP+UVGbVuFGjBSK+l+1j5o9y2E++8rXqmDr3Q\n\tCC0jlRueGiSRZ9/2U7E2yBpnrcLYQRA6hzMgUsRg6VCsVwD4Zm8BzH46cgX3147uI3Ld\n\tC0qOp/QEY/+BvGHkvVnvxm/5DP5FJaqTNdBXfAoMY3PVrYDdldOVJOf4yk4Wb/A8M3KG\n\tZYSw==","X-Gm-Message-State":"AOJu0Yzn4qcGAj4U8lqoFGTiwNokSqvxDAS3DkwnUoC1QwjQH/U35sKs\n\tgK+jyCYpJzAS+3JuDCgy7L/+am13AHgHr2bhZG5B3BJA1JZ2kZQoSz7F5IW2Uk1IcPY46nDLfnN\n\tlrtj+","X-Gm-Gg":"ASbGncuklPwLeFpVhQ7HGlw+d3+z1He39A2GwbnhAM4o0mVC/iB3OZF8yTTXD+2hPjA\n\tM9O8a2e//Wk+4H4nhonwdwJaeh0D+63k1Q7u7COItuEjbT5O9vhsNjF6CKbG2mY26lTVWORfo0+\n\tr+7D+6ALh5RuWtbIbPk6O74BKGbzD85I+0b9URAXd6/oiaSJi73OX6DMMFiSsWCGYNl8l34vCNx\n\tgErbJiYfgtTFGI1xRBgc5W9uH8tKl2ftWaRYq8GsYIIO7p18DhobjPjR3nCScx+Ud+V+JC1/1ht\n\twbIoC9ZJhj9ttyLa3PIrQes/iHukGp2loE1SX+IkkpNuyX8lmvDAkCo9WLrW2B6kamnjbbycJQr\n\tgBhN1KcDrlqR9P2tmafUF+E7miZHjoZvKacn+1hRLTZlX+tjUz1xPaY+zkn9f3hogrpZZMhOC+K\n\tliKn2IIknvGfnkya6JTlFDBCFKgICHL7cusY5adWA7GCryDPO1iF7JWnDvNuaRiHxqayY=","X-Google-Smtp-Source":"AGHT+IE7R4Mk2WORyE6WCzL0gC4n4l6u7b5fRXJ7te7IFUqRB8+Dn/Azkx6S6/7ZWc4qF7pS8z7Wwg==","X-Received":"by 2002:a05:600c:46cd:b0:475:dc5c:3a89 with SMTP id\n\t5b1f17b1804b1-477c1136b7fmr414976585e9.34.1764683165396; \n\tTue, 02 Dec 2025 05:46:05 -0800 (PST)","From":"Bryan O'Donoghue ","To":"libcamera-devel@lists.libcamera.org","Cc":"pavel@ucw.cz, Bryan O'Donoghue ,\n\tMilan Zamazal ","Subject":"[PATCH v6 09/24] libcamera: shaders: Add support for Gamma","Date":"Tue, 2 Dec 2025 13:45:29 +0000","Message-ID":"<20251202134544.662446-10-bryan.odonoghue@linaro.org>","X-Mailer":"git-send-email 2.52.0","In-Reply-To":"<20251202134544.662446-1-bryan.odonoghue@linaro.org>","References":"<20251202134544.662446-1-bryan.odonoghue@linaro.org>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Add gamma compentation to the debayer shaders after colour correction is\napplied.\n\nSimilarly only apply the calculated Gamma curve when using the CCM as the\nlookup tables already contain the data.\n\nSuggested-by: Milan Zamazal \nSigned-off-by: Bryan O'Donoghue \n---\n src/libcamera/shaders/bayer_1x_packed.frag | 4 ++++\n src/libcamera/shaders/bayer_unpacked.frag | 4 ++++\n 2 files changed, 8 insertions(+)","diff":"diff --git a/src/libcamera/shaders/bayer_1x_packed.frag b/src/libcamera/shaders/bayer_1x_packed.frag\nindex 7036fe278..77d9fbfa7 100644\n--- a/src/libcamera/shaders/bayer_1x_packed.frag\n+++ b/src/libcamera/shaders/bayer_1x_packed.frag\n@@ -67,6 +67,7 @@ uniform vec2 tex_bayer_first_red;\n uniform sampler2D tex_y;\n uniform mat3 ccm;\n uniform vec3 blacklevel;\n+uniform float gamma;\n \n void main(void)\n {\n@@ -260,6 +261,9 @@ void main(void)\n \trgb.g = (rin * ccm[1][0]) + (gin * ccm[1][1]) + (bin * ccm[1][2]);\n \trgb.b = (rin * ccm[2][0]) + (gin * ccm[2][1]) + (bin * ccm[2][2]);\n \n+\t/* Apply gamma after colour correction */\n+\trgb = pow(rgb, vec3(gamma));\n+\n #if defined (SWAP_BLUE)\n \tgl_FragColor = vec4(rgb.bgr, 1.0);\n #else\ndiff --git a/src/libcamera/shaders/bayer_unpacked.frag b/src/libcamera/shaders/bayer_unpacked.frag\nindex f0d8cd1e2..aba11a87f 100644\n--- a/src/libcamera/shaders/bayer_unpacked.frag\n+++ b/src/libcamera/shaders/bayer_unpacked.frag\n@@ -26,6 +26,7 @@ varying vec4 yCoord;\n varying vec4 xCoord;\n uniform mat3 ccm;\n uniform vec3 blacklevel;\n+uniform float gamma;\n \n void main(void) {\n vec3 rgb;\n@@ -155,6 +156,9 @@ void main(void) {\n rgb.g = (rin * ccm[1][0]) + (gin * ccm[1][1]) + (bin * ccm[1][2]);\n rgb.b = (rin * ccm[2][0]) + (gin * ccm[2][1]) + (bin * ccm[2][2]);\n \n+ /* Apply gamma after colour correction */\n+ rgb = pow(rgb, vec3(gamma));\n+\n #if defined (SWAP_BLUE)\n gl_FragColor = vec4(rgb.bgr, 1.0);\n #else\n","prefixes":["v6","09/24"]}