{"id":25316,"url":"https://patchwork.libcamera.org/api/1.1/patches/25316/?format=json","web_url":"https://patchwork.libcamera.org/patch/25316/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20251202134544.662446-8-bryan.odonoghue@linaro.org>","date":"2025-12-02T13:45:27","name":"[v6,07/24] libcamera: shaders: Extend bayer shaders to support swapping R and B on output","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"c8fe7f0d90359367374670fccaad26c63fe1bcac","submitter":{"id":175,"url":"https://patchwork.libcamera.org/api/1.1/people/175/?format=json","name":"Bryan O'Donoghue","email":"bryan.odonoghue@linaro.org"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/25316/mbox/","series":[{"id":5631,"url":"https://patchwork.libcamera.org/api/1.1/series/5631/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5631","date":"2025-12-02T13:45:20","name":"Add GLES 2.0 GPUISP to libcamera","version":6,"mbox":"https://patchwork.libcamera.org/series/5631/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/25316/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/25316/checks/","tags":{},"headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id BAD79C32E7\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue,  2 Dec 2025 13:46:08 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 6362060D12;\n\tTue,  2 Dec 2025 14:46:07 +0100 (CET)","from mail-wm1-x32c.google.com (mail-wm1-x32c.google.com\n\t[IPv6:2a00:1450:4864:20::32c])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6DDD760C88\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue,  2 Dec 2025 14:46:03 +0100 (CET)","by mail-wm1-x32c.google.com with SMTP id\n\t5b1f17b1804b1-4779cb0a33fso57907485e9.0\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 02 Dec 2025 05:46:03 -0800 (PST)","from inspiron14p-linux.ht.home (188-141-3-146.dynamic.upc.ie.\n\t[188.141.3.146]) by smtp.gmail.com with ESMTPSA id\n\t5b1f17b1804b1-47926f0ec69sm19383375e9.1.2025.12.02.05.46.00\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tTue, 02 Dec 2025 05:46:01 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"Yf4UHbLA\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=linaro.org; s=google; t=1764683163; x=1765287963;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=nAlpCB4iJopL0Pn768w20N/UlmcrQmnghUNHBy8yJOY=;\n\tb=Yf4UHbLAzRl0+cXHae4TGW+DoXiRVno/Gci1f0JCMkfGm4VWF+d9FYQ4UnylRgE3eK\n\tNMAZYTTOmF8ao/WHnU+UUOtxZzzkDvZxA4fi2uxbjqJ3cgXC/5FGo0x4YPx05N31BLqu\n\tU3/QcC3bEbjxQTG5jZ9JTEiK+CnlPIqDJM5rXGPCdk9uemarXwecDFhvS1g4Zc0q2JhB\n\tPHjcLyCNVn8+XKaGOI9c5tnzj3N+m9mBOjuv+Z/UttPt9Y1oy7N7JaEJvpxlq7f7SQD1\n\tZts9f5Z7Wj2cu0OXXZQGmC6p3nwfVAXxVedLpKARYlJnB/NKlZc4uunkQf2mmt9bnnDL\n\twiLw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1764683163; x=1765287963;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n\t:to:cc:subject:date:message-id:reply-to;\n\tbh=nAlpCB4iJopL0Pn768w20N/UlmcrQmnghUNHBy8yJOY=;\n\tb=l0ApkMqWyMDp+MZOuLlAfJtO0/DbhtlcNmzsrz2/Kv8zkVZn65Mlw63UCZPzvmEsLZ\n\tD/Bl7EZr31zo2H9DyiZxQD1PVENFzpNefzTCwAkfJT82GpnoE2zeZuJwfkGDjYDpVR/+\n\tzewT4zhgsTcIVjptMCET6OM+eqbFL5YSkPrKKL5RToV2zpiQ06LP04CuOGezffwz/cdA\n\t87i7YASeuQ/7gznGTFl4/5MMj7BKrFWKGaKxlXx779yTXcaWkdDfrHl3Bj2CaEXPz/eF\n\thozAKGar556WrPzS5RVbtfLCXEqbawuPIjkw5jilonkU7DVXfwcP8ypwm3zOUSwCREFH\n\toPkA==","X-Gm-Message-State":"AOJu0YwOWSIOuIrrZ2qHbsMHWkv2qkwaReGCBsfb2XEWpOJoPDVeKw4l\n\tfnxaiRaKPZ3uHQuBSDgPiaZ/kAbvU8J+9NysieOHtNcYmD3OfJLniRlgnOoWRWuKdmpmPpPmPjr\n\teU4js","X-Gm-Gg":"ASbGncs00pMBJCJAUphEkT0c8IfmF81QBa1RYNHUDG3AuXZ9v2TC/ort1y7Oa1jpyLF\n\trWphDOsAcbE3o5rbAdWKE9LLDDRiiPNWF3FyX2muVYymHM6TbTOc9CbHFIcah/6aeQ9Z4kQMeNr\n\ttqBcsdDe3Z4aM3xp7/rmIXHwg9Nbgxj4a/spf27HIBdKlA4DXxKoLI2F74HNb/kzatj0qy1p259\n\tHaBtzZKLuTx2fVUsjBEUF3ea1pnJtxVbhbYGeVQmO9kzpiLujc+9HMnCvj/VphiiQUb7e/z5Rmo\n\tcRDsy0K3YTR/r8IR1ZLT0u9Yv0OjMjKX6f0MBku3zH8wbHMS2zOTVgkJ9XzJX3xYM94owfzu7vH\n\tuZ+lW/fXwrRlmAJbhIXzkbbWk4V+SmI3Lt3Es5UF2Eg2pS5XEaDfckJrGNM8AICX60biQUm2hqh\n\tC8EfSQyim/TsD8FNUHvMBivjKXQ7Ca+4kQeKz7MAND4qxFgdWq0Atm5pPkw/zIpzXACXA=","X-Google-Smtp-Source":"AGHT+IFa03vzASFOeV3tkYwOCHMw8tgEJ5PO5wg+99OqFUMyin7qdWS3VHfWaCM9WZslKvcaaksONw==","X-Received":"by 2002:a05:600c:470d:b0:471:1717:411 with SMTP id\n\t5b1f17b1804b1-477c01edab1mr514226995e9.24.1764683162615; \n\tTue, 02 Dec 2025 05:46:02 -0800 (PST)","From":"Bryan O'Donoghue <bryan.odonoghue@linaro.org>","To":"libcamera-devel@lists.libcamera.org","Cc":"pavel@ucw.cz, Bryan O'Donoghue <bryan.odonoghue@linaro.org>,\n\tMilan Zamazal <mzamazal@redhat.com>,\n\tKieran Bingham <kieran.bingham@ideasonboard.com>","Subject":"[PATCH v6 07/24] libcamera: shaders: Extend bayer shaders to support\n\tswapping R and B on output","Date":"Tue,  2 Dec 2025 13:45:27 +0000","Message-ID":"<20251202134544.662446-8-bryan.odonoghue@linaro.org>","X-Mailer":"git-send-email 2.52.0","In-Reply-To":"<20251202134544.662446-1-bryan.odonoghue@linaro.org>","References":"<20251202134544.662446-1-bryan.odonoghue@linaro.org>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"},"content":"We can easily facilitate swapping R and B on output. Pivot on an\nenvironment define for this purpose.\n\nReviewed-by: Milan Zamazal <mzamazal@redhat.com>\nAcked-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\nSigned-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>\n---\n src/libcamera/shaders/bayer_1x_packed.frag | 4 ++++\n src/libcamera/shaders/bayer_unpacked.frag  | 6 +++++-\n 2 files changed, 9 insertions(+), 1 deletion(-)","diff":"diff --git a/src/libcamera/shaders/bayer_1x_packed.frag b/src/libcamera/shaders/bayer_1x_packed.frag\nindex 171a928c2..db8c2a0b3 100644\n--- a/src/libcamera/shaders/bayer_1x_packed.frag\n+++ b/src/libcamera/shaders/bayer_1x_packed.frag\n@@ -257,5 +257,9 @@ void main(void)\n \trgb.g = (rin * ccm[1][0]) + (gin * ccm[1][1]) + (bin * ccm[1][2]);\n \trgb.b = (rin * ccm[2][0]) + (gin * ccm[2][1]) + (bin * ccm[2][2]);\n \n+#if defined (SWAP_BLUE)\n+\tgl_FragColor = vec4(rgb.bgr, 1.0);\n+#else\n \tgl_FragColor = vec4(rgb, 1.0);\n+#endif\n }\ndiff --git a/src/libcamera/shaders/bayer_unpacked.frag b/src/libcamera/shaders/bayer_unpacked.frag\nindex c41d72f4f..06d80f3dd 100644\n--- a/src/libcamera/shaders/bayer_unpacked.frag\n+++ b/src/libcamera/shaders/bayer_unpacked.frag\n@@ -152,5 +152,9 @@ void main(void) {\n     rgb.g = (rin * ccm[1][0]) + (gin * ccm[1][1]) + (bin * ccm[1][2]);\n     rgb.b = (rin * ccm[2][0]) + (gin * ccm[2][1]) + (bin * ccm[2][2]);\n \n-    gl_FragColor.rgb = rgb;\n+#if defined (SWAP_BLUE)\n+    gl_FragColor = vec4(rgb.bgr, 1.0);\n+#else\n+    gl_FragColor = vec4(rgb, 1.0);\n+#endif\n }\n","prefixes":["v6","07/24"]}