{"id":25313,"url":"https://patchwork.libcamera.org/api/1.1/patches/25313/?format=json","web_url":"https://patchwork.libcamera.org/patch/25313/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20251202134544.662446-5-bryan.odonoghue@linaro.org>","date":"2025-12-02T13:45:24","name":"[v6,04/24] libcamera: shaders: Rename bayer_8 to bayer_unpacked","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"35a6d78fdb97510d821282384ecb89af3e2b1926","submitter":{"id":175,"url":"https://patchwork.libcamera.org/api/1.1/people/175/?format=json","name":"Bryan O'Donoghue","email":"bryan.odonoghue@linaro.org"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/25313/mbox/","series":[{"id":5631,"url":"https://patchwork.libcamera.org/api/1.1/series/5631/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5631","date":"2025-12-02T13:45:20","name":"Add GLES 2.0 GPUISP to libcamera","version":6,"mbox":"https://patchwork.libcamera.org/series/5631/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/25313/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/25313/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 24586C32AF\n\tfor ;\n\tTue, 2 Dec 2025 13:46:02 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id AF92B60D0C;\n\tTue, 2 Dec 2025 14:46:01 +0100 (CET)","from mail-wm1-x335.google.com (mail-wm1-x335.google.com\n\t[IPv6:2a00:1450:4864:20::335])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5490260C77\n\tfor ;\n\tTue, 2 Dec 2025 14:45:58 +0100 (CET)","by mail-wm1-x335.google.com with SMTP id\n\t5b1f17b1804b1-4775e891b5eso23291605e9.2\n\tfor ;\n\tTue, 02 Dec 2025 05:45:58 -0800 (PST)","from inspiron14p-linux.ht.home (188-141-3-146.dynamic.upc.ie.\n\t[188.141.3.146]) by smtp.gmail.com with ESMTPSA id\n\t5b1f17b1804b1-47926f0ec69sm19383375e9.1.2025.12.02.05.45.56\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tTue, 02 Dec 2025 05:45:56 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"mNCmal8f\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=linaro.org; s=google; t=1764683158; x=1765287958;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=lV+JLx0+P4aigKpifcEHa5VvxL7Qodjjb3+3JXtFVoo=;\n\tb=mNCmal8fhLkDwziuGOZsSVCGbohKLLmKxY3MUBR1Il81FR4DYM78+dfeM9DOurVwM4\n\ta7bNeOXtzeghcF6RbYJP+XVISgsZ08zFxPqSckFZ4MNtbSuq58PJkOO/3MrDpKUKcCPT\n\tPKeR2OJagSBLUShgvANFRroKGVg/OKElW0Cs8WW90khLitixAPMN0ths+ehrbUmDAexS\n\tDxoLXvUGf//o6YzHOwmR5MODstevwzeGZ01WY+78I+vTOmuGgbWP1OltJEa+Ag9JrYQM\n\tDoxBLL7y1MBwlNqv6KcrxTFXXuttdw2mbfMJw2e99I2A/CACWGABMJgveBCamDq+50SO\n\t4MKg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1764683158; x=1765287958;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n\t:to:cc:subject:date:message-id:reply-to;\n\tbh=lV+JLx0+P4aigKpifcEHa5VvxL7Qodjjb3+3JXtFVoo=;\n\tb=LhjTzlueXSO3vu6MDiJh+KpUgPmniU7Yo9ttU7ERfyIt7Vm1eyGWj8vZ6vIqfX+Edf\n\tBCpWbihlDM3ElI66MUDt2RNo2e9MLVPd06ObnX/pyLdzBAKCQv5MqwduC4rLCN9aKijX\n\tz11UjwMh5RJubuTgylSC6HAacpPOF6b5G1b8VPl4eIDcTRUSRX4vWEq+P/806x94OHUo\n\tcpKv22r1+2QA+XXo6hYvnxkL1KXprCSBwl0Ri/TYM2OtrYXsiXXFL5TE5kotf7YIEfMo\n\tkHW0KdfOVMsH311OhWHRxdwFm7Wf1cjXpGWEEmugZFcjWEmej7jgJed1bTBC1CvznnTA\n\tlr6Q==","X-Gm-Message-State":"AOJu0YyyuRjb1t7lSWLMvokGj8S/NL+DMGxUZMCcimz8WG1qlJNSRtei\n\twrNvhNd/2k1CMdfr+5JONFygu+QvSB7H/WqM3c+cOCpTA1LgtuZJtaAEXWzqZFluUCFr+xvc0Lo\n\t2awgd","X-Gm-Gg":"ASbGnctIso3mI81p+OQ2yCtPWaj6/dHKpG/lshs8Y2szefB2x+ua6KPOXl8s2SYa1sx\n\tlVMyE/9EtyCgplCGnsg1q23x7Cp88tlSDbdAwVoMwwr+Y2CFaD+cF5a2KODc0xUtv8mQflNaLeH\n\tMh1gBbbM4Z655PpHz+ByRWz6HgHTaqS3Jgp4pZra2G7sDKP5uxvn+Nbw2XOwHxvztzz3iBMmeII\n\tKacx606e1F3m38cb64+PY3ZJd4f4Pquz5oOE13evT0WNErTIsSfhNIgZaSHFaq2Ufm1E//auHs8\n\tDhQ9APKzx/TFdVePik71r/kVr6kcFNu9ks4iMQ+pw+Kha3B5LUg1AbGO7cZDOnib2c2jLOhE56w\n\tqZxVgKnybMMI01zt45mGV12H24ORgQe77mS3lSgPQw6eCIzycuEZRGFKD8pLe14xQ4UApxCdTNg\n\t/dsoDvWTK8fDx4It45DtCYbMyxrLhKGg5TkLWuVC+kIOQ0ukHwX2Ef7HPYeo307XS8Y28=","X-Google-Smtp-Source":"AGHT+IHxkjtXhWVmVNDuHeY9tIV/UvNU0R57KLBDKaCdjqkF78LijCT/ZUqhd+4JYxEr5Og1DoH1pA==","X-Received":"by 2002:a05:600c:3baa:b0:475:de12:d3b5 with SMTP id\n\t5b1f17b1804b1-477c01ecc7cmr430279725e9.34.1764683157465; \n\tTue, 02 Dec 2025 05:45:57 -0800 (PST)","From":"Bryan O'Donoghue ","To":"libcamera-devel@lists.libcamera.org","Cc":"pavel@ucw.cz, Milan Zamazal ,\n\tKieran Bingham ,\n\tBryan O'Donoghue ","Subject":"[PATCH v6 04/24] libcamera: shaders: Rename bayer_8 to\n\tbayer_unpacked","Date":"Tue, 2 Dec 2025 13:45:24 +0000","Message-ID":"<20251202134544.662446-5-bryan.odonoghue@linaro.org>","X-Mailer":"git-send-email 2.52.0","In-Reply-To":"<20251202134544.662446-1-bryan.odonoghue@linaro.org>","References":"<20251202134544.662446-1-bryan.odonoghue@linaro.org>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"From: Milan Zamazal \n\nbayer_8.* shaders are now used for all unpacked sensor data formats,\nregardless of the pixel bit width. Let's rename the \"8-bit\" shaders to\navoid confusion.\n\nSigned-off-by: Milan Zamazal \nReviewed-by: Kieran Bingham \nSigned-off-by: Bryan O'Donoghue \n---\n src/apps/qcam/assets/shader/shaders.qrc | 4 ++--\n src/apps/qcam/viewfinder_gl.cpp | 16 ++++++++--------\n .../{bayer_8.frag => bayer_unpacked.frag} | 0\n .../{bayer_8.vert => bayer_unpacked.vert} | 0\n src/libcamera/shaders/meson.build | 4 ++--\n 5 files changed, 12 insertions(+), 12 deletions(-)\n rename src/libcamera/shaders/{bayer_8.frag => bayer_unpacked.frag} (100%)\n rename src/libcamera/shaders/{bayer_8.vert => bayer_unpacked.vert} (100%)","diff":"diff --git a/src/apps/qcam/assets/shader/shaders.qrc b/src/apps/qcam/assets/shader/shaders.qrc\nindex 7369cdbe8..f11a68ef2 100644\n--- a/src/apps/qcam/assets/shader/shaders.qrc\n+++ b/src/apps/qcam/assets/shader/shaders.qrc\n@@ -6,8 +6,8 @@\n \t../../../../../src/libcamera/shaders/YUV_3_planes.frag\n \t../../../../../src/libcamera/shaders/YUV_packed.frag\n \t../../../../../src/libcamera/shaders/bayer_1x_packed.frag\n-\t../../../../../src/libcamera/shaders/bayer_8.frag\n-\t../../../../../src/libcamera/shaders/bayer_8.vert\n+\t../../../../../src/libcamera/shaders/bayer_unpacked.frag\n+\t../../../../../src/libcamera/shaders/bayer_unpacked.vert\n \t../../../../../src/libcamera/shaders/identity.vert\n \n \ndiff --git a/src/apps/qcam/viewfinder_gl.cpp b/src/apps/qcam/viewfinder_gl.cpp\nindex 69b7c6e59..ea957dc65 100644\n--- a/src/apps/qcam/viewfinder_gl.cpp\n+++ b/src/apps/qcam/viewfinder_gl.cpp\n@@ -235,29 +235,29 @@ bool ViewFinderGL::selectFormat(const libcamera::PixelFormat &format)\n \tcase libcamera::formats::SBGGR8:\n \t\tfirstRed_.setX(1.0);\n \t\tfirstRed_.setY(1.0);\n-\t\tvertexShaderFile_ = \":src/libcamera/shaders/bayer_8.vert\";\n-\t\tfragmentShaderFile_ = \":src/libcamera/shaders/bayer_8.frag\";\n+\t\tvertexShaderFile_ = \":src/libcamera/shaders/bayer_unpacked.vert\";\n+\t\tfragmentShaderFile_ = \":src/libcamera/shaders/bayer_unpacked.frag\";\n \t\ttextureMinMagFilters_ = GL_NEAREST;\n \t\tbreak;\n \tcase libcamera::formats::SGBRG8:\n \t\tfirstRed_.setX(0.0);\n \t\tfirstRed_.setY(1.0);\n-\t\tvertexShaderFile_ = \":src/libcamera/shaders/bayer_8.vert\";\n-\t\tfragmentShaderFile_ = \":src/libcamera/shaders/bayer_8.frag\";\n+\t\tvertexShaderFile_ = \":src/libcamera/shaders/bayer_unpacked.vert\";\n+\t\tfragmentShaderFile_ = \":src/libcamera/shaders/bayer_unpacked.frag\";\n \t\ttextureMinMagFilters_ = GL_NEAREST;\n \t\tbreak;\n \tcase libcamera::formats::SGRBG8:\n \t\tfirstRed_.setX(1.0);\n \t\tfirstRed_.setY(0.0);\n-\t\tvertexShaderFile_ = \":src/libcamera/shaders/bayer_8.vert\";\n-\t\tfragmentShaderFile_ = \":src/libcamera/shaders/bayer_8.frag\";\n+\t\tvertexShaderFile_ = \":src/libcamera/shaders/bayer_unpacked.vert\";\n+\t\tfragmentShaderFile_ = \":src/libcamera/shaders/bayer_unpacked.frag\";\n \t\ttextureMinMagFilters_ = GL_NEAREST;\n \t\tbreak;\n \tcase libcamera::formats::SRGGB8:\n \t\tfirstRed_.setX(0.0);\n \t\tfirstRed_.setY(0.0);\n-\t\tvertexShaderFile_ = \":src/libcamera/shaders/bayer_8.vert\";\n-\t\tfragmentShaderFile_ = \":src/libcamera/shaders/bayer_8.frag\";\n+\t\tvertexShaderFile_ = \":src/libcamera/shaders/bayer_unpacked.vert\";\n+\t\tfragmentShaderFile_ = \":src/libcamera/shaders/bayer_unpacked.frag\";\n \t\ttextureMinMagFilters_ = GL_NEAREST;\n \t\tbreak;\n \tcase libcamera::formats::SBGGR10_CSI2P:\ndiff --git a/src/libcamera/shaders/bayer_8.frag b/src/libcamera/shaders/bayer_unpacked.frag\nsimilarity index 100%\nrename from src/libcamera/shaders/bayer_8.frag\nrename to src/libcamera/shaders/bayer_unpacked.frag\ndiff --git a/src/libcamera/shaders/bayer_8.vert b/src/libcamera/shaders/bayer_unpacked.vert\nsimilarity index 100%\nrename from src/libcamera/shaders/bayer_8.vert\nrename to src/libcamera/shaders/bayer_unpacked.vert\ndiff --git a/src/libcamera/shaders/meson.build b/src/libcamera/shaders/meson.build\nindex 386b342d0..dd441a577 100644\n--- a/src/libcamera/shaders/meson.build\n+++ b/src/libcamera/shaders/meson.build\n@@ -4,7 +4,7 @@\n # for the purposes of inclusion in OpenGL debayering\n shader_files = files([\n 'bayer_1x_packed.frag',\n- 'bayer_8.frag',\n- 'bayer_8.vert',\n+ 'bayer_unpacked.frag',\n+ 'bayer_unpacked.vert',\n 'identity.vert',\n ])\n","prefixes":["v6","04/24"]}