{"id":2531,"url":"https://patchwork.libcamera.org/api/1.1/patches/2531/?format=json","web_url":"https://patchwork.libcamera.org/patch/2531/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20200108101725.6404-4-jacopo@jmondi.org>","date":"2020-01-08T10:17:25","name":"[libcamera-devel,v2,3/3] v4l2: camera_proxy: Align trace message style","commit_ref":"a5862a7a3423fbde7b7beaa8b65c8204fcca7785","pull_url":null,"state":"accepted","archived":false,"hash":"03f48ca88695e081be4d017f006d3fdb78100fb4","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/1.1/people/3/?format=json","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/2531/mbox/","series":[{"id":609,"url":"https://patchwork.libcamera.org/api/1.1/series/609/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=609","date":"2020-01-08T10:17:22","name":"v4l2: minor fixes","version":2,"mbox":"https://patchwork.libcamera.org/series/609/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/2531/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/2531/checks/","tags":{},"headers":{"Return-Path":"","Received":["from relay11.mail.gandi.net (relay11.mail.gandi.net\n\t[217.70.178.231])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D234B60668\n\tfor ;\n\tWed, 8 Jan 2020 11:15:08 +0100 (CET)","from uno.lan (93-34-114-233.ip49.fastwebnet.it [93.34.114.233])\n\t(Authenticated sender: jacopo@jmondi.org)\n\tby relay11.mail.gandi.net (Postfix) with ESMTPSA id 6ED2D10000F;\n\tWed, 8 Jan 2020 10:15:08 +0000 (UTC)"],"From":"Jacopo Mondi ","To":"libcamera-devel@lists.libcamera.org","Date":"Wed, 8 Jan 2020 11:17:25 +0100","Message-Id":"<20200108101725.6404-4-jacopo@jmondi.org>","X-Mailer":"git-send-email 2.24.0","In-Reply-To":"<20200108101725.6404-1-jacopo@jmondi.org>","References":"<20200108101725.6404-1-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v2 3/3] v4l2: camera_proxy: Align trace\n\tmessage style","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Wed, 08 Jan 2020 10:15:09 -0000"},"content":"Most of the ioctl handlers in the V4L2CameraProxy class have an empty\nline between the tracing printouts and the immediately following buffer\ntype validation. Align the two ones where such an empy line is missing\nwith the others.\n\nCosmetic change only.\n\nSigned-off-by: Jacopo Mondi \n---\n src/v4l2/v4l2_camera_proxy.cpp | 2 ++\n 1 file changed, 2 insertions(+)","diff":"diff --git a/src/v4l2/v4l2_camera_proxy.cpp b/src/v4l2/v4l2_camera_proxy.cpp\nindex f3a49fea2a5a..89dd7166ca52 100644\n--- a/src/v4l2/v4l2_camera_proxy.cpp\n+++ b/src/v4l2/v4l2_camera_proxy.cpp\n@@ -292,6 +292,7 @@ int V4L2CameraProxy::vidioc_s_fmt(struct v4l2_format *arg)\n int V4L2CameraProxy::vidioc_try_fmt(struct v4l2_format *arg)\n {\n \tLOG(V4L2Compat, Debug) << \"Servicing vidioc_try_fmt\";\n+\n \tif (!validateBufferType(arg->type))\n \t\treturn -EINVAL;\n \n@@ -321,6 +322,7 @@ int V4L2CameraProxy::vidioc_reqbufs(struct v4l2_requestbuffers *arg)\n \tint ret;\n \n \tLOG(V4L2Compat, Debug) << \"Servicing vidioc_reqbufs\";\n+\n \tif (!validateBufferType(arg->type) ||\n \t !validateMemoryType(arg->memory))\n \t\treturn -EINVAL;\n","prefixes":["libcamera-devel","v2","3/3"]}