{"id":25302,"url":"https://patchwork.libcamera.org/api/1.1/patches/25302/?format=json","web_url":"https://patchwork.libcamera.org/patch/25302/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20251202133157.661407-17-bryan.odonoghue@linaro.org>","date":"2025-12-02T13:31:47","name":"[v3,16/22] libcamera: software_isp: Move configure to worker thread","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"a8239e8e7c8519ba3b4a7e103437608ada46b5b0","submitter":{"id":175,"url":"https://patchwork.libcamera.org/api/1.1/people/175/?format=json","name":"Bryan O'Donoghue","email":"bryan.odonoghue@linaro.org"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/25302/mbox/","series":[{"id":5630,"url":"https://patchwork.libcamera.org/api/1.1/series/5630/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5630","date":"2025-12-02T13:31:31","name":"GPUISP precursor series","version":3,"mbox":"https://patchwork.libcamera.org/series/5630/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/25302/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/25302/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 31FEEC32AF\n\tfor ;\n\tTue, 2 Dec 2025 13:32:32 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B353660D35;\n\tTue, 2 Dec 2025 14:32:31 +0100 (CET)","from mail-wr1-x42b.google.com (mail-wr1-x42b.google.com\n\t[IPv6:2a00:1450:4864:20::42b])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id F1C2460D1B\n\tfor ;\n\tTue, 2 Dec 2025 14:32:19 +0100 (CET)","by mail-wr1-x42b.google.com with SMTP id\n\tffacd0b85a97d-42b38de7940so2703046f8f.3\n\tfor ;\n\tTue, 02 Dec 2025 05:32:19 -0800 (PST)","from inspiron14p-linux.ht.home (188-141-3-146.dynamic.upc.ie.\n\t[188.141.3.146]) by smtp.gmail.com with ESMTPSA id\n\tffacd0b85a97d-42e1c5c30c4sm33363322f8f.9.2025.12.02.05.32.18\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tTue, 02 Dec 2025 05:32:18 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"ci2YkulB\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=linaro.org; s=google; t=1764682339; x=1765287139;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=rr0TUjkFqW0qHaZrb+Vym+rnScQurGqndBbCE4iGO5s=;\n\tb=ci2YkulBzN9vIhIEsnv2rbML8PhYxHfhrr8pw40Bi4CuCsoWJP6qC2hj20BD4mNHL8\n\t85RJd0yanmHcO7CCa4g+H9D42HKVHAXzE/PBnVe8UjvzRGCQo4RbDtwZhdrpIaYAcIWS\n\t24NU9/cbjnqfPFvPUmDEI81e5AypmcYvjOBQ7BHI3baP1Q0aiJoUkZ01uiKEKLtwj7s0\n\tcbbCknO9visVyPrGdu04zeeLRD6+GYHNfjjfvn4bajYzGeJtNaTKhcUOeljPaaY0k8kh\n\tTXFIyJHHzqIazzat7PWqG9138QRRnkh7nB5FdbmpZ386/X+NC+Txv275AN1DlxvpBem2\n\tEfBg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1764682339; x=1765287139;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n\t:to:cc:subject:date:message-id:reply-to;\n\tbh=rr0TUjkFqW0qHaZrb+Vym+rnScQurGqndBbCE4iGO5s=;\n\tb=dSdXOOzY+CXlLi7bJuIPUi2hhFiqDqFysc/EVdxUkMtoTLcCoMppgCTgSHrXjjTQoD\n\tQSQOJNF9Edaj87GdwXDwe8R7pReHv9B3VRFURzm3glFVXKazJiCEWpiaZNTkPBgYx+GH\n\t1eIzkBrwHecJAEz/TufNPVUuZByaH/o6MjvzxYA1P48phRCl1qeHGLfV37PK/8uy/37M\n\tBeeOsXDDj0vr2qD/rbE7gjmWS4gC5BYQq03PIMB+Uq1J0p6zouFHjPHtW46FwVhIL8T0\n\tzvb7lZOiUEM5ourpvXZ/h9RIPhU4P/IQunoGYVGidNl7FduHwu7BTLcSfl9FqMVhH1Mx\n\t1zeQ==","X-Gm-Message-State":"AOJu0YzCOIkBAoOKA/gr2aUeOaf9OTNeR1xHJfUJ/YbInlbmZ+pQ5ocf\n\tFU63eHJrEaLmxstziTXxUG4MYC+jAYAE3A0FL2c5K532cio+JmQV3Bj4kc6gFXNmjifbT7v8GLN\n\tta2GT","X-Gm-Gg":"ASbGncuFZLlXzDC52NnvKs0ofEYcv9jsHdL/SAqNdWhmwukSBlhc4bC0Bo8qAVuj5eI\n\t1b4sUBFqSiSJFAHl6ULiabTAjDrmX2mIYZJZ+hLwcoxglxnGk3BZDgwxmeJOeNca9M1S/odCTT0\n\tE3ssIpmPzMSEDd1emQC8i+RHZ63JVN0hXQ7KKNHJxTyzk4cu6PmjqsRZ2/x6gNllj35ruWRVZY3\n\tdCt/9mC3PmasJjgVEoWAZG4OEGdDpNeULz6IHJU4OxzZ3dOhtlr3AvEtRhliGExAnWrDcHYMDDZ\n\tHeHzY0kCaCgH1qA3yCi6jp+tzhxEzagHgRK+WiD3jhsJ6oqNQt94N2dYJ6v2Pp8K0Akd7S1Tr7k\n\tIGWONpDU8ExxeH9k+xBoK3XCMHGqgOXn7t6M/dLR/iD6GOCbA6NtCaUVam+o86txZrB2uKCD+5L\n\tYMVzELixQUtvf76K0+CcH+wuW17fQ0K7Q8sOgwREDoMbex476DrfLnqmoAKOaDHTAlDT8=","X-Google-Smtp-Source":"AGHT+IEYbJZrVRrMPzmzqBr8eBobKC4vHTuyzddDvZ5zar5ctZQ/3QxY/Q69aAXZxJYNf2DXotoo/Q==","X-Received":"by 2002:a05:6000:4028:b0:429:bc93:9d8a with SMTP id\n\tffacd0b85a97d-42cc1cf3c21mr44488030f8f.37.1764682339176; \n\tTue, 02 Dec 2025 05:32:19 -0800 (PST)","From":"Bryan O'Donoghue ","To":"libcamera-devel@lists.libcamera.org","Cc":"pavel@ucw.cz, Bryan O'Donoghue ,\n\tKieran Bingham ","Subject":"[PATCH v3 16/22] libcamera: software_isp: Move configure to worker\n\tthread","Date":"Tue, 2 Dec 2025 13:31:47 +0000","Message-ID":"<20251202133157.661407-17-bryan.odonoghue@linaro.org>","X-Mailer":"git-send-email 2.52.0","In-Reply-To":"<20251202133157.661407-1-bryan.odonoghue@linaro.org>","References":"<20251202133157.661407-1-bryan.odonoghue@linaro.org>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"EGL requires both configure() and process() to operate on the same\nthread. As preparation for that, move current CPU configure into the\nWorkerThread with a ConnectionTypeBlocking invocation of\n&DebayerCpu::configure.\n\nReviewed-by: Kieran Bingham \nSigned-off-by: Bryan O'Donoghue \n---\n src/libcamera/software_isp/software_isp.cpp | 10 +++++++++-\n 1 file changed, 9 insertions(+), 1 deletion(-)","diff":"diff --git a/src/libcamera/software_isp/software_isp.cpp b/src/libcamera/software_isp/software_isp.cpp\nindex afa4eb7a8..4f6792122 100644\n--- a/src/libcamera/software_isp/software_isp.cpp\n+++ b/src/libcamera/software_isp/software_isp.cpp\n@@ -267,7 +267,15 @@ int SoftwareIsp::configure(const StreamConfiguration &inputCfg,\n \n \tispWorkerThread_.start();\n \n-\treturn debayer_->configure(inputCfg, outputCfgs, ccmEnabled_);\n+\tret = debayer_->invokeMethod(&DebayerCpu::configure,\n+\t\t\t\t ConnectionTypeBlocking, inputCfg,\n+\t\t\t\t outputCfgs, ccmEnabled_);\n+\tif (ret) {\n+\t\tispWorkerThread_.exit();\n+\t\tispWorkerThread_.wait();\n+\t}\n+\n+\treturn ret;\n }\n \n /**\n","prefixes":["v3","16/22"]}