{"id":25278,"url":"https://patchwork.libcamera.org/api/1.1/patches/25278/?format=json","web_url":"https://patchwork.libcamera.org/patch/25278/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20251130012138.2755931-1-rui.wang@ideasonboard.com>","date":"2025-11-30T01:21:38","name":"[v2] media: rkisp1: Fix filter mode handling for sharpness and DNR","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"962b316e4917230298e9e59806fe99faad282a0c","submitter":{"id":241,"url":"https://patchwork.libcamera.org/api/1.1/people/241/?format=json","name":"Rui Wang","email":"rui.wang@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/25278/mbox/","series":[{"id":5623,"url":"https://patchwork.libcamera.org/api/1.1/series/5623/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5623","date":"2025-11-30T01:21:38","name":"[v2] media: rkisp1: Fix filter mode handling for sharpness and DNR","version":2,"mbox":"https://patchwork.libcamera.org/series/5623/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/25278/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/25278/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 392D4C3257\n\tfor ;\n\tSun, 30 Nov 2025 01:21:56 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 6AB5A60A9E;\n\tSun, 30 Nov 2025 02:21:55 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3265A6069A\n\tfor ;\n\tSun, 30 Nov 2025 02:21:54 +0100 (CET)","from rui-Precision-7560.local (unknown [209.216.103.65])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 8F76A42B;\n\tSun, 30 Nov 2025 02:19:41 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"qW4Q22sZ\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1764465581;\n\tbh=tt4xBUdXoms8dNZrZCtA0Lt1uENL/WcUVLOrS4z4TCc=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=qW4Q22sZcEHcrKsI45qoAOhd3iKChl3RLQCqj3IJ2vhCtRjKXLWVXmDnHwepDYDcL\n\tswF0IVdBYoTtWW/r0QCYrtNPV+Ki6gW1bpz+sz8kL7UxFQXJ0AzWSiSecHFb1NCGP1\n\tRfrl+0SV9G4fXR+Z1dZM8tdJn9seLqvh/ntZzkF4=","From":"Rui Wang ","To":"libcamera-devel@lists.libcamera.org","Cc":"Rui Wang ","Subject":"[PATCH v2] media: rkisp1: Fix filter mode handling for sharpness and\n\tDNR","Date":"Sat, 29 Nov 2025 20:21:38 -0500","Message-ID":"<20251130012138.2755931-1-rui.wang@ideasonboard.com>","X-Mailer":"git-send-email 2.43.0","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The filter mode register was not configured correctly during mode\nchanges. When sharpness is enabled, the driver also enables the DNR\nmode, but the default mode value (0x4f2) has bit 0 cleared, which\ndisables the filter module entirely.\n\nAs a result, neither sharpness nor DNR are actually enabled after a\nNoiseReductionMode transition such as OFF → FAST. Additionally, the\nfilter block is not retriggered when switching states.\n\nSigned-off-by: Rui Wang \n\n---\nchangelog : delete bit set for sharpness control from prepare()\n---\n src/ipa/rkisp1/algorithms/filter.cpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)","diff":"diff --git a/src/ipa/rkisp1/algorithms/filter.cpp b/src/ipa/rkisp1/algorithms/filter.cpp\nindex 8ad79801..dfa2b65a 100644\n--- a/src/ipa/rkisp1/algorithms/filter.cpp\n+++ b/src/ipa/rkisp1/algorithms/filter.cpp\n@@ -37,7 +37,7 @@ namespace ipa::rkisp1::algorithms {\n LOG_DEFINE_CATEGORY(RkISP1Filter)\n \n static constexpr uint32_t kFiltLumWeightDefault = 0x00022040;\n-static constexpr uint32_t kFiltModeDefault = 0x000004f2;\n+static constexpr uint32_t kFiltModeDefault = 0x000004f3;\n \n /**\n * \\copydoc libcamera::ipa::Algorithm::init\n","prefixes":["v2"]}