{"id":25266,"url":"https://patchwork.libcamera.org/api/1.1/patches/25266/?format=json","web_url":"https://patchwork.libcamera.org/patch/25266/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20251127211932.122463-2-mzamazal@redhat.com>","date":"2025-11-27T21:19:22","name":"[v16,1/9] libcamera: simple: Exclude raw configurations from output conversions","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"616c72732193c71cff33afebd9240619557dc716","submitter":{"id":177,"url":"https://patchwork.libcamera.org/api/1.1/people/177/?format=json","name":"Milan Zamazal","email":"mzamazal@redhat.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/25266/mbox/","series":[{"id":5619,"url":"https://patchwork.libcamera.org/api/1.1/series/5619/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5619","date":"2025-11-27T21:19:21","name":"Enable raw streams with software ISP","version":16,"mbox":"https://patchwork.libcamera.org/series/5619/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/25266/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/25266/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 27282C32DE\n\tfor ;\n\tThu, 27 Nov 2025 21:19:53 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8D21860AA1;\n\tThu, 27 Nov 2025 22:19:52 +0100 (CET)","from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.133.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 317A0609DE\n\tfor ;\n\tThu, 27 Nov 2025 22:19:51 +0100 (CET)","from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com\n\t(ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63])\n\tby relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n\tcipher=TLS_AES_256_GCM_SHA384) id us-mta-308-0VR6ifEZOR2Ote8_zT7zGQ-1;\n\tThu, 27 Nov 2025 16:19:47 -0500","from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com\n\t(mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com\n\t[10.30.177.12])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\tkey-exchange X25519 server-signature RSA-PSS (2048 bits)\n\tserver-digest SHA256) (No client certificate requested)\n\tby mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTPS id 5271D195608A; Thu, 27 Nov 2025 21:19:45 +0000 (UTC)","from mzamazal-thinkpadp1gen7.tpbc.com (unknown [10.45.224.67])\n\tby mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTP id 2976719560B0; Thu, 27 Nov 2025 21:19:41 +0000 (UTC)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"R39ksAz1\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1764278390;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tcontent-transfer-encoding:content-transfer-encoding:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=m0TWLmMioXl3HUUExaR3N5JO/5+SuggwSZ1P2x+UZPQ=;\n\tb=R39ksAz1Mqvd6gmbatLDK3NbwVzcwBSrU6mjVtdcH4tPCTqBsALAdCVAEPkk9KZD3cc3zg\n\tCYOoUyVUVkTjrfBSq7GpfDapDKrRRNRxCq5hEdPmPsnxTslM0MdrCac8yXOhM+WZm/1Mz9\n\t1HbDIvNwWqv4CqqbF3vYyWcu6o+d6ds=","X-MC-Unique":"0VR6ifEZOR2Ote8_zT7zGQ-1","X-Mimecast-MFC-AGG-ID":"0VR6ifEZOR2Ote8_zT7zGQ_1764278385","From":"Milan Zamazal ","To":"libcamera-devel@lists.libcamera.org","Cc":"Milan Zamazal , Laurent Pinchart\n\t, Kieran Bingham\n\t, =?utf-8?q?Barnab=C3=A1s_P=C5=91cze?=\n\t, Paul Elder\n\t, Umang Jain ","Subject":"[PATCH v16 1/9] libcamera: simple: Exclude raw configurations from\n\toutput conversions","Date":"Thu, 27 Nov 2025 22:19:22 +0100","Message-ID":"<20251127211932.122463-2-mzamazal@redhat.com>","In-Reply-To":"<20251127211932.122463-1-mzamazal@redhat.com>","References":"<20251127211932.122463-1-mzamazal@redhat.com>","MIME-Version":"1.0","X-Scanned-By":"MIMEDefang 3.0 on 10.30.177.12","X-Mimecast-Spam-Score":"0","X-Mimecast-MFC-PROC-ID":"EYtEkwCwuS7kqdBpyWZ5r5HUHeeGOpDYirrVMIdzwns_1764278385","X-Mimecast-Originator":"redhat.com","Content-Transfer-Encoding":"8bit","content-type":"text/plain; charset=\"US-ASCII\"; x-default=true","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"In order to support raw streams, we need to add raw formats to software\nISP configurations. In this preparatory patch, the raw formats are\nexcluded from output configurations for conversions.\n\nReviewed-by: Umang Jain \nSigned-off-by: Milan Zamazal \n---\n src/libcamera/pipeline/simple/simple.cpp | 9 ++++++++-\n 1 file changed, 8 insertions(+), 1 deletion(-)","diff":"diff --git a/src/libcamera/pipeline/simple/simple.cpp b/src/libcamera/pipeline/simple/simple.cpp\nindex a06a52926..ee65cd181 100644\n--- a/src/libcamera/pipeline/simple/simple.cpp\n+++ b/src/libcamera/pipeline/simple/simple.cpp\n@@ -27,6 +27,7 @@\n #include \n #include \n #include \n+#include \n #include \n #include \n \n@@ -264,6 +265,12 @@ static const SimplePipelineInfo supportedDevices[] = {\n \t{ \"sun6i-csi\", {}, false },\n };\n \n+bool isRaw(const StreamConfiguration &cfg)\n+{\n+\treturn libcamera::PixelFormatInfo::info(cfg.pixelFormat).colourEncoding ==\n+\t libcamera::PixelFormatInfo::ColourEncodingRAW;\n+}\n+\n } /* namespace */\n \n class SimpleCameraData : public Camera::Private\n@@ -1471,7 +1478,7 @@ int SimplePipelineHandler::configure(Camera *camera, CameraConfiguration *c)\n \n \t\tcfg.setStream(&data->streams_[i]);\n \n-\t\tif (data->useConversion_)\n+\t\tif (data->useConversion_ && !isRaw(cfg))\n \t\t\toutputCfgs.push_back(cfg);\n \t}\n \n","prefixes":["v16","1/9"]}