{"id":25254,"url":"https://patchwork.libcamera.org/api/1.1/patches/25254/?format=json","web_url":"https://patchwork.libcamera.org/patch/25254/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20251127023739.179652-18-bryan.odonoghue@linaro.org>","date":"2025-11-27T02:37:32","name":"[v5,17/24] libcamera: software_isp: Add a gpuisp todo list","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"f01a647225d31b1e58537e0a907e0236cc568a95","submitter":{"id":175,"url":"https://patchwork.libcamera.org/api/1.1/people/175/?format=json","name":"Bryan O'Donoghue","email":"bryan.odonoghue@linaro.org"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/25254/mbox/","series":[{"id":5617,"url":"https://patchwork.libcamera.org/api/1.1/series/5617/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5617","date":"2025-11-27T02:37:15","name":"Add GLES 2.0 GPUISP to libcamera","version":5,"mbox":"https://patchwork.libcamera.org/series/5617/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/25254/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/25254/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E7AA3C0F2A\n\tfor ;\n\tThu, 27 Nov 2025 02:38:24 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9171260B0F;\n\tThu, 27 Nov 2025 03:38:24 +0100 (CET)","from mail-wm1-x333.google.com (mail-wm1-x333.google.com\n\t[IPv6:2a00:1450:4864:20::333])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1034D60AB8\n\tfor ;\n\tThu, 27 Nov 2025 03:38:21 +0100 (CET)","by mail-wm1-x333.google.com with SMTP id\n\t5b1f17b1804b1-4779cb0a33fso2936345e9.0\n\tfor ;\n\tWed, 26 Nov 2025 18:38:21 -0800 (PST)","from inspiron14p-linux.ht.home (188-141-3-146.dynamic.upc.ie.\n\t[188.141.3.146]) by smtp.gmail.com with ESMTPSA id\n\t5b1f17b1804b1-4790552c3c9sm58186345e9.0.2025.11.26.18.38.18\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tWed, 26 Nov 2025 18:38:19 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"sSua98qs\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=linaro.org; s=google; t=1764211100; x=1764815900;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=wNqHKfrdqEnCd6e0vklefM1kTOpuhhmzodWah3Zo3gc=;\n\tb=sSua98qsWzVhcyY4U35J8XFhp1oyUgGdo2EdxbLAGFXC2p2HN9IKM6lJyuT2VeOfIE\n\tzkbLa2IOYotQ4R+D1KzrJ7iPFjFlJufKsQfo+AIx93BzzoNISUIIeJyV2pm0Z7RHqV4P\n\t2ogH4PBfiJQhdsy5/IQHH9+lovuj6f8W402/73j54W6qIXu/5TZy+7dDIiDA3gwnLO8K\n\tEm/wU8XPbW6ve1dX5+DMs06o5YL3oo17oxJG+FCyK5bE0KtfGd3OLnpzrPyMtjjn0dpe\n\ti2qY8aGoWimEuDRxKJjpGpuc/xo1elMWZPOkBUo9Cx10iXwqXgUZc00IL0JcG0N8OtNV\n\t2Fvw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1764211100; x=1764815900;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n\t:to:cc:subject:date:message-id:reply-to;\n\tbh=wNqHKfrdqEnCd6e0vklefM1kTOpuhhmzodWah3Zo3gc=;\n\tb=dlVUiwiYLxlyMst4pXvX6nm7fobaQn/y3uDXrm+g0Ox2/T4O7/n9Lxiioxlv7WE8JE\n\t+2dZ2eY2W9p8m2lHR3HJ9NkMVd6hgrpqefLZV6hd372UyjA6RgdJYy9u6WL2QEyUMYOP\n\tYXo2iWOnKF3lxm6I0/v2EjN1wS81AjSspm8TYDFhT0rLDzJERvoSFXSEGpTlR3pYKuKn\n\tNLEJX1/Q/LuMDn2pEeTE8SloPqJM9mgnZzFNfAwsWnwYZwEHICxNIUeUq3nNLcMjDkbA\n\tEbBUEoOQme0NQVYucsExmdRvX0EKZvdUCPNJgkhEANE63VIz+lK3YvXY1XKBDKJF5Pvu\n\tmTVA==","X-Gm-Message-State":"AOJu0Yx3U44UZgOOgU3KCnte6c2hip7p83blwLF0k5nwg2UXbSe9EEa9\n\tuuMLohV5zqWoNt9xyizexK1aO1Lh/AKFEg42BB5vITEgqNJs3H9Tlsmm1ttxBrOrZaCRF10a0T+\n\t0bs7ywA4=","X-Gm-Gg":"ASbGncv99VWr1yT7QnEifropehnwf7rO85D/aqPe7a5mth6+1fWBs/t5dpRUeowEqoW\n\ttVZNjsn9MOjSqcSVXN5unjgjqWpba2yezzuAI4tvbh74oOFpJ5by4ctmH4dpj+rcPsU/a3CphPq\n\t0VH7qr+Mk/Cu7lvJtPxdSCianQ371kenXus8Am+GA07k8ZJV+h/OaBKqg6qkSQmfpz1XU9M/cIY\n\tkhtF/rkPAyA+o4panEJYOwgontwqN2TvLHBJWa9lqJM9gVP1Dippol5AQ/1w4+r5NBr/kpjkhK+\n\tTe8yPDQk/ojYnioS1a7JtMGRsTaLRY5VjREPvG9rtfnHseo0K/xai/IqJ6PvB6JBP6f92GVD43D\n\tBK/Kn7lm1oIXVlc1P0wljHidzxmRKFsikmUAZwE7MwApc0RyRkwJugUXj9GvoIPJOfIIhPf0m7v\n\toaZ89j7zm5+fAhTw9TK5MAU0h2eDeROu7IuOXNjbPoctfj46RQP+fu/cENPBHrdnj0FbM=","X-Google-Smtp-Source":"AGHT+IFqX200VboC3AtNvqi0QDpyUB95dLnWrjnYxzzpv17YHNRnvGnvLpVa1g3pGaLZSUTP2lHZ0Q==","X-Received":"by 2002:a05:600c:470d:b0:471:1717:411 with SMTP id\n\t5b1f17b1804b1-477c01edab1mr272526585e9.24.1764211100395; \n\tWed, 26 Nov 2025 18:38:20 -0800 (PST)","From":"Bryan O'Donoghue ","To":"libcamera-devel@lists.libcamera.org","Cc":"pavel@ucw.cz, Bryan O'Donoghue ,\n\tKieran Bingham ","Subject":"[PATCH v5 17/24] libcamera: software_isp: Add a gpuisp todo list","Date":"Thu, 27 Nov 2025 02:37:32 +0000","Message-ID":"<20251127023739.179652-18-bryan.odonoghue@linaro.org>","X-Mailer":"git-send-email 2.51.2","In-Reply-To":"<20251127023739.179652-1-bryan.odonoghue@linaro.org>","References":"<20251127023739.179652-1-bryan.odonoghue@linaro.org>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"List the series of things to do in GPU ISP in perceived order of\ndifficulty.\n\nAcked-by: Kieran Bingham \nSigned-off-by: Bryan O'Donoghue \n---\n src/libcamera/software_isp/gpuisp-todo.txt | 83 ++++++++++++++++++++++\n 1 file changed, 83 insertions(+)\n create mode 100644 src/libcamera/software_isp/gpuisp-todo.txt","diff":"diff --git a/src/libcamera/software_isp/gpuisp-todo.txt b/src/libcamera/software_isp/gpuisp-todo.txt\nnew file mode 100644\nindex 000000000..768dcc320\n--- /dev/null\n+++ b/src/libcamera/software_isp/gpuisp-todo.txt\n@@ -0,0 +1,83 @@\n+List the TODOs in perceived order of ease.\n+\n+Version 3:\n+Use dma-buf handle to generate upload texture:\n+\t- eglCreateImageKHR can be used to generate the upload texture i.e.\n+\t to feed the bayer data into the GPU.\n+\n+Denoising:\n+\t- As below still TBD\n+\n+Dead pixel correction:\n+\t- As below still TBD\n+\n+Lense shading correction:\n+\t- This is WIP but as yet still TBD\n+\n+Lense flare correction:\n+\t- Not WIP still TBD\n+\n+processFrame() to run in its own thread:\n+\t- processFrame() runs in the context of the Debayer::process()\n+\t thread. Robert Mader suggested and it seems like a good\n+\t suggestion too to run processFrame() in its own thread.\n+\n+Version 2:\n+Make GPUISP default:\n+\t- Right now the environment variable allows over-riding to swtich\n+\t from CPU to GPU.\n+\t- Once we support 24 BPP output on GPUISP we will have the same\n+\t pixel format support as CPU and can set the default to GPU without\n+\t regressing functionality\n+\n+glTexture1D:\n+\t- Initial code was developed for < GLES 2.O but since we have fixed\n+\t on GLES >= 2.0 this means we can use glTexture1D\n+\t- Provided this is so amend the shaders to do val = texture(x, y, 0);\n+\t not texture(x, y, 0.5) the 0.5 is because of using glTexture2D\n+\n+Denoising:\n+\t- Run a denoise algorithm in the shaders\n+\t- Supply a control to influence the noise-floor ?\n+\n+Dead pixel correction:\n+\t- Add logic to correct dead pixels in the fragment shaders\n+\n+Version 1:\n+24 bit output support:\n+\t- Take the BPP we already capture and get a 24 bit GBM surface\n+\t- Pass a compile-time parameter to the shaders to tell them to do\n+\t gl_FragColor = rgb not gl_FragColor = rgba\n+\t- Version 2:\n+\t This is not possible.\n+\t gl_FragColor expects vec4 not vec3 on the output.\n+\t If you really want RGB888 run cpuisp.\n+\n+Surfaceless GBM:\n+\t- We get a GBM surface and then have to swap buffers\n+\t If we rework for surfaceless GBM and EGL then the swap buffer can\n+\t be dropped.\n+\t- Version 2:\n+\t Complete GBM surface removed, memcpy() phase removed also\n+\n+dma-buf texture upload:\n+\t- Currently we pass the input buffer to glCreateTexture2D.\n+\t We should be able to make the upload of the input buffer go faster\n+\t by using eglCreateImageKHR and enumerated the dma-buf contents.\n+\t- Version 2:\n+\t Complete sm8250 test platform shows 20x performance increase\n+\t with CCM.\n+\n+Render-to-texture:\n+\t- Right now we render to the GBM provided surface framebuffer\n+\t and then memcpy from that buffer to the target output buffer.\n+\t This necessitates flushing the cache on the target buffer in\n+\t addition to the memcpy().\n+\t- Render-to-texture where we generate the target framebuffer\n+\t directly from a dma-buf handle will mitigate the memcpy() phase.\n+\t- It should be the case then that the consumer of the output buffer\n+\t i.e. the thing that's not libcamera is responsible to flush the cache\n+\t if-and-only-if that user writes to the buffer.\n+\t- We need to flush the cache on the buffer because we are memcpying() to it.\n+\t- Version 2:\n+\t Done in version 2\n","prefixes":["v5","17/24"]}