{"id":25238,"url":"https://patchwork.libcamera.org/api/1.1/patches/25238/?format=json","web_url":"https://patchwork.libcamera.org/patch/25238/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20251127023739.179652-2-bryan.odonoghue@linaro.org>","date":"2025-11-27T02:37:16","name":"[v5,01/24] libcamera: software_isp: gbm: Add a GBM helper class for GPU surface access","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"bdcb1d415ff25794e7490f22e130997f3221f734","submitter":{"id":175,"url":"https://patchwork.libcamera.org/api/1.1/people/175/?format=json","name":"Bryan O'Donoghue","email":"bryan.odonoghue@linaro.org"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/25238/mbox/","series":[{"id":5617,"url":"https://patchwork.libcamera.org/api/1.1/series/5617/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5617","date":"2025-11-27T02:37:15","name":"Add GLES 2.0 GPUISP to libcamera","version":5,"mbox":"https://patchwork.libcamera.org/series/5617/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/25238/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/25238/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C2614C3257\n\tfor ;\n\tThu, 27 Nov 2025 02:37:48 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 6280360AA4;\n\tThu, 27 Nov 2025 03:37:48 +0100 (CET)","from mail-wm1-x334.google.com (mail-wm1-x334.google.com\n\t[IPv6:2a00:1450:4864:20::334])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B74A2609DE\n\tfor ;\n\tThu, 27 Nov 2025 03:37:46 +0100 (CET)","by mail-wm1-x334.google.com with SMTP id\n\t5b1f17b1804b1-47795f6f5c0so1431565e9.1\n\tfor ;\n\tWed, 26 Nov 2025 18:37:46 -0800 (PST)","from inspiron14p-linux.ht.home (188-141-3-146.dynamic.upc.ie.\n\t[188.141.3.146]) by smtp.gmail.com with ESMTPSA id\n\t5b1f17b1804b1-4790552c3c9sm58186345e9.0.2025.11.26.18.37.44\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tWed, 26 Nov 2025 18:37:44 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"v6e1zN0n\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=linaro.org; s=google; t=1764211066; x=1764815866;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=25pB8O0ewcdP9Lkbp8q4k2CjU62VSX7AV+aAc5IUYUA=;\n\tb=v6e1zN0noHZ0CcfQcwz++p9RmMQvLttJuoaLjJJWxvTYSJy0B2stl1wlu8v5hpIute\n\tKGbDZjh6cWBjoskL11wM+ROpLE/jmTMepm+Gu33yA9o1gYrEDi0SNnBM+4EqnKL9UiTH\n\tfeesg9K3H6ubzSujN1dIM9v0eFlm0nEGV6sLxQyt5qifeJDh5rEsrQHbBNLinabu4km/\n\tIERC1MV3X6tI/ffFGECoZD+L6t0UprtKu89Yq8XizMYdQMs/bkp1QzuW9VDekkWtk5Ml\n\taVhboGgJs+9l6fRuGcrRBGRDgD6bOFY2Ji+FNqXIvMPjnHDYCAURWkzCAlzSbXkCMYsd\n\tfazQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1764211066; x=1764815866;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n\t:to:cc:subject:date:message-id:reply-to;\n\tbh=25pB8O0ewcdP9Lkbp8q4k2CjU62VSX7AV+aAc5IUYUA=;\n\tb=a6/SqjblBMccaAwm2RwfTaFQFt+54FKNcPs8Ap0W10roDWOiFO+mfgdV5Kg6p7PBtb\n\tL2L0ASh8mSr2kIsp9uRbqU+BOqF8oSjGlTZOXSu+hzK9sUpfFuwTOrEnGnHZTPgB1fYw\n\tH1XgyAcNBcGDz7ija/rN6etY2uMJnT5uH0QCNqs7JVbjuSuhnKW+80c0wtmLrTaF/jIj\n\tyBqZ+MCdNMIM4fD0VxxfybVHTYHLAvmzuE+pN/Erritkbk4bMmVUzae4yM7pmkowGn8W\n\tcKbnK4lDKF1Wa/bHiQLcLSwHLv6SXg/zihHu3y0HHE8MmiWMI5u0WUuHlJcWEloKVBkd\n\tv1uQ==","X-Gm-Message-State":"AOJu0YypC7bqz5hpKoaUQr5QBp2L+GWx7RtHDZduuHdIbuSLLOKcXGx1\n\t/wX5EfALUkJjNOYW9obOH0KDrJI0rdHNlF3C4YlE35fDnQj0arE1MU900eHKDux5gXbSa3pWdQm\n\tArNCkGlc=","X-Gm-Gg":"ASbGncvu7qeACSsKbbcfKUkB0DIdPfoPNWn2ajmfSFoXNr5/QPsPG/dHA3walhLi9D2\n\tdGWO7np7p++n0Ug3XFFLMPX13zNwR+OniSQOn7/MLKamGlZL4L93BC7fve8Ipve84I4zCdQAzV8\n\t7wub+uJivYhE8BNZDOryHIETvAFK9MpL4+2fHvpuFFRqN9AgYWr4CAZ9+kneeL1zleeArJGz0z5\n\t6HqyhXwbA76ahyzibAUskg0aMmAXP3M/pOwOCwuMwxptjOqXxJ4PPHN4IkcDmRUT4qBmUQhhQv7\n\tnW2374IheNk+ytOjkdcDuX97o7lJvzbu00V6Sqm/SnzucyNJZwsDfH83nUmKTMZjT7lNTdBLJyr\n\tNEORZkXGVZl0Js4X1nb2oR9JqiAlfphWZHxRdVkCKGtNv3PWZpZ8F449rYbmYiuNor2Ld8c+wUI\n\t9t6OT8lPvLhkCz4RdqSTbECWaiVtJAiHWRgIvVH8LLdQ/v/8Gs9YaVK45+wzC1njiJdNLt0vPa5\n\tMWCkg==","X-Google-Smtp-Source":"AGHT+IGcWhzJBO2L5Al6zpkMFC0ws+AAOa45xxwnHeRxra6E2mmlTLUqG6m1lew8WR6uSrq0euRG+Q==","X-Received":"by 2002:a05:600c:474b:b0:477:8b2e:aa8f with SMTP id\n\t5b1f17b1804b1-477c0181287mr253291615e9.15.1764211066059; \n\tWed, 26 Nov 2025 18:37:46 -0800 (PST)","From":"Bryan O'Donoghue ","To":"libcamera-devel@lists.libcamera.org","Cc":"pavel@ucw.cz, Bryan O'Donoghue ,\n\tKieran Bingham ","Subject":"[PATCH v5 01/24] libcamera: software_isp: gbm: Add a GBM helper\n\tclass for GPU surface access","Date":"Thu, 27 Nov 2025 02:37:16 +0000","Message-ID":"<20251127023739.179652-2-bryan.odonoghue@linaro.org>","X-Mailer":"git-send-email 2.51.2","In-Reply-To":"<20251127023739.179652-1-bryan.odonoghue@linaro.org>","References":"<20251127023739.179652-1-bryan.odonoghue@linaro.org>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"A helper class to interact with GBM. This will allow us to specify the\ninternal storage format of the GPU when making a texture for the Debayer\nvertex/fragment shaders and thus ensure we receive an uncompressed and\nuntiled output buffer.\n\nAcked-by: Kieran Bingham \nSigned-off-by: Bryan O'Donoghue \n---\n include/libcamera/internal/gbm.h | 39 ++++++++\n include/libcamera/internal/meson.build | 1 +\n src/libcamera/gbm.cpp | 130 +++++++++++++++++++++++++\n src/libcamera/meson.build | 11 +++\n 4 files changed, 181 insertions(+)\n create mode 100644 include/libcamera/internal/gbm.h\n create mode 100644 src/libcamera/gbm.cpp","diff":"diff --git a/include/libcamera/internal/gbm.h b/include/libcamera/internal/gbm.h\nnew file mode 100644\nindex 000000000..6852def58\n--- /dev/null\n+++ b/include/libcamera/internal/gbm.h\n@@ -0,0 +1,39 @@\n+/* SPDX-License-Identifier: LGPL-2.1-or-later */\n+/*\n+ * Copyright (C) 2024, Linaro Ltd.\n+ *\n+ * Authors:\n+ * Bryan O'Donoghue \n+ *\n+ * gbm.h - Helper class for managing GBM interactions.\n+ */\n+\n+#pragma once\n+\n+#include \n+\n+#include \n+\n+#include \n+\n+namespace libcamera {\n+\n+LOG_DECLARE_CATEGORY(GBM)\n+\n+class GBM\n+{\n+public:\n+\tGBM();\n+\t~GBM();\n+\n+\tint createDevice();\n+\tstruct gbm_device *getDevice();\n+\tPixelFormat getPixelFormat();\n+\n+private:\n+\tint fd_;\n+\tstruct gbm_device *gbm_device_;\n+\tPixelFormat format_;\n+};\n+\n+} // namespace libcamera\ndiff --git a/include/libcamera/internal/meson.build b/include/libcamera/internal/meson.build\nindex e9540a2f7..b8324996b 100644\n--- a/include/libcamera/internal/meson.build\n+++ b/include/libcamera/internal/meson.build\n@@ -23,6 +23,7 @@ libcamera_internal_headers = files([\n 'dma_buf_allocator.h',\n 'formats.h',\n 'framebuffer.h',\n+ 'gbm.h',\n 'global_configuration.h',\n 'ipa_data_serializer.h',\n 'ipa_manager.h',\ndiff --git a/src/libcamera/gbm.cpp b/src/libcamera/gbm.cpp\nnew file mode 100644\nindex 000000000..7d53cd43e\n--- /dev/null\n+++ b/src/libcamera/gbm.cpp\n@@ -0,0 +1,130 @@\n+/* SPDX-License-Identifier: LGPL-2.1-or-later */\n+/*\n+ * Copyright (C) 2024, Linaro Ltd.\n+ *\n+ * Authors:\n+ * Bryan O'Donoghue \n+ *\n+ * egl.cpp - Helper class for managing GBM interactions.\n+ */\n+\n+#include \"libcamera/internal/gbm.h\"\n+\n+#include \n+#include \n+#include \n+#include \n+#include \n+\n+#include \n+#include \n+\n+namespace libcamera {\n+\n+LOG_DEFINE_CATEGORY(GBM)\n+\n+/**\n+ * \\class GBM\n+ * \\brief Helper class for managing GBM interactions\n+ *\n+ * The GBM class provides a simplified interface for creating and managing\n+ * GBM devices. It handles the initialization and teardown of GBM devices\n+ * used for buffer allocation in graphics and camera pipelines.\n+ *\n+ * This class is responsible for opening a DRI render node, creating a GBM\n+ * device, and providing access to the device and its associated pixel format.\n+ */\n+\n+/**\n+ *\\var GBM::fd_\n+ *\\brief file descriptor to DRI device\n+ */\n+\n+/**\n+ *\\var GBM::gbm_device_\n+ *\\brief Pointer to GBM device structure derived from fd_\n+ */\n+\n+/**\n+ *\\var GBM::format_\n+ *\\brief Pixel format the GBM surface was created in\n+ */\n+\n+/**\n+ *\\brief GBM constructor.\n+ *\n+ * Creates a GBM instance with unitialised state.\n+ */\n+GBM::GBM()\n+{\n+\tfd_ = 0;\n+\tgbm_device_ = NULL;\n+}\n+\n+/**\n+ *\\brief GBM destructor\n+ *\n+ * Cleans up the GBM device if it was successfully created, and closes\n+ * the associated file descriptor.\n+ */\n+GBM::~GBM()\n+{\n+\tif (gbm_device_)\n+\t\tgbm_device_destroy(gbm_device_);\n+}\n+\n+/**\n+ * \\brief Create and initialize a GBM device\n+ *\n+ * Opens the DRI render node (/dev/dri/renderD128) and creates a GBM\n+ * device using the libgbm library. Sets the default pixel format to\n+ * ARGB8888.\n+ *\n+ * \\return 0 on success, or a negative error code on failure\n+ */\n+int GBM::createDevice()\n+{\n+\tconst char *dri_node = \"/dev/dri/renderD128\"; //TODO: get from an env or config setting\n+\n+\tfd_ = open(dri_node, O_RDWR | O_CLOEXEC);\n+\tif (fd_ < 0) {\n+\t\tLOG(GBM, Error) << \"Open \" << dri_node << \" fail \" << fd_;\n+\t\treturn fd_;\n+\t}\n+\n+\tgbm_device_ = gbm_create_device(fd_);\n+\tif (!gbm_device_) {\n+\t\tLOG(GBM, Error) << \"gbm_crate_device fail\";\n+\t\tgoto fail;\n+\t}\n+\n+\tformat_ = libcamera::formats::ARGB8888;\n+\n+\treturn 0;\n+fail:\n+\tclose(fd_);\n+\treturn -errno;\n+}\n+\n+/**\n+ * \\brief Retrieve the GBM device handle\n+ *\n+ * \\return Pointer to the gbm_device structure, or nullptr if the device\n+ * has not been created\n+ */\n+struct gbm_device * GBM::getDevice()\n+{\n+\treturn gbm_device_;\n+}\n+\n+/**\n+ * \\brief Retrieve the pixel format\n+ *\n+ * \\return The PixelFormat used by this GBM instance (ARGB8888)\n+ */\n+\n+PixelFormat GBM::getPixelFormat()\n+{\n+\treturn format_;\n+}\n+} //namespace libcamera\ndiff --git a/src/libcamera/meson.build b/src/libcamera/meson.build\nindex 90d434a5a..4eaa42062 100644\n--- a/src/libcamera/meson.build\n+++ b/src/libcamera/meson.build\n@@ -70,6 +70,16 @@ libcamera_deps = []\n libatomic = cc.find_library('atomic', required : false)\n libthreads = dependency('threads')\n \n+libgbm = cc.find_library('gbm', required: false)\n+gbm_works = cc.check_header('gbm.h', required: false)\n+\n+if libgbm.found() and gbm_works\n+ config_h.set('HAVE_GBM', 1)\n+ libcamera_internal_sources += files([\n+ 'gbm.cpp',\n+ ])\n+endif\n+\n subdir('base')\n subdir('converter')\n subdir('ipa')\n@@ -178,6 +188,7 @@ libcamera_deps += [\n libcamera_base_private,\n libcrypto,\n libdl,\n+ libgbm,\n liblttng,\n libudev,\n libyaml,\n","prefixes":["v5","01/24"]}