{"id":25236,"url":"https://patchwork.libcamera.org/api/1.1/patches/25236/?format=json","web_url":"https://patchwork.libcamera.org/patch/25236/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20251127022256.178929-23-bryan.odonoghue@linaro.org>","date":"2025-11-27T02:22:54","name":"[v2,22/22] libcamera: software_isp: lut: Make contrast available in debayer params","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"83993195e06b0449ff8570fc403c27b5cf696655","submitter":{"id":175,"url":"https://patchwork.libcamera.org/api/1.1/people/175/?format=json","name":"Bryan O'Donoghue","email":"bryan.odonoghue@linaro.org"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/25236/mbox/","series":[{"id":5616,"url":"https://patchwork.libcamera.org/api/1.1/series/5616/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5616","date":"2025-11-27T02:22:32","name":"GPUISP precursor series","version":2,"mbox":"https://patchwork.libcamera.org/series/5616/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/25236/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/25236/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D409DC32DE\n\tfor ;\n\tThu, 27 Nov 2025 02:23:54 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 85F3B60BDD;\n\tThu, 27 Nov 2025 03:23:54 +0100 (CET)","from mail-wm1-x329.google.com (mail-wm1-x329.google.com\n\t[IPv6:2a00:1450:4864:20::329])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A94EF60AB3\n\tfor ;\n\tThu, 27 Nov 2025 03:23:50 +0100 (CET)","by mail-wm1-x329.google.com with SMTP id\n\t5b1f17b1804b1-477a2ab455fso2942555e9.3\n\tfor ;\n\tWed, 26 Nov 2025 18:23:50 -0800 (PST)","from inspiron14p-linux.ht.home (188-141-3-146.dynamic.upc.ie.\n\t[188.141.3.146]) by smtp.gmail.com with ESMTPSA id\n\t5b1f17b1804b1-4790b0e21e8sm71549495e9.15.2025.11.26.18.23.48\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tWed, 26 Nov 2025 18:23:48 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"Sjus5DFw\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=linaro.org; s=google; t=1764210230; x=1764815030;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=TAFofCRjRwju8c6LgHdbB3OSOLTvh/yl77wh8eBrJ3s=;\n\tb=Sjus5DFwKBwBQbULyOn6wIb762HxrLwg5+cbSGKaT/BZ3P82sG2U6UEDX15GLU0bE2\n\tM5qDDpP7S57f2D+RkSeGUxEPhcTgl/N+248YN2nE8x6mSbnGpEUX2tfnviWAWebgyytS\n\tPfRK2S5BlNbM0CkBjeg1zqic0kxrxjS63Uh5xJdXGadizCiwSJUNpehTSztndPURmXz7\n\tOkdUrOmZu+SJXvVvfoK9yLpyDPKSHx2KP3gKo0htvD2XGw9rzZdgX4IrMORU8lWUjcki\n\thpZ5YsAkDv/Vpj+5SRqETWDE26QcO3f4SEmVKBdIFU7zDTw+MGp90nbTaJJS4XfEiRnZ\n\tamRg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1764210230; x=1764815030;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n\t:to:cc:subject:date:message-id:reply-to;\n\tbh=TAFofCRjRwju8c6LgHdbB3OSOLTvh/yl77wh8eBrJ3s=;\n\tb=bkm+6tned8O7OTdiR/nSLgccuczJA5lVyaHoJmXgM1YQaxicMFjyUyI8FcVz7DsrR4\n\t2oM3fyZvlrXPBR0hlBXSk+35aOjDnQfPnQJoUSZdYKIklQdtx7EZsActPMO4XyqeujJa\n\tgHseZko5de1gBcJwFBUkSPviQm9UHI1bgfHG89aqc8ibRrzta6otnjIQ3lHud6zitq0D\n\tRgupob5m6X3zYwR1oB8dwNmjnWZDsnS6kb/4Fr0kaicQbOMojKEAL1DqbmIKf46HMv/W\n\t0Lkk0/8lUjZwZuD/DDNcVtpONL9anqM2iznKpMHDlA9uSwrtaN5+hhSjQbj5nOXuT0Ys\n\tQEAA==","X-Gm-Message-State":"AOJu0YxMwkXh1Lrn4Zl/DU3oZRTg9b0sbdTY1PYtDCMUV7+zUFAlajxB\n\tE+Azt/11uvkAnGXLjgUIEM77qYldh3XsNE6azZf0VHEV83tCBST6MvwNWOagNOZ7NflnDneM+NO\n\t1YVfpyBk=","X-Gm-Gg":"ASbGncupcMFoIkgZ8U+COlp66vgngTEX4mTWM5YqUEr+LdCg4NuXmOj3VTJLRXBr6zs\n\tk7ZjYkG0OY1lcnKYjoQR8ByzX/TMPljbHuObeMV/H8pxOQKXvHjLww3sUDrWrZ+b5+GhpMGnqEQ\n\t1QLQDm75WcJkQQibIHqAopp/chfAi/Lul6rN7cipRJfpX417THWcBWIjdzgQZHiJ8B0Qr1owfv4\n\tnPMsPRXO8QOSijRNChC0AjY1NjhGciB5KJdYqIkTyL4HNSR9m85skqulb+bL0hhhp8lIbxrywhY\n\twNt8EoxXwkmFv5hoFvdlWn98Blf9i/PvLerSjZJmOS2HlrdN5ITs/9J/K8pAqhvUmtNK5fZpXrf\n\tBeUMb9+OeMLUul6D4lHeI77M/SjbLRBVen/KLHdylDqOKb5Ylfs5kB2ZCDX11vVgAxVqgojJDTV\n\tBFqaUBhU3hwfihRFkd3gA+8cIc9O5b9q25JtX6S1gPF3jzqBWR2OP1MZGmbH6+B9qc4hM=","X-Google-Smtp-Source":"AGHT+IHErMILY2dosC1BTv2NfRqYlEeafYQ2eiwRfkTKwGTVtuL20SiTvnt123GTLBv4SH+3VIWfXQ==","X-Received":"by 2002:a05:600c:1ca4:b0:45d:f83b:96aa with SMTP id\n\t5b1f17b1804b1-477c10c92d8mr257620405e9.7.1764210230019; \n\tWed, 26 Nov 2025 18:23:50 -0800 (PST)","From":"Bryan O'Donoghue ","To":"libcamera-devel@lists.libcamera.org","Cc":"pavel@ucw.cz, Bryan O'Donoghue ,\n\tMilan Zamazal ","Subject":"[PATCH v2 22/22] libcamera: software_isp: lut: Make contrast\n\tavailable in debayer params","Date":"Thu, 27 Nov 2025 02:22:54 +0000","Message-ID":"<20251127022256.178929-23-bryan.odonoghue@linaro.org>","X-Mailer":"git-send-email 2.51.2","In-Reply-To":"<20251127022256.178929-1-bryan.odonoghue@linaro.org>","References":"<20251127022256.178929-1-bryan.odonoghue@linaro.org>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Provide the contrast used in IPA to Bayer parameters. Similar to the\ncalculated Gamma value we will pass this value into the debayer fragment\nshader for further consumption.\n\nReviewed-by: Milan Zamazal \nSigned-off-by: Bryan O'Donoghue \n---\n include/libcamera/internal/software_isp/debayer_params.h | 1 +\n src/ipa/simple/algorithms/lut.cpp | 1 +\n src/libcamera/software_isp/debayer.cpp | 5 +++++\n 3 files changed, 7 insertions(+)","diff":"diff --git a/include/libcamera/internal/software_isp/debayer_params.h b/include/libcamera/internal/software_isp/debayer_params.h\nindex d5dad1a98..8033f7d5b 100644\n--- a/include/libcamera/internal/software_isp/debayer_params.h\n+++ b/include/libcamera/internal/software_isp/debayer_params.h\n@@ -59,6 +59,7 @@ struct DebayerParams {\n \tMatrix ccm;\n \tRGB blackLevel;\n \tfloat gamma;\n+\tfloat contrast;\n };\n \n } /* namespace libcamera */\ndiff --git a/src/ipa/simple/algorithms/lut.cpp b/src/ipa/simple/algorithms/lut.cpp\nindex ea5a86b20..9aaab54f1 100644\n--- a/src/ipa/simple/algorithms/lut.cpp\n+++ b/src/ipa/simple/algorithms/lut.cpp\n@@ -149,6 +149,7 @@ void Lut::prepare(IPAContext &context,\n \t}\n \n \tparams->gamma = context.configuration.gamma;\n+\tparams->contrast = context.activeState.gamma.contrast;\n }\n \n void Lut::process([[maybe_unused]] IPAContext &context,\ndiff --git a/src/libcamera/software_isp/debayer.cpp b/src/libcamera/software_isp/debayer.cpp\nindex 8bcbd5dde..f0307549b 100644\n--- a/src/libcamera/software_isp/debayer.cpp\n+++ b/src/libcamera/software_isp/debayer.cpp\n@@ -115,6 +115,11 @@ namespace libcamera {\n * \\brief Gamma value for the GPUISP\n */\n \n+/**\n+ * \\var DebayerParams::contrast\n+ * \\brief Contrast value for GPUISP\n+ */\n+\n /**\n * \\class Debayer\n * \\brief Base debayering class\n","prefixes":["v2","22/22"]}