{"id":25230,"url":"https://patchwork.libcamera.org/api/1.1/patches/25230/?format=json","web_url":"https://patchwork.libcamera.org/patch/25230/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20251127022256.178929-17-bryan.odonoghue@linaro.org>","date":"2025-11-27T02:22:48","name":"[v2,16/22] libcamera: software_isp: Move configure to worker thread","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"e843334eee03f6e4e74c0af75b16b9052ae9e8ab","submitter":{"id":175,"url":"https://patchwork.libcamera.org/api/1.1/people/175/?format=json","name":"Bryan O'Donoghue","email":"bryan.odonoghue@linaro.org"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/25230/mbox/","series":[{"id":5616,"url":"https://patchwork.libcamera.org/api/1.1/series/5616/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5616","date":"2025-11-27T02:22:32","name":"GPUISP precursor series","version":2,"mbox":"https://patchwork.libcamera.org/series/5616/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/25230/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/25230/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 5DE10C3260\n\tfor ;\n\tThu, 27 Nov 2025 02:23:42 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id EEC6A60AB8;\n\tThu, 27 Nov 2025 03:23:41 +0100 (CET)","from mail-wm1-x32a.google.com (mail-wm1-x32a.google.com\n\t[IPv6:2a00:1450:4864:20::32a])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3FA9460B0C\n\tfor ;\n\tThu, 27 Nov 2025 03:23:40 +0100 (CET)","by mail-wm1-x32a.google.com with SMTP id\n\t5b1f17b1804b1-47796a837c7so1830055e9.0\n\tfor ;\n\tWed, 26 Nov 2025 18:23:40 -0800 (PST)","from inspiron14p-linux.ht.home (188-141-3-146.dynamic.upc.ie.\n\t[188.141.3.146]) by smtp.gmail.com with ESMTPSA id\n\t5b1f17b1804b1-4790b0e21e8sm71549495e9.15.2025.11.26.18.23.37\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tWed, 26 Nov 2025 18:23:38 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"clo4I6Y4\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=linaro.org; s=google; t=1764210219; x=1764815019;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=KaV04Bxgis4mNG/lyi1+ASdW7XQgEYuf59tHgnfd3u4=;\n\tb=clo4I6Y4BDoxDZZmAxAHG7dYmVjnJm4pH0IrLGrM+jCHo676n/DKOC2COLF1tbf4JX\n\tApfMDa/kvZkb3hIFvJzCmVNBLAgievdLF8dd+dTDfq6VSRma7sa8uPw+LD436ngfRF5Y\n\trYB/dEg3y4mU2IG8f/hCjo2+kmglv/Ja2goL5UZI3RGzuhVgLji1QWuLyIqbgXct3f13\n\tnVbhRAav1pq3/Y245VVAzgzd6RFTRmJWh91fqqsyfsQJN9JhpvBJBCeSfMBaQKjYjk80\n\tuT3PdT3yx55e71lDNYwHyWra1rVK5T2K3wze8QG4Td25OaVKbfW1ZHjfCc0F5PoUFV+8\n\tn33A==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1764210219; x=1764815019;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n\t:to:cc:subject:date:message-id:reply-to;\n\tbh=KaV04Bxgis4mNG/lyi1+ASdW7XQgEYuf59tHgnfd3u4=;\n\tb=mC1OwVAkTtksOEEc82L9a5nQgTNB/Cii4ePzJwzZbUh18bRCJvUTJF9k9Hw019BMKf\n\ti1zz+6lfcUtTWlozIlB+kh2RNFZ+2Ul2Fm6yQbU3B5y8opNmRHuMvjCqOdqH3V7iHW2A\n\tBBrfISxsoMXyrS19XG2eQyoqZRd6VR2EOF3LMWPBgDvjIETKaarVHDId38dlw0bV2kqx\n\tu23kQ2+rHNFTXflckfCyu8fzT2ZJJ0q3F/UcVyQjzspou34d3Y5xYEliGUjFZhybe0s4\n\tVOUePSdZ5LRD4xA0T+8ydqvhdWTA8wCeFYnvsQtyEcJa1c2BwiQBN9/KIbQdgZjwahjy\n\tjmpg==","X-Gm-Message-State":"AOJu0YwBk0Gr9bSLowiIsXHz+7tJZRJbGYj8bz9KnDmpKDcXb8n2Kgos\n\tCoS9xhBaa4uWwjAqeWXn8aI+GN82SG3ihItFEX88Dbhz7YIGkP74KwlrIZc6GJMntee8XUxwtvx\n\tJhhOssVM=","X-Gm-Gg":"ASbGncuelcbvqrF6Fb1Yhzc5O2UyzHsFOAcNtjpzCkrmtCO1pBdqLnnGcMUGzUXJtyg\n\tL2sZBFCD7uh8IX+jdDesGqNyQWbatNZMHGkP+flnk0PC+J/DpiSdPMeuy8xpYgzfm3HWvpY4eNd\n\txLdjkhvPwfi3SfxE7NbC/e789/FkJInY0JLpux8rnCEoGRvm+FNE0eYCQdCp/HzHsI2fRc6/zVU\n\twwD7M2UCB/baHlzl+CF2IlMiIL82ZEaDgWQ07L7WIxhAMOp31IQVRQRCB62+tyse3vojM4RWEYy\n\tK9/c1GQgYcjCtSfyveXzPRbCDX4aYYD2fC3FNeJv5Le0Lb+h9iJmZFJPxlpDQNh2dzlH1cyzVrU\n\tuKDfq9hHpgvFywd8CLFdFbP5jzc4gfSvtgG58WhJrIg33f/jsNooqq470MvAsmeX9834Il3eu51\n\tA2dtz5SR+qRd1M41p+/82V+ONnFa6F54ziP4vMKh/r5qXLbdgqdlnPA6ojjr61RFyob6EOY2PDm\n\to/ghQ==","X-Google-Smtp-Source":"AGHT+IFxfXemKPKV8Ky1eqwQJwLKv4dkS1/38hWFaF7bDg6K7T5lKkrdQ2CcB6p0trHJxmtManFyXg==","X-Received":"by 2002:a05:600c:3146:b0:477:df7:b020 with SMTP id\n\t5b1f17b1804b1-477c01b2211mr216527785e9.18.1764210219597; \n\tWed, 26 Nov 2025 18:23:39 -0800 (PST)","From":"Bryan O'Donoghue ","To":"libcamera-devel@lists.libcamera.org","Cc":"pavel@ucw.cz,\n\tBryan O'Donoghue ","Subject":"[PATCH v2 16/22] libcamera: software_isp: Move configure to worker\n\tthread","Date":"Thu, 27 Nov 2025 02:22:48 +0000","Message-ID":"<20251127022256.178929-17-bryan.odonoghue@linaro.org>","X-Mailer":"git-send-email 2.51.2","In-Reply-To":"<20251127022256.178929-1-bryan.odonoghue@linaro.org>","References":"<20251127022256.178929-1-bryan.odonoghue@linaro.org>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"EGL requires both configure() and process() to operate on the same\nthread. As preparation for that, move current CPU configure into the\nWorkerThread with a ConnectionTypeBlocking invocation of\n&DebayerCpu::configure.\n\nSigned-off-by: Bryan O'Donoghue \n---\n src/libcamera/software_isp/software_isp.cpp | 12 ++++++++++--\n 1 file changed, 10 insertions(+), 2 deletions(-)","diff":"diff --git a/src/libcamera/software_isp/software_isp.cpp b/src/libcamera/software_isp/software_isp.cpp\nindex afa4eb7a8..4c232339b 100644\n--- a/src/libcamera/software_isp/software_isp.cpp\n+++ b/src/libcamera/software_isp/software_isp.cpp\n@@ -267,7 +267,15 @@ int SoftwareIsp::configure(const StreamConfiguration &inputCfg,\n \n \tispWorkerThread_.start();\n \n-\treturn debayer_->configure(inputCfg, outputCfgs, ccmEnabled_);\n+\tret = debayer_->invokeMethod(&Debayer::configure,\n+\t\t\t\t ConnectionTypeBlocking, inputCfg,\n+\t\t\t\t outputCfgs, ccmEnabled_);\n+\tif (ret) {\n+\t\tispWorkerThread_.exit();\n+\t\tispWorkerThread_.wait();\n+\t}\n+\n+\treturn ret;\n }\n \n /**\n@@ -391,7 +399,7 @@ void SoftwareIsp::stop()\n void SoftwareIsp::process(uint32_t frame, FrameBuffer *input, FrameBuffer *output)\n {\n \tipa_->computeParams(frame);\n-\tdebayer_->invokeMethod(&DebayerCpu::process,\n+\tdebayer_->invokeMethod(&Debayer::process,\n \t\t\t ConnectionTypeQueued, frame, input, output, debayerParams_);\n }\n \n","prefixes":["v2","16/22"]}