{"id":25228,"url":"https://patchwork.libcamera.org/api/1.1/patches/25228/?format=json","web_url":"https://patchwork.libcamera.org/patch/25228/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20251127022256.178929-15-bryan.odonoghue@linaro.org>","date":"2025-11-27T02:22:46","name":"[v2,14/22] libcamera: software_isp: Move isStandardBayerOrder to base class","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"0094dda74511475d5cf28efcf4ef636c82c9bfcd","submitter":{"id":175,"url":"https://patchwork.libcamera.org/api/1.1/people/175/?format=json","name":"Bryan O'Donoghue","email":"bryan.odonoghue@linaro.org"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/25228/mbox/","series":[{"id":5616,"url":"https://patchwork.libcamera.org/api/1.1/series/5616/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5616","date":"2025-11-27T02:22:32","name":"GPUISP precursor series","version":2,"mbox":"https://patchwork.libcamera.org/series/5616/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/25228/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/25228/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 7A20DC3260\n\tfor ;\n\tThu, 27 Nov 2025 02:23:38 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1DA6D60AC8;\n\tThu, 27 Nov 2025 03:23:38 +0100 (CET)","from mail-wm1-x32c.google.com (mail-wm1-x32c.google.com\n\t[IPv6:2a00:1450:4864:20::32c])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 31F4D60AA2\n\tfor ;\n\tThu, 27 Nov 2025 03:23:36 +0100 (CET)","by mail-wm1-x32c.google.com with SMTP id\n\t5b1f17b1804b1-477b1cc8fb4so1602185e9.1\n\tfor ;\n\tWed, 26 Nov 2025 18:23:36 -0800 (PST)","from inspiron14p-linux.ht.home (188-141-3-146.dynamic.upc.ie.\n\t[188.141.3.146]) by smtp.gmail.com with ESMTPSA id\n\t5b1f17b1804b1-4790b0e21e8sm71549495e9.15.2025.11.26.18.23.33\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tWed, 26 Nov 2025 18:23:34 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"gNYOAPIF\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=linaro.org; s=google; t=1764210215; x=1764815015;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=jCaLe3/UWqLlNrzkfiMHL8sWpJisLkNSLQveLCRiGQI=;\n\tb=gNYOAPIFIDOiBLVCX6VYAvl+4NU8sXP6sUxsb1oJxn0bhKEk94BcCqioNH4l0aNXYk\n\tk/IY0LdMj+L4lf1TqmH9IfHuf6g+Rapw3WTRVDbEzd4VqCDsGqlk7SlgCoWqyuv/Jknz\n\t9bqFfpnPfePZHem89IXiKkXjLb69wzSQqUAdm1X/6+h3F3WpaSl4MicPgJ8rJGJFgcja\n\tA7nCwWdKjYZsmC3M1Ovp4kBEyl64F5g+AGaBCMizrDRR2OSjCd9dyRJk8bjRLaJUV/1T\n\tb+Sm/k2SvXpqrWfUCLmy5zbUsb7mfm8Ke+zityfZRqOPex54OKp467qhVr14EO/Gs9mf\n\tFKzQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1764210215; x=1764815015;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n\t:to:cc:subject:date:message-id:reply-to;\n\tbh=jCaLe3/UWqLlNrzkfiMHL8sWpJisLkNSLQveLCRiGQI=;\n\tb=tYgPthMaDcikk4UGICLbp/MR/3FDFfbC23EvZb31aF0dECJ3/amlQEYKPXiiSPZO4n\n\tYpe1qN/QfN0sFfov081YRMqjhXOzbH7qFJAfXVZoRjvb9+eUE8J1Yj5z/wTtNjlIWbyC\n\txH7Daswmv1wNMJIaA8KiMvN7q7Dj2IUkR4JuT8gmgiNqp7n8iV9pBYRkEggl8gxReAoh\n\tLyHaGMqyGvIkH/rdvWkzrihXzFFzxoDEQnNF42qXL3FpcDFd4NNuiOYmPEmyp+KL3TaJ\n\tGfCbAltG4rd0OpdIgUBZaaxc77IqGIPN39dz2gTambz5OEFYXeF2nqCb/5isWYvCKKMS\n\t1MjA==","X-Gm-Message-State":"AOJu0YywsXmJtr5F61lSHsdOHA8w6ZIOP3OiZF47cTVuyN3zxyjci8w0\n\tTyvUYEASFWAVLbKErOZw9/GToASygNPeliAswiBCyByLyJXRitbQIlPrUtDnXov1/BD5zA/pxcQ\n\tvOALmnmM=","X-Gm-Gg":"ASbGnctYbV0lrjZt92O0+G2YjxOLMpV8/R07GZQiKRTH88lvLTthWnAWgxemjk/NmdR\n\tmZXeinJQXBuQ1U0lOIGgitHolvr/rAkzTBWqK7N2JmbKiC9Hjijs+C6/ez6ZvyxeM8h1777Indg\n\tnBLY0N42RZWK0P0059Wi91bLBPeFyrsHbopYjocAEz0GJmbohU4X/QjYeJTcYGYksPTDpyc0r/p\n\tstN7/LYkc3ZpLdnXz0sa//WM7qzsGK8v0isYn/SP29zp/ec8yYiuI0tvALqzlUNfJBz6wQlmbIR\n\tyeGMaeLS3ht9pYxxNkzPFUTvJE14KwNABZgkcrFpdf3qXdsNAk40Lgrh8h5KVUCq5CiJufBLrAu\n\tU6Dro4yjhqyPBKts9FQ7GsaAk/qN/41T8RpmmH6neOJOUOCO/zQjT+nukOqpVmMHfzOBCpvnhdv\n\tUKo59MV0n63r+pZL5YE5ZS6eGDrsY9XvzWfciz0S7ZsVfZKsPT1nNzU65e+6cV6TCIp4mSQ6yx/\n\tmIT4w==","X-Google-Smtp-Source":"AGHT+IGY9uxppccb10Nkpqyh5YN5+IsTQsreC8A5gA9I6JHljIx5+3CPzOfT78PgPrpCfCkDW+Ke8g==","X-Received":"by 2002:a05:600c:4443:b0:46e:53cb:9e7f with SMTP id\n\t5b1f17b1804b1-47904b103e2mr90365565e9.18.1764210215495; \n\tWed, 26 Nov 2025 18:23:35 -0800 (PST)","From":"Bryan O'Donoghue ","To":"libcamera-devel@lists.libcamera.org","Cc":"pavel@ucw.cz, Bryan O'Donoghue ,\n\tKieran Bingham ,\n\tMilan Zamazal ","Subject":"[PATCH v2 14/22] libcamera: software_isp: Move isStandardBayerOrder\n\tto base class","Date":"Thu, 27 Nov 2025 02:22:46 +0000","Message-ID":"<20251127022256.178929-15-bryan.odonoghue@linaro.org>","X-Mailer":"git-send-email 2.51.2","In-Reply-To":"<20251127022256.178929-1-bryan.odonoghue@linaro.org>","References":"<20251127022256.178929-1-bryan.odonoghue@linaro.org>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"isStandardBayerOrder is useful to both CPU and GPU debayer logic and\nreusable as-is for both.\n\nMove to shared location in base class.\n\nReviewed-by: Kieran Bingham \nReviewed-by: Milan Zamazal \nSigned-off-by: Bryan O'Donoghue \n---\n src/libcamera/software_isp/debayer.cpp | 10 ++++++++++\n src/libcamera/software_isp/debayer.h | 2 ++\n src/libcamera/software_isp/debayer_cpu.cpp | 6 ------\n 3 files changed, 12 insertions(+), 6 deletions(-)","diff":"diff --git a/src/libcamera/software_isp/debayer.cpp b/src/libcamera/software_isp/debayer.cpp\nindex 158128f30..1d135b278 100644\n--- a/src/libcamera/software_isp/debayer.cpp\n+++ b/src/libcamera/software_isp/debayer.cpp\n@@ -379,4 +379,14 @@ void Debayer::dmaSyncBegin(std::vector &dmaSyncers, FrameBuffer *inpu\n \t}\n }\n \n+/**\n+ * \\fn void Debayer::isStandardBayerOrder(BayerFormat::Order order)\n+ * \\brief Common method to validate standard 2x2 Bayer pattern of 2 Green, 1 Blue, 1 Red pixels.\n+ */\n+bool Debayer::isStandardBayerOrder(BayerFormat::Order order)\n+{\n+\treturn order == BayerFormat::BGGR || order == BayerFormat::GBRG ||\n+\t order == BayerFormat::GRBG || order == BayerFormat::RGGB;\n+}\n+\n } /* namespace libcamera */\ndiff --git a/src/libcamera/software_isp/debayer.h b/src/libcamera/software_isp/debayer.h\nindex d2893d81b..451c1c9ac 100644\n--- a/src/libcamera/software_isp/debayer.h\n+++ b/src/libcamera/software_isp/debayer.h\n@@ -20,6 +20,7 @@\n #include \n #include \n \n+#include \"libcamera/internal/bayer_format.h\"\n #include \"libcamera/internal/dma_buf_allocator.h\"\n #include \"libcamera/internal/global_configuration.h\"\n #include \"libcamera/internal/software_isp/benchmark.h\"\n@@ -88,6 +89,7 @@ private:\n protected:\n \tvoid setParams(DebayerParams ¶ms);\n \tvoid dmaSyncBegin(std::vector &dmaSyncers, FrameBuffer *input, FrameBuffer *output);\n+\tbool isStandardBayerOrder(BayerFormat::Order order);\n };\n \n } /* namespace libcamera */\ndiff --git a/src/libcamera/software_isp/debayer_cpu.cpp b/src/libcamera/software_isp/debayer_cpu.cpp\nindex 8f1b4e53d..00738c56b 100644\n--- a/src/libcamera/software_isp/debayer_cpu.cpp\n+++ b/src/libcamera/software_isp/debayer_cpu.cpp\n@@ -288,12 +288,6 @@ void DebayerCpu::debayer10P_RGRG_BGR888(uint8_t *dst, const uint8_t *src[])\n \t}\n }\n \n-static bool isStandardBayerOrder(BayerFormat::Order order)\n-{\n-\treturn order == BayerFormat::BGGR || order == BayerFormat::GBRG ||\n-\t order == BayerFormat::GRBG || order == BayerFormat::RGGB;\n-}\n-\n /*\n * Setup the Debayer object according to the passed in parameters.\n * Return 0 on success, a negative errno value on failure\n","prefixes":["v2","14/22"]}