{"id":25208,"url":"https://patchwork.libcamera.org/api/1.1/patches/25208/?format=json","web_url":"https://patchwork.libcamera.org/patch/25208/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20251125162851.2301793-30-stefan.klug@ideasonboard.com>","date":"2025-11-25T16:28:41","name":"[v3,29/29] DNI pipeline: rkisp1: Workaround for customer kernels without requests","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"d7c13f969ef0bf76b8b2cf87c045089db88c4482","submitter":{"id":184,"url":"https://patchwork.libcamera.org/api/1.1/people/184/?format=json","name":"Stefan Klug","email":"stefan.klug@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/25208/mbox/","series":[{"id":5613,"url":"https://patchwork.libcamera.org/api/1.1/series/5613/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5613","date":"2025-11-25T16:28:12","name":"Full dewarper support on imx8mp","version":3,"mbox":"https://patchwork.libcamera.org/series/5613/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/25208/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/25208/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B3764C3338\n\tfor ;\n\tTue, 25 Nov 2025 16:30:22 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4CFCF60C6B;\n\tTue, 25 Nov 2025 17:30:22 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9D6FB60AA0\n\tfor ;\n\tTue, 25 Nov 2025 17:30:20 +0100 (CET)","from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:bae1:340c:573c:570b])\n\tby perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id ABBDC13DE; \n\tTue, 25 Nov 2025 17:28:11 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"r3FHwVVU\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1764088091;\n\tbh=Ej4n1s7zWgywj6UeXPKqrRbpzpaHW3RxX4rYZ0woPQM=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=r3FHwVVUBkVLgjbNJW5yyikyoh36+Rf+z33yfp+X/XznzByZGh7NBGMk5ieLJS8cM\n\twqhUkdPh8o/dNUcQGpG6W5c/GQLAIxWYnu0ts4uqSqc314tQl5d3FyhXl7vLQ3HqAV\n\t2PXhgIXvAM+XKbgjeN2EZRsSm4XJePd89c3+WK+I=","From":"Stefan Klug ","To":"libcamera-devel@lists.libcamera.org","Cc":"Stefan Klug ","Subject":"[PATCH v3 29/29] DNI pipeline: rkisp1: Workaround for customer\n\tkernels without requests","Date":"Tue, 25 Nov 2025 17:28:41 +0100","Message-ID":"<20251125162851.2301793-30-stefan.klug@ideasonboard.com>","X-Mailer":"git-send-email 2.51.0","In-Reply-To":"<20251125162851.2301793-1-stefan.klug@ideasonboard.com>","References":"<20251125162851.2301793-1-stefan.klug@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"There are a few kernels out there that have dynamic vertex map support,\nbut no requests support. Allow full dewarp usage on these.\n\nSigned-off-by: Stefan Klug \n---\n src/libcamera/converter/converter_dw100.cpp | 13 ++++++++++++-\n 1 file changed, 12 insertions(+), 1 deletion(-)","diff":"diff --git a/src/libcamera/converter/converter_dw100.cpp b/src/libcamera/converter/converter_dw100.cpp\nindex b39e4ab23cd6..22a15a368e38 100644\n--- a/src/libcamera/converter/converter_dw100.cpp\n+++ b/src/libcamera/converter/converter_dw100.cpp\n@@ -33,6 +33,17 @@ LOG_DECLARE_CATEGORY(Converter)\n * and it has direct support for libcamera controls.\n */\n \n+namespace {\n+\n+/*\n+ * This flag allows to use dynamic dewarp maps to support pan, zoom, rotate when\n+ * the kernel driver doesn't support requests. Only needed for legacy customer\n+ * kernels.\n+ */\n+static constexpr bool kAllowDynamicDewarpMapsWithoutRequests = true;\n+\n+} /* namespace */\n+\n ConverterDW100Module::ConverterDW100Module(std::shared_ptr media)\n \t: converter_(media), running_(false)\n {\n@@ -353,7 +364,7 @@ void ConverterDW100Module::updateControlInfos(const Stream *stream, ControlInfoM\n \tcontrols[&controls::Dw100ScaleMode] =\n \t\tControlInfo(controls::Dw100ScaleModeValues, controls::Dw100ScaleModeFill);\n \n-\tif (!converter_.supportsRequests())\n+\tif (!converter_.supportsRequests() && !kAllowDynamicDewarpMapsWithoutRequests)\n \t\tLOG(Converter, Warning)\n \t\t\t<< \"dw100 kernel driver has no requests support.\"\n \t\t\t \" Dynamic configuration is not possible.\";\n","prefixes":["v3","29/29"]}