{"id":25198,"url":"https://patchwork.libcamera.org/api/1.1/patches/25198/?format=json","web_url":"https://patchwork.libcamera.org/patch/25198/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20251125162851.2301793-20-stefan.klug@ideasonboard.com>","date":"2025-11-25T16:28:31","name":"[v3,19/29] pipeline: rkisp1: Drop rawFormat variable","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"90b2e02bc180a310bcf3281339c91b29cd4c83b8","submitter":{"id":184,"url":"https://patchwork.libcamera.org/api/1.1/people/184/?format=json","name":"Stefan Klug","email":"stefan.klug@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/25198/mbox/","series":[{"id":5613,"url":"https://patchwork.libcamera.org/api/1.1/series/5613/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5613","date":"2025-11-25T16:28:12","name":"Full dewarper support on imx8mp","version":3,"mbox":"https://patchwork.libcamera.org/series/5613/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/25198/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/25198/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 84295C333C\n\tfor ;\n\tTue, 25 Nov 2025 16:29:53 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3362760AA9;\n\tTue, 25 Nov 2025 17:29:53 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5E3EA60A9E\n\tfor ;\n\tTue, 25 Nov 2025 17:29:51 +0100 (CET)","from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:bae1:340c:573c:570b])\n\tby perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id 64E5813DE; \n\tTue, 25 Nov 2025 17:27:42 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"YRdzuD74\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1764088062;\n\tbh=Is2AlUQtyGNBusRQNqG1cbaXEUpDTn3nPIWS/o2ObzA=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=YRdzuD74A38rblkj2c3rV3fQ7UFJkWo7kjg8vhbwACGeA5tiqimJxLaKK+c+UF318\n\tKw+QGz0TlJvE3/2z/7/afdvSQuGc/WzTyCkcFF6WiLEn7wu/sIV0aNAA1SY2+lf0o4\n\tuq8rxzIwl6XaRV6u5kvW/F8yr0hoIXtmEzFmwQF4=","From":"Stefan Klug ","To":"libcamera-devel@lists.libcamera.org","Cc":"Stefan Klug ,\n\tUmang Jain , =?utf-8?q?Barnab=C3=A1s_P=C5=91cze?=\n\t, Paul Elder\n\t","Subject":"[PATCH v3 19/29] pipeline: rkisp1: Drop rawFormat variable","Date":"Tue, 25 Nov 2025 17:28:31 +0100","Message-ID":"<20251125162851.2301793-20-stefan.klug@ideasonboard.com>","X-Mailer":"git-send-email 2.51.0","In-Reply-To":"<20251125162851.2301793-1-stefan.klug@ideasonboard.com>","References":"<20251125162851.2301793-1-stefan.klug@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"In raw mode we know there is only a single configuration so there\nis no need to iterate over all configurations to find the format.\nDrop that.\n\nSigned-off-by: Stefan Klug \nReviewed-by: Umang Jain \nReviewed-by: Barnabás Pőcze \nReviewed-by: Paul Elder \n---\n src/libcamera/pipeline/rkisp1/rkisp1.cpp | 9 ++-------\n 1 file changed, 2 insertions(+), 7 deletions(-)","diff":"diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\nindex a11d70849121..2972d6e1cbd1 100644\n--- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n+++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n@@ -677,21 +677,16 @@ CameraConfiguration::Status RkISP1CameraConfiguration::validate()\n \t}\n \n \t/* Select the sensor format. */\n-\tPixelFormat rawFormat;\n \tSize maxSize;\n \n \tfor (const StreamConfiguration &cfg : config_) {\n-\t\tconst PixelFormatInfo &info = PixelFormatInfo::info(cfg.pixelFormat);\n-\t\tif (info.colourEncoding == PixelFormatInfo::ColourEncodingRAW)\n-\t\t\trawFormat = cfg.pixelFormat;\n-\n \t\tmaxSize = std::max(maxSize, cfg.size);\n \t}\n \n \tstd::vector mbusCodes;\n \n-\tif (rawFormat.isValid()) {\n-\t\tmbusCodes = { rawFormats.at(rawFormat) };\n+\tif (isRaw) {\n+\t\tmbusCodes = { rawFormats.at(config_[0].pixelFormat) };\n \t} else {\n \t\tstd::transform(rawFormats.begin(), rawFormats.end(),\n \t\t\t std::back_inserter(mbusCodes),\n","prefixes":["v3","19/29"]}