{"id":25192,"url":"https://patchwork.libcamera.org/api/1.1/patches/25192/?format=json","web_url":"https://patchwork.libcamera.org/patch/25192/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20251125162851.2301793-14-stefan.klug@ideasonboard.com>","date":"2025-11-25T16:28:25","name":"[v3,13/29] libcamera: rkisp1: Allow upscaling when the dewarper is present","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"86250ad76805c58fb3c9633374b276e6e3a1a045","submitter":{"id":184,"url":"https://patchwork.libcamera.org/api/1.1/people/184/?format=json","name":"Stefan Klug","email":"stefan.klug@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/25192/mbox/","series":[{"id":5613,"url":"https://patchwork.libcamera.org/api/1.1/series/5613/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5613","date":"2025-11-25T16:28:12","name":"Full dewarper support on imx8mp","version":3,"mbox":"https://patchwork.libcamera.org/series/5613/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/25192/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/25192/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B5BF1C333C\n\tfor ;\n\tTue, 25 Nov 2025 16:29:36 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 51C6B60ABB;\n\tTue, 25 Nov 2025 17:29:36 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5D2D760A9D\n\tfor ;\n\tTue, 25 Nov 2025 17:29:33 +0100 (CET)","from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:bae1:340c:573c:570b])\n\tby perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id 70E17524;\n\tTue, 25 Nov 2025 17:27:24 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"QCrpfaAs\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1764088044;\n\tbh=54seuIsjJEBIcBROwnfmlkpCovzEqz1s9O3NMQZYXm8=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=QCrpfaAs1eOI2rYYs8Wet4FjuK5qtBsoMpnGkh0WsWXQZe+9QIlKzIVxflObrXnvx\n\t0xcDohiPWEnDf9Owt37MSeVHXL/KcNf5hXAEIVcwNxyNaOOq1IHKG9cR0rmvBdFKQX\n\tYqIwwBu67ngQnFq9jLYCJh3pKiETqDWFOoLQ13M0=","From":"Stefan Klug ","To":"libcamera-devel@lists.libcamera.org","Cc":"Stefan Klug ,\n\tPaul Elder ","Subject":"[PATCH v3 13/29] libcamera: rkisp1: Allow upscaling when the\n\tdewarper is present","Date":"Tue, 25 Nov 2025 17:28:25 +0100","Message-ID":"<20251125162851.2301793-14-stefan.klug@ideasonboard.com>","X-Mailer":"git-send-email 2.51.0","In-Reply-To":"<20251125162851.2301793-1-stefan.klug@ideasonboard.com>","References":"<20251125162851.2301793-1-stefan.klug@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"When the dewarper is present, there is no need to forbid upscaling of\nthe image data.\n\nSigned-off-by: Stefan Klug \nReviewed-by: Paul Elder \n\n---\n\nChanges in v3:\n- Collected tag\n---\n src/libcamera/pipeline/rkisp1/rkisp1.cpp | 5 +++++\n 1 file changed, 5 insertions(+)","diff":"diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\nindex 2d89b0b41958..79c8717c839a 100644\n--- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n+++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n@@ -609,6 +609,11 @@ CameraConfiguration::Status RkISP1CameraConfiguration::validate()\n \t\t\treturn false;\n \n \t\tif (useDewarper) {\n+\t\t\t/*\n+\t\t\t * The dewarper output is independent of the ISP path.\n+\t\t\t * Reset to the originally requested size.\n+\t\t\t */\n+\t\t\ttryCfg.size = cfg.size;\n \t\t\tbool adjusted;\n \n \t\t\tpipe->dewarper_->validateOutput(&tryCfg, &adjusted,\n","prefixes":["v3","13/29"]}