{"id":25178,"url":"https://patchwork.libcamera.org/api/1.1/patches/25178/?format=json","web_url":"https://patchwork.libcamera.org/patch/25178/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20251125000848.4103786-12-rui.wang@ideasonboard.com>","date":"2025-11-25T00:08:48","name":"[v1,11/11] ipa: rkisp1: algorithms: dpf: publish DPF metadata","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"dc592ea7565440d9b6d031f5a834ed2920a9aa73","submitter":{"id":241,"url":"https://patchwork.libcamera.org/api/1.1/people/241/?format=json","name":"Rui Wang","email":"rui.wang@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/25178/mbox/","series":[{"id":5612,"url":"https://patchwork.libcamera.org/api/1.1/series/5612/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5612","date":"2025-11-25T00:08:37","name":"ipa: rkisp1: DPF refactor and tuning improvements","version":1,"mbox":"https://patchwork.libcamera.org/series/5612/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/25178/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/25178/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 3B184C32EF\n\tfor ;\n\tTue, 25 Nov 2025 00:09:25 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D02A060AA9;\n\tTue, 25 Nov 2025 01:09:24 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id CE4A560AB2\n\tfor ;\n\tTue, 25 Nov 2025 01:09:21 +0100 (CET)","from rui-Precision-7560.local (unknown\n\t[IPv6:2607:fea8:935b:7220:cb34:a7b8:53d:5466])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id C63DE17EB;\n\tTue, 25 Nov 2025 01:07:12 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"roEgZwme\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1764029233;\n\tbh=ovL0wjZY8E6+vr8e/kGetsg/IUbZrJMEp1uOplzTMHM=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=roEgZwmeb4uCvm1e6CPymU5T45KGPUhRPD0RWJrKKVa8VtL/oFfpkYH/7RzLLTDE0\n\tigrJWzjzdx2hcuJhiK9+te7nwKWbMvEk4V4g0dpVDjIkvY/kxOB14KwEOd2VLfn6eN\n\tbsUwD5wlirGlr/YOXiMglaIpsZszpznd7G++MgcY=","From":"Rui Wang ","To":"libcamera-devel@lists.libcamera.org","Cc":"Rui Wang ","Subject":"[PATCH v1 11/11] ipa: rkisp1: algorithms: dpf: publish DPF metadata","Date":"Mon, 24 Nov 2025 19:08:48 -0500","Message-ID":"<20251125000848.4103786-12-rui.wang@ideasonboard.com>","X-Mailer":"git-send-email 2.43.0","In-Reply-To":"<20251125000848.4103786-1-rui.wang@ideasonboard.com>","References":"<20251125000848.4103786-1-rui.wang@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Implement process() and fillMetadata() to publish DPF status and current\nconfiguration values in frame metadata. This allows applications to read\nback the active DPF settings.\n\nMetadata published every frame:\n- DpfExposeIndex: Current index value computed from AGC gains\n- DpfMode: Current mode (auto/manual)\n- DpfChannelStrengths: Active R/G/B strength values\n\nDeveloper mode metadata (when enabled):\n- DpfGreenSpatialCoefficients: Green spatial filter coefficients\n- DpfRedBlueSpatialCoefficients: RB spatial filter coefficients\n- DpfRbFilterSize: RB filter size (9x9 or 13x9)\n- DpfNoiseLevelLookupCoefficients: NLL coefficients\n- DpfNoiseLevelLookupScaleMode: NLL scale mode (linear/log)\n\nSigned-off-by: Rui Wang \n---\n src/ipa/rkisp1/algorithms/denoise.h | 16 +++++++++\n src/ipa/rkisp1/algorithms/dpf.cpp | 56 +++++++++++++++++++++++++++++\n src/ipa/rkisp1/algorithms/dpf.h | 7 ++++\n 3 files changed, 79 insertions(+)","diff":"diff --git a/src/ipa/rkisp1/algorithms/denoise.h b/src/ipa/rkisp1/algorithms/denoise.h\nindex c532b7eb..a54e3c43 100644\n--- a/src/ipa/rkisp1/algorithms/denoise.h\n+++ b/src/ipa/rkisp1/algorithms/denoise.h\n@@ -71,6 +71,10 @@ protected:\n \t{\n \t}\n \tvirtual ControlInfoMap::Map getControlMap() const;\n+\tvirtual void fillMetadata(IPAContext &context,\n+\t\t\t\t IPAFrameContext &frameContext,\n+\t\t\t\t ControlList &metadata);\n+\n private:\n \t/**< Developer mode state for advanced controls */\n \tbool devMode_ = false;\n@@ -108,6 +112,18 @@ inline ControlInfoMap::Map DenoiseBaseAlgorithm::getControlMap() const\n \tmap[&controls::rkisp1::ExposureGainIndex] = ControlInfo(0, 6400, 0);\n \treturn map;\n }\n+\n+inline void DenoiseBaseAlgorithm::fillMetadata(IPAContext &context,\n+\t\t\t\t\t IPAFrameContext &frameContext,\n+\t\t\t\t\t ControlList &metadata)\n+{\n+\tuint32_t exposureIndex = computeExposureIndex(context, frameContext);\n+\tmetadata.set(controls::rkisp1::ExposureGainIndex, static_cast(exposureIndex));\n+\n+\tauto currentMode = getRunningMode();\n+\tmetadata.set(controls::rkisp1::DenoiseMode, currentMode);\n+}\n+\n } /* namespace ipa::rkisp1::algorithms */\n \n } /* namespace libcamera */\ndiff --git a/src/ipa/rkisp1/algorithms/dpf.cpp b/src/ipa/rkisp1/algorithms/dpf.cpp\nindex a3a8e789..b3880d41 100644\n--- a/src/ipa/rkisp1/algorithms/dpf.cpp\n+++ b/src/ipa/rkisp1/algorithms/dpf.cpp\n@@ -911,6 +911,62 @@ void Dpf::prepareDisabledMode([[maybe_unused]] IPAContext &context,\n \tstr.setEnabled(false);\n }\n \n+/**\n+ * \\copydoc libcamera::ipa::Algorithm::process\n+ */\n+void Dpf::process(IPAContext &context, const uint32_t frame [[maybe_unused]],\n+\t\t IPAFrameContext &frameContext,\n+\t\t const rkisp1_stat_buffer *stats [[maybe_unused]],\n+\t\t ControlList &metadata)\n+{\n+\tfillMetadata(context, frameContext, metadata);\n+}\n+\n+void Dpf::fillMetadata(IPAContext &context,\n+\t\t IPAFrameContext &frameContext,\n+\t\t ControlList &metadata)\n+{\n+\tDenoiseBaseAlgorithm::fillMetadata(context, frameContext, metadata);\n+\t/* Strength (R,G,B) - always available */\n+\tint32_t strength[3] = { (int32_t)strengthConfig_.r,\n+\t\t\t\t(int32_t)strengthConfig_.g,\n+\t\t\t\t(int32_t)strengthConfig_.b };\n+\tmetadata.set(controls::rkisp1::DpfChannelStrengths,\n+\t\t Span(strength));\n+\n+\tif (!isDevMode())\n+\t\treturn;\n+\n+\t/* Advanced controls only in devmode */\n+\t/* Spatial kernels */\n+\tint32_t gCoeffs[RKISP1_CIF_ISP_DPF_MAX_SPATIAL_COEFFS];\n+\tint32_t rbCoeffs[RKISP1_CIF_ISP_DPF_MAX_SPATIAL_COEFFS];\n+\tfor (uint32_t i = 0; i < RKISP1_CIF_ISP_DPF_MAX_SPATIAL_COEFFS; ++i) {\n+\t\tgCoeffs[i] = config_.g_flt.spatial_coeff[i];\n+\t\trbCoeffs[i] = config_.rb_flt.spatial_coeff[i];\n+\t}\n+\tmetadata.set(controls::rkisp1::DpfGreenSpatialCoefficients,\n+\t\t Span(gCoeffs));\n+\tmetadata.set(controls::rkisp1::DpfRedBlueSpatialCoefficients,\n+\t\t Span(rbCoeffs));\n+\n+\t/* RB filter size (0=9x9,1=13x9) */\n+\tint32_t fltSize = (config_.rb_flt.fltsize == RKISP1_CIF_ISP_DPF_RB_FILTERSIZE_13x9) ? 1 : 0;\n+\tmetadata.set(controls::rkisp1::DpfRbFilterSize, fltSize);\n+\n+\t/* NLL coefficients and scale */\n+\tint32_t nll[RKISP1_CIF_ISP_DPF_MAX_NLF_COEFFS];\n+\tfor (uint32_t i = 0; i < RKISP1_CIF_ISP_DPF_MAX_NLF_COEFFS; ++i)\n+\t\tnll[i] = config_.nll.coeff[i];\n+\tmetadata.set(controls::rkisp1::DpfNoiseLevelLookupCoefficients,\n+\t\t Span(nll));\n+\tint32_t scaleMode = (config_.nll.scale_mode == RKISP1_CIF_ISP_NLL_SCALE_LOGARITHMIC) ? 1 : 0;\n+\tmetadata.set(controls::rkisp1::DpfNoiseLevelLookupScaleMode, scaleMode);\n+}\n+\n REGISTER_IPA_ALGORITHM(Dpf, \"Dpf\")\n \n } /* namespace ipa::rkisp1::algorithms */\ndiff --git a/src/ipa/rkisp1/algorithms/dpf.h b/src/ipa/rkisp1/algorithms/dpf.h\nindex e62882f2..64b80556 100644\n--- a/src/ipa/rkisp1/algorithms/dpf.h\n+++ b/src/ipa/rkisp1/algorithms/dpf.h\n@@ -29,6 +29,10 @@ public:\n \tvoid prepare(IPAContext &context, const uint32_t frame,\n \t\t IPAFrameContext &frameContext,\n \t\t RkISP1Params *params) override;\n+\tvoid process(IPAContext &context, const uint32_t frame [[maybe_unused]],\n+\t\t IPAFrameContext &frameContext,\n+\t\t const rkisp1_stat_buffer *stats [[maybe_unused]],\n+\t\t ControlList &metadata) override;\n \n private:\n \tstruct rkisp1_cif_isp_dpf_config config_;\n@@ -103,6 +107,9 @@ private:\n \tvoid prepareEnabledMode(IPAContext &context, const uint32_t frame,\n \t\t\t\tIPAFrameContext &frameContext, RkISP1Params *params) override;\n \tControlInfoMap::Map getControlMap() const override;\n+\tvoid fillMetadata(IPAContext &context,\n+\t\t\t IPAFrameContext &frameContext,\n+\t\t\t ControlList &metadata) override;\n };\n \n } /* namespace ipa::rkisp1::algorithms */\n","prefixes":["v1","11/11"]}