{"id":25173,"url":"https://patchwork.libcamera.org/api/1.1/patches/25173/?format=json","web_url":"https://patchwork.libcamera.org/patch/25173/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20251125000848.4103786-7-rui.wang@ideasonboard.com>","date":"2025-11-25T00:08:43","name":"[v1,06/11] ipa: rkisp1: algorithms: dpf: detect DPF dev overrides","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"f3601df77246b3288ed2b393dbd235b39d144538","submitter":{"id":241,"url":"https://patchwork.libcamera.org/api/1.1/people/241/?format=json","name":"Rui Wang","email":"rui.wang@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/25173/mbox/","series":[{"id":5612,"url":"https://patchwork.libcamera.org/api/1.1/series/5612/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5612","date":"2025-11-25T00:08:37","name":"ipa: rkisp1: DPF refactor and tuning improvements","version":1,"mbox":"https://patchwork.libcamera.org/series/5612/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/25173/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/25173/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 88AF9C3257\n\tfor ;\n\tTue, 25 Nov 2025 00:09:18 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 413EE60AAE;\n\tTue, 25 Nov 2025 01:09:18 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4B0E960A8B\n\tfor ;\n\tTue, 25 Nov 2025 01:09:14 +0100 (CET)","from rui-Precision-7560.local (unknown\n\t[IPv6:2607:fea8:935b:7220:cb34:a7b8:53d:5466])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 7F9041785;\n\tTue, 25 Nov 2025 01:07:05 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"NM2AyiEK\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1764029225;\n\tbh=+a+kr1XhxCJeDB+hUFWNDEQC0gKZhoIYYErNDTALa5A=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=NM2AyiEK3xJ/8M3xEL+av3qlKXxQe9853hvA3b0wK6GHjZYCuL5t558sulYB3Wnh/\n\tD6thvnpbYvYcbXk8cjyHK9SLZL0IYCrSTjj+eCFW/LOxDziaOSfcqciS9/0sY0F/Bt\n\tQezMrZ2p1xt1zlWATZesThSKuq/yU8TpQJeaqM/8=","From":"Rui Wang ","To":"libcamera-devel@lists.libcamera.org","Cc":"Rui Wang ","Subject":"[PATCH v1 06/11] ipa: rkisp1: algorithms: dpf: detect DPF dev\n\toverrides","Date":"Mon, 24 Nov 2025 19:08:43 -0500","Message-ID":"<20251125000848.4103786-7-rui.wang@ideasonboard.com>","X-Mailer":"git-send-email 2.43.0","In-Reply-To":"<20251125000848.4103786-1-rui.wang@ideasonboard.com>","References":"<20251125000848.4103786-1-rui.wang@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Introduce checkDevModeOverridesChanged() to detect when developer-mode\ncontrols have been modified. This function compares override values against\nthe current hardware configuration for:\n- Spatial coefficients (green and RB)\n- RB filter size\n- NLL coefficients and scale mode\n\nUpdates queueRequest() to trigger hardware updates whenever dev-mode\noverrides differ from active settings. This ensures spatial kernels, NLL\ntables, and filter size changes are applied immediately in manual mode.\n\nSigned-off-by: Rui Wang \n---\n src/ipa/rkisp1/algorithms/dpf.cpp | 50 +++++++++++++++++++++++++++++++\n src/ipa/rkisp1/algorithms/dpf.h | 1 +\n 2 files changed, 51 insertions(+)","diff":"diff --git a/src/ipa/rkisp1/algorithms/dpf.cpp b/src/ipa/rkisp1/algorithms/dpf.cpp\nindex 2d7d6414..0b070206 100644\n--- a/src/ipa/rkisp1/algorithms/dpf.cpp\n+++ b/src/ipa/rkisp1/algorithms/dpf.cpp\n@@ -424,6 +424,56 @@ void Dpf::collectManualOverrides(const ControlList &controls)\n \t}\n }\n \n+bool Dpf::checkOverridesChanged()\n+{\n+\t/* Check strength always (not dev-mode specific) */\n+\tif (overrides_.strength) {\n+\t\tif (overrides_.strength->r != strengthConfig_.r ||\n+\t\t overrides_.strength->g != strengthConfig_.g ||\n+\t\t overrides_.strength->b != strengthConfig_.b) {\n+\t\t\treturn true;\n+\t\t}\n+\t}\n+\n+\tif (!isDevMode())\n+\t\treturn false;\n+\n+\tif (overrides_.spatialGreen &&\n+\t !std::equal(overrides_.spatialGreen->coeffs.begin(), overrides_.spatialGreen->coeffs.end(),\n+\t\t\tconfig_.g_flt.spatial_coeff)) {\n+\t\treturn true;\n+\t}\n+\tif (overrides_.spatialRb &&\n+\t !std::equal(overrides_.spatialRb->coeffs.begin(), overrides_.spatialRb->coeffs.end(),\n+\t\t\tconfig_.rb_flt.spatial_coeff)) {\n+\t\treturn true;\n+\t}\n+\tif (overrides_.rbSize) {\n+\t\tbool currentRbSize =\n+\t\t\t(config_.rb_flt.fltsize == RKISP1_CIF_ISP_DPF_RB_FILTERSIZE_13x9)\n+\t\t\t\t? 1\n+\t\t\t\t: 0;\n+\t\tif (*overrides_.rbSize != currentRbSize) {\n+\t\t\treturn true;\n+\t\t}\n+\t}\n+\tif (overrides_.nll) {\n+\t\tbool coeffsChanged =\n+\t\t\t!std::equal(overrides_.nll->coeffs.begin(),\n+\t\t\t\t overrides_.nll->coeffs.end(),\n+\t\t\t\t config_.nll.coeff);\n+\t\tbool scaleChanged =\n+\t\t\toverrides_.nll->scaleMode !=\n+\t\t\t(config_.nll.scale_mode == RKISP1_CIF_ISP_NLL_SCALE_LOGARITHMIC\n+\t\t\t\t ? 1\n+\t\t\t\t : 0);\n+\t\tif (coeffsChanged || scaleChanged) {\n+\t\t\treturn true;\n+\t\t}\n+\t}\n+\treturn false;\n+}\n+\n /**\n * \\copydoc libcamera::ipa::Algorithm::queueRequest\n */\ndiff --git a/src/ipa/rkisp1/algorithms/dpf.h b/src/ipa/rkisp1/algorithms/dpf.h\nindex 4cbd7414..d6707d34 100644\n--- a/src/ipa/rkisp1/algorithms/dpf.h\n+++ b/src/ipa/rkisp1/algorithms/dpf.h\n@@ -79,6 +79,7 @@ private:\n \t\t\t\t\tuint32_t frame) override;\n \tvoid loadReductionModeConfig(IPAFrameContext &frameContext);\n \tvoid collectManualOverrides(const ControlList &controls) override;\n+\tbool checkOverridesChanged();\n \tbool parseConfig(const YamlObject &tuningData) override;\n \tbool parseSingleConfig(const YamlObject &tuningData,\n \t\t\t rkisp1_cif_isp_dpf_config &config,\n","prefixes":["v1","06/11"]}