{"id":25171,"url":"https://patchwork.libcamera.org/api/1.1/patches/25171/?format=json","web_url":"https://patchwork.libcamera.org/patch/25171/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20251125000848.4103786-5-rui.wang@ideasonboard.com>","date":"2025-11-25T00:08:41","name":"[v1,04/11] ipa: rkisp1: algorithms: Add reduction mode support to DPF","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"7ab78594edd4c504666fd0742e70283b124704ee","submitter":{"id":241,"url":"https://patchwork.libcamera.org/api/1.1/people/241/?format=json","name":"Rui Wang","email":"rui.wang@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/25171/mbox/","series":[{"id":5612,"url":"https://patchwork.libcamera.org/api/1.1/series/5612/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5612","date":"2025-11-25T00:08:37","name":"ipa: rkisp1: DPF refactor and tuning improvements","version":1,"mbox":"https://patchwork.libcamera.org/series/5612/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/25171/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/25171/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id F1C73C3257\n\tfor ;\n\tTue, 25 Nov 2025 00:09:13 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A27F260A9D;\n\tTue, 25 Nov 2025 01:09:13 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B80E7608CF\n\tfor ;\n\tTue, 25 Nov 2025 01:09:11 +0100 (CET)","from rui-Precision-7560.local (unknown\n\t[IPv6:2607:fea8:935b:7220:cb34:a7b8:53d:5466])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 959A61785;\n\tTue, 25 Nov 2025 01:07:02 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"W+FJpiLR\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1764029223;\n\tbh=cmhCEGrYfDDYOVEx/zoAkyOMTLK65P3DpKgjRdVMscc=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=W+FJpiLR5dYnB8tLYVxK9+De5DR0l7Qyhqzw0jxBsRqhhV2IDDn7aFSHVoGebbILw\n\tYdooedLP+p/+nKb3WQZQV9tFC/JgvwqRAZIcJpEBEBCYqSpIqd9/70iNvmCa7E5vIW\n\tnS6g4IMFGobL+phTI/d1QP3aqSFXdEL/xgXj1n64=","From":"Rui Wang ","To":"libcamera-devel@lists.libcamera.org","Cc":"Rui Wang ","Subject":"[PATCH v1 04/11] ipa: rkisp1: algorithms: Add reduction mode support\n\tto DPF","Date":"Mon, 24 Nov 2025 19:08:41 -0500","Message-ID":"<20251125000848.4103786-5-rui.wang@ideasonboard.com>","X-Mailer":"git-send-email 2.43.0","In-Reply-To":"<20251125000848.4103786-1-rui.wang@ideasonboard.com>","References":"<20251125000848.4103786-1-rui.wang@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"- Introduce DenoiseMode enum in DenoiseBaseAlgorithm with values: Auto, Manual, Reduction, Disabled\n- Add virtual getRunningMode() and setRunningMode() methods to the base class\n- Implement handleReductionModeControl() in Dpf class to process draft::NoiseReductionMode controls\n- Map control values to ReductionMode enum (Off, Minimal, HighQuality, Fast, ZSL)\n- Add currentReductionMode_ member to track the active reduction mode\n- Set running mode to controls::rkisp1::DenoiseModeReduction when reduction mode is engaged\n\nSigned-off-by: Rui Wang \n---\n src/ipa/rkisp1/algorithms/denoise.h | 10 ++++\n src/ipa/rkisp1/algorithms/dpf.cpp | 85 +++++++++++++++++++----------\n src/ipa/rkisp1/algorithms/dpf.h | 6 ++\n 3 files changed, 71 insertions(+), 30 deletions(-)","diff":"diff --git a/src/ipa/rkisp1/algorithms/denoise.h b/src/ipa/rkisp1/algorithms/denoise.h\nindex abd08cba..660f648b 100644\n--- a/src/ipa/rkisp1/algorithms/denoise.h\n+++ b/src/ipa/rkisp1/algorithms/denoise.h\n@@ -31,10 +31,20 @@ protected:\n \t{\n \t\treturn true;\n \t}\n+\tvirtual void handleReductionModeControl([[maybe_unused]] const ControlList &controls,\n+\t\t\t\t\t\t[[maybe_unused]] IPAFrameContext &frameContext,\n+\t\t\t\t\t\t[[maybe_unused]] IPAContext &context,\n+\t\t\t\t\t\t[[maybe_unused]] uint32_t frame)\n+\t{\n+\t}\n+\tvirtual int32_t getRunningMode() const { return currentRunMode_; }\n+\tvirtual void setRunningMode(int32_t mode) { currentRunMode_ = mode; }\n \n private:\n \t/**< Developer mode state for advanced controls */\n \tbool devMode_ = false;\n+\t/**< Current denoise running mode */\n+\tint32_t currentRunMode_ = controls::rkisp1::DenoiseModeDisabled;\n };\n \n inline unsigned DenoiseBaseAlgorithm::computeExposureIndex(const IPAContext &context,\ndiff --git a/src/ipa/rkisp1/algorithms/dpf.cpp b/src/ipa/rkisp1/algorithms/dpf.cpp\nindex dc0a361c..c006fb5c 100644\n--- a/src/ipa/rkisp1/algorithms/dpf.cpp\n+++ b/src/ipa/rkisp1/algorithms/dpf.cpp\n@@ -309,6 +309,55 @@ bool Dpf::parseSingleConfig(const YamlObject &tuningData,\n \treturn true;\n }\n \n+void Dpf::handleReductionModeControl(const ControlList &controls,\n+\t\t\t\t IPAFrameContext &frameContext,\n+\t\t\t\t IPAContext &context,\n+\t\t\t\t [[maybe_unused]] uint32_t frame)\n+{\n+\tauto &dpf = context.activeState.dpf;\n+\tconst auto &denoise = controls.get(controls::draft::NoiseReductionMode);\n+\tif (!denoise) {\n+\t\tframeContext.dpf.denoise = dpf.denoise;\n+\t\treturn;\n+\t}\n+\tLOG(RkISP1Dpf, Debug) << \"Set denoise mode to \" << *denoise;\n+\n+\tconst auto requestedMode = static_cast(*denoise);\n+\tif (requestedMode == currentReductionMode_) {\n+\t\tframeContext.dpf.denoise = dpf.denoise;\n+\t\treturn;\n+\t}\n+\n+\tcurrentReductionMode_ = requestedMode;\n+\tif (requestedMode == controls::draft::NoiseReductionModeOff) {\n+\t\tdpf.denoise = false;\n+\t\tframeContext.dpf.denoise = false;\n+\t\treturn;\n+\t}\n+\n+\tdpf.denoise = true;\n+\tframeContext.dpf.denoise = true;\n+\tframeContext.dpf.update = true;\n+}\n+void Dpf::loadReductionModeConfig(IPAFrameContext &frameContext)\n+{\n+\t/* Find mode config */\n+\tauto it = std::find_if(modes_.begin(), modes_.end(),\n+\t\t\t [this](const ModeConfig &mode) {\n+\t\t\t\t return mode.modeValue == currentReductionMode_;\n+\t\t\t });\n+\tif (it == modes_.end()) {\n+\t\tLOG(RkISP1Dpf, Warning)\n+\t\t\t<< \"No DPF config for reduction mode \"\n+\t\t\t<< static_cast(currentReductionMode_);\n+\t\treturn;\n+\t}\n+\n+\t/* Apply mode config */\n+\tconfig_ = it->dpf;\n+\tstrengthConfig_ = it->strength;\n+\tframeContext.dpf.update = true;\n+}\n /**\n * \\copydoc libcamera::ipa::Algorithm::queueRequest\n */\n@@ -317,38 +366,14 @@ void Dpf::queueRequest(IPAContext &context,\n \t\t IPAFrameContext &frameContext,\n \t\t const ControlList &controls)\n {\n-\tauto &dpf = context.activeState.dpf;\n-\tbool update = false;\n+\tframeContext.dpf.update = false;\n+\tauto currentRunnungMode = getRunningMode();\n+\thandleReductionModeControl(controls, frameContext, context, frame);\n \n-\tconst auto &denoise = controls.get(controls::draft::NoiseReductionMode);\n-\tif (denoise) {\n-\t\tLOG(RkISP1Dpf, Debug) << \"Set denoise to \" << *denoise;\n-\n-\t\tswitch (*denoise) {\n-\t\tcase controls::draft::NoiseReductionModeOff:\n-\t\t\tif (dpf.denoise) {\n-\t\t\t\tdpf.denoise = false;\n-\t\t\t\tupdate = true;\n-\t\t\t}\n-\t\t\tbreak;\n-\t\tcase controls::draft::NoiseReductionModeMinimal:\n-\t\tcase controls::draft::NoiseReductionModeHighQuality:\n-\t\tcase controls::draft::NoiseReductionModeFast:\n-\t\t\tif (!dpf.denoise) {\n-\t\t\t\tdpf.denoise = true;\n-\t\t\t\tupdate = true;\n-\t\t\t}\n-\t\t\tbreak;\n-\t\tdefault:\n-\t\t\tLOG(RkISP1Dpf, Error)\n-\t\t\t\t<< \"Unsupported denoise value \"\n-\t\t\t\t<< *denoise;\n-\t\t\tbreak;\n-\t\t}\n+\tif (currentRunnungMode == controls::rkisp1::DenoiseModeReduction && currentReductionMode_ != controls::draft::NoiseReductionModeOff) {\n+\t\tloadReductionModeConfig(frameContext);\n+\t\treturn;\n \t}\n-\n-\tframeContext.dpf.denoise = dpf.denoise;\n-\tframeContext.dpf.update = update;\n }\n \n /**\ndiff --git a/src/ipa/rkisp1/algorithms/dpf.h b/src/ipa/rkisp1/algorithms/dpf.h\nindex 8691932d..928e79d9 100644\n--- a/src/ipa/rkisp1/algorithms/dpf.h\n+++ b/src/ipa/rkisp1/algorithms/dpf.h\n@@ -49,7 +49,13 @@ private:\n \tstd::vector exposureIndexLevels_;\n \tstd::vector modes_;\n \tbool useExposureIndexLevels_ = false;\n+\tint32_t currentReductionMode_ = controls::draft::NoiseReductionModeOff;\n \n+\tvoid handleReductionModeControl(const ControlList &controls,\n+\t\t\t\t\tIPAFrameContext &frameContext,\n+\t\t\t\t\tIPAContext &context,\n+\t\t\t\t\tuint32_t frame) override;\n+\tvoid loadReductionModeConfig(IPAFrameContext &frameContext);\n \tbool parseConfig(const YamlObject &tuningData) override;\n \tbool parseSingleConfig(const YamlObject &tuningData,\n \t\t\t rkisp1_cif_isp_dpf_config &config,\n","prefixes":["v1","04/11"]}