{"id":25160,"url":"https://patchwork.libcamera.org/api/1.1/patches/25160/?format=json","web_url":"https://patchwork.libcamera.org/patch/25160/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20251124-cam-control-override-v1-1-dfc3a2f3feee@ideasonboard.com>","date":"2025-11-24T16:43:44","name":"[1/2] apps: cam: Do not override Request::controls()","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"7c0e37cae27bbfdf7dae31d8c575e70e00e8f688","submitter":{"id":143,"url":"https://patchwork.libcamera.org/api/1.1/people/143/?format=json","name":"Jacopo Mondi","email":"jacopo.mondi@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/25160/mbox/","series":[{"id":5609,"url":"https://patchwork.libcamera.org/api/1.1/series/5609/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5609","date":"2025-11-24T16:43:43","name":"libcamera: ipc: ControlLists without valid idmap break IPC","version":1,"mbox":"https://patchwork.libcamera.org/series/5609/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/25160/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/25160/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 6855AC32E0\n\tfor ;\n\tMon, 24 Nov 2025 16:44:07 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 24FA460AA3;\n\tMon, 24 Nov 2025 17:44:07 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 09FC2609D8\n\tfor ;\n\tMon, 24 Nov 2025 17:44:03 +0100 (CET)","from [192.168.0.172] (mob-5-90-137-64.net.vodafone.it\n\t[5.90.137.64])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 79E3A89A;\n\tMon, 24 Nov 2025 17:41:54 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"CWJJyPRf\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1764002514;\n\tbh=/jgi03kwOB2Diz1vMtFCxvsoo6nJ3veEckzUP+RsrR0=;\n\th=From:Date:Subject:References:In-Reply-To:To:Cc:From;\n\tb=CWJJyPRfl31aL2hmx+tepFymzAKjmx4PYq4/ghp6hAMVav2nlCynOVws1H8qq4B1Z\n\tvzAaUHIzBcSngQPGlISqopPlIg10soig5UDrYQ7DvTTn0Com7y/wB6qy41VeWSY6sZ\n\t4Nw8SA9ROpowfg6WDZyy2X1F9e6eWIZJBQzJz638=","From":"Jacopo Mondi ","Date":"Mon, 24 Nov 2025 17:43:44 +0100","Subject":"[PATCH 1/2] apps: cam: Do not override Request::controls()","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"7bit","Message-Id":"<20251124-cam-control-override-v1-1-dfc3a2f3feee@ideasonboard.com>","References":"<20251124-cam-control-override-v1-0-dfc3a2f3feee@ideasonboard.com>","In-Reply-To":"<20251124-cam-control-override-v1-0-dfc3a2f3feee@ideasonboard.com>","To":"libcamera-devel@lists.libcamera.org","Cc":"Jacopo Mondi ","X-Mailer":"b4 0.14.2","X-Developer-Signature":"v=1; a=openpgp-sha256; l=1338;\n\ti=jacopo.mondi@ideasonboard.com; h=from:subject:message-id;\n\tbh=/jgi03kwOB2Diz1vMtFCxvsoo6nJ3veEckzUP+RsrR0=;\n\tb=owEBbQKS/ZANAwAKAXI0Bo8WoVY8AcsmYgBpJItRAHPCKlwuxle5BLWndo+k5LywG1VSlwDdG\n\t9YFstf3wbSJAjMEAAEKAB0WIQS1xD1IgJogio9YOMByNAaPFqFWPAUCaSSLUQAKCRByNAaPFqFW\n\tPIU9D/sEzg+bvC3pp8ZfwmTDhKSFKruzsLin/DVE90B84U+Rqwy68RG2GAsdaqTII/DRGd6GIWX\n\toWrvwD8QRhfZZ6hlDmvsFuWHX/eV+8eK3orz40UHaHN1S79lDbS+3vuDIwMJLJq5nq+MEOX/8u0\n\t6OuiiuoXpU4UbB54JrVH6sAYp3fQvgMTVrU011I1qmfRt+pq1EcaxvREHfoyx60pfl7Hu3Ow9Mn\n\tHzEQ0VhW+HZeUr8zqtvNHIntodHwV9EFXKio6dfWJPphMXZWvcFitnfxJxJeS/5P/TzxpQXVPBS\n\tWM9SENeU7Fh+nRQYa4HR7ztvZzA0VqtUbgOq+mfm/cnbp80oy4Povt3OcU8odYbuHd7RVS6xjva\n\tPtZTK8y6+AKhgfEUgSElFWmncTe1a9BpPSwN5m/6EsCE4wpwHK7CJ0+qE+blY9T1QkSzC/ZN9Hc\n\tq38a9O0OLxMhyHzTNVr2YANpoZXqsGGgBgyoQSG8a9uckc2QsGoDzvuzLiSHmVcxHPbKdftONdF\n\tSI5WvY3ukJYHkQEtaZYw/R3pqCmbURxrEwbSYacv/hbq5YKrYYyb+FLWNuWq0wKFg0dKMzeGMT5\n\tP4TXPJezW8HUJQjM1gwBbwatGAWDy2cBMq1+B1+9pWRhdHDy/4bZ7GSV6DL63wpfltwJwA3nh8a\n\tpymIoDkNpQYELZQ==","X-Developer-Key":"i=jacopo.mondi@ideasonboard.com; a=openpgp;\n\tfpr=72392EDC88144A65C701EA9BA5826A2587AD026B","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The ControlList associated with a Request are created with\nthe libcamera::controls::controls id map.\n\nThe cam application, when parsing controls from a script\nassigns to the Request's control list a newly created one, which is\ninitialized without a valid idmap or info map.\n\nThis causes IPA that run in isolated mode to fail, as the IPC\nserialization/deserialization code requires all ControlList to have\na valid idmap or info map associated.\n\nInstead of overwriting the Request::controls() list, merge it with\nthe one created by cam when parsing the capture script.\n\nCloses: https://gitlab.freedesktop.org/camera/libcamera/-/issues/295\nSigned-off-by: Jacopo Mondi \n---\n src/apps/cam/camera_session.cpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)","diff":"diff --git a/src/apps/cam/camera_session.cpp b/src/apps/cam/camera_session.cpp\nindex 1596a25a3abed9c2d93e6657b92e35fdfd3d1a26..0a24b7fafc5333f88053cb52a500cdafd7bb603f 100644\n--- a/src/apps/cam/camera_session.cpp\n+++ b/src/apps/cam/camera_session.cpp\n@@ -447,7 +447,7 @@ int CameraSession::queueRequest(Request *request)\n \t\treturn 0;\n \n \tif (script_)\n-\t\trequest->controls() = script_->frameControls(queueCount_);\n+\t\trequest->controls().merge(script_->frameControls(queueCount_));\n \n \tqueueCount_++;\n \n","prefixes":["1/2"]}