{"id":2516,"url":"https://patchwork.libcamera.org/api/1.1/patches/2516/?format=json","web_url":"https://patchwork.libcamera.org/patch/2516/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20200106161417.19150-3-laurent.pinchart@ideasonboard.com>","date":"2020-01-06T16:14:15","name":"[libcamera-devel,2/4] v4l2: camera_proxy: Return correct type from VIDIOC_G_FMT","commit_ref":null,"pull_url":null,"state":"rejected","archived":false,"hash":"391a0a3a583a72303c2e8423c9732738f95d5865","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/1.1/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"delegate":{"id":14,"url":"https://patchwork.libcamera.org/api/1.1/users/14/?format=json","username":"pinchartl","first_name":"Laurent","last_name":"Pinchart","email":"laurent.pinchart@ideasonboard.com"},"mbox":"https://patchwork.libcamera.org/patch/2516/mbox/","series":[{"id":604,"url":"https://patchwork.libcamera.org/api/1.1/series/604/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=604","date":"2020-01-06T16:14:13","name":"v4l2: Miscellaneous improvements","version":1,"mbox":"https://patchwork.libcamera.org/series/604/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/2516/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/2516/checks/","tags":{},"headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A823E60463\n\tfor ;\n\tMon, 6 Jan 2020 17:14:31 +0100 (CET)","from pendragon.bb.dnainternet.fi (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 4870E52F;\n\tMon, 6 Jan 2020 17:14:31 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1578327271;\n\tbh=aVkREMBjCfFQ9bZNNQQ7PSwX1C8PJ4OR6HN2PishuO8=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=u4tpHCaMOIo0Us+/3ryCFhznxcpgO9tMApvDY0iTniom9sAGmNRlbj279GF8e7vAm\n\tgblPy6gzI8Jf19tUNF607Va18NxWRY3K555VE3QOTbiaaB+kmdTmlDChVdMtTUiWHa\n\t/Es6jU9gLhOHkJa1009XFYC7HyM039H1I/CYcLN0=","From":"Laurent Pinchart ","To":"libcamera-devel@lists.libcamera.org","Date":"Mon, 6 Jan 2020 18:14:15 +0200","Message-Id":"<20200106161417.19150-3-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.24.1","In-Reply-To":"<20200106161417.19150-1-laurent.pinchart@ideasonboard.com>","References":"<20200106161417.19150-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH 2/4] v4l2: camera_proxy: Return correct\n\ttype from VIDIOC_G_FMT","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Mon, 06 Jan 2020 16:14:31 -0000"},"content":"The VIDIOC_G_FMT implementation overwrites the v4l2_format type field\nwith 0. Fix it.\n\nSigned-off-by: Laurent Pinchart \n---\n src/v4l2/v4l2_camera_proxy.cpp | 1 +\n 1 file changed, 1 insertion(+)","diff":"diff --git a/src/v4l2/v4l2_camera_proxy.cpp b/src/v4l2/v4l2_camera_proxy.cpp\nindex 2eeb12396d90..dd3ee3e6c6ff 100644\n--- a/src/v4l2/v4l2_camera_proxy.cpp\n+++ b/src/v4l2/v4l2_camera_proxy.cpp\n@@ -229,6 +229,7 @@ int V4L2CameraProxy::vidioc_g_fmt(struct v4l2_format *arg)\n \t\treturn -EINVAL;\n \n \tmemset(&arg->fmt, 0, sizeof(arg->fmt));\n+\targ->type = V4L2_BUF_TYPE_VIDEO_CAPTURE;\n \targ->fmt.pix = curV4L2Format_.fmt.pix;\n \n \treturn 0;\n","prefixes":["libcamera-devel","2/4"]}