{"id":25142,"url":"https://patchwork.libcamera.org/api/1.1/patches/25142/?format=json","web_url":"https://patchwork.libcamera.org/patch/25142/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20251120233347.5046-19-bryan.odonoghue@linaro.org>","date":"2025-11-20T23:33:42","name":"[v4,18/23] ipa: Add a new Algorithm::init() to support self-initalising algorithms","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"4b2aa67f0f47febb4837278cc2ddf6b434724493","submitter":{"id":175,"url":"https://patchwork.libcamera.org/api/1.1/people/175/?format=json","name":"Bryan O'Donoghue","email":"bryan.odonoghue@linaro.org"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/25142/mbox/","series":[{"id":5600,"url":"https://patchwork.libcamera.org/api/1.1/series/5600/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5600","date":"2025-11-20T23:33:24","name":"Add GLES 2.0 GPUISP to libcamera","version":4,"mbox":"https://patchwork.libcamera.org/series/5600/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/25142/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/25142/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A9EB4BD80A\n\tfor ;\n\tThu, 20 Nov 2025 23:34:29 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5145860B30;\n\tFri, 21 Nov 2025 00:34:29 +0100 (CET)","from mail-wm1-x330.google.com (mail-wm1-x330.google.com\n\t[IPv6:2a00:1450:4864:20::330])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 19DF860AAB\n\tfor ;\n\tFri, 21 Nov 2025 00:34:26 +0100 (CET)","by mail-wm1-x330.google.com with SMTP id\n\t5b1f17b1804b1-47118259fd8so12449555e9.3\n\tfor ;\n\tThu, 20 Nov 2025 15:34:26 -0800 (PST)","from inspiron14p-linux.ht.home (188-141-3-146.dynamic.upc.ie.\n\t[188.141.3.146]) by smtp.gmail.com with ESMTPSA id\n\tffacd0b85a97d-42cb7fa3a81sm7984139f8f.26.2025.11.20.15.34.24\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tThu, 20 Nov 2025 15:34:24 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"HYuTH9RO\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=linaro.org; s=google; t=1763681665; x=1764286465;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=16pZ/JdoiYUGtAtk/R99scAohK2wEjdJ1P32w9Duc1Y=;\n\tb=HYuTH9ROZRxk52UhAZTMckRfGkePe72EfHEn1Shyc7Sa9fotaAZthzRv0KEFZkaZ3e\n\tChECImeLI6Gnkq7FAhVuJt1AUcQI/D5qqcUXM6SW1yCFs7/BSNlyPrCStXXzWRqkMbvJ\n\t2tqiA3yLAp+ykM26SHO+f4nU+SRNYbN9gsRK1+L3NTcar5bh2xrRIOaOW5F8ueyit42G\n\tjeK74xY11YvQl/hcyH9SSUY60Of3oYxbzQHwkwytngyrg/kldtkWWN2aYu5YMXCx017N\n\t3Qq+RS1fKoLCJ9hW6ZXeTXLye6veNhO73eoFrngX+x4bN+MS7bcUAGV2fhOW8k0qixrY\n\tjHqQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1763681665; x=1764286465;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n\t:to:cc:subject:date:message-id:reply-to;\n\tbh=16pZ/JdoiYUGtAtk/R99scAohK2wEjdJ1P32w9Duc1Y=;\n\tb=RvBCnWJ/KHLEZOpdiPft+Hzks80Z6+82KWV9EBWOnlJ3ZrNHHXl1RSUx0HmiiBn/dG\n\tAzLQdL8VceO0roO/f7mFU7qMdj9OXDDl5ANEaR/jLjBBBSkM4vxTu4puNQ58DOtWO8nV\n\tHtpMQFioKudYcTQKF7rxhxrKnKVnp3NV7wLXuSrsNlzg4OtjZb+p/lIDiZzS13iZauoD\n\tAxGgE6BYGW98g6ZsEdU0jxKdu9gmtTh8PVSufxO8t9+rl42ImkKfu4DwB/Ng92G0fz1m\n\thPeQjPFB+O9X8wzW9RTM9FZt/QukG9XQCCsZ7I1kDOm9Yc3zbGTo7Y0Q3EaTDSUZe3TU\n\twFSg==","X-Gm-Message-State":"AOJu0YzE3u/3HybtHYY3Xjtr0X9HhkuNkoHBS/sPod1wC+qs5q1MRnyK\n\tUsQeOGRAH85lkDZCWSjSjRDTllqldM68xJoNCYEtkNctIcB1fB/vNoGl38Nt/pZXlBZi6WQqQFy\n\tzLIHa3V4=","X-Gm-Gg":"ASbGnctuW7j5ww1k8s8NC8GedDiLDluy8Od2tjKcGrwgRa6EnBL5DZXwewQy3FUmrt7\n\tGVBFoHMiQq/qf635x9M+Cwn9mpqWHU2LEtNEKrfNRQcXP9/uIFzYyhu1UOg+mnub24tbA26UuE2\n\tnYLCZ5Z9m2BgEk+Vjl2chZ+LRCHjrs16fgNV7APpFNaZxunmtXm8Cwxu2KAHAXIB29+YADYGRih\n\tZHzDIQTT3IB61eawTj99HzQI4csFxYeGIJ8LaxF6AgUJL1vwQEsdlkFawjUQneftQV+05yp9u+Y\n\tBu2whLuVy5ro0Atjm75lspQwdWq+twCcXkeUDfamOCy8aFvz6nRml9US5SzQ3Nr19aUk/E9gsX9\n\tbqAXEJmp6+JHbN/qXRGQAvS9Rk6sW88N1VCtwBYvpLWCTcPbATX/EcjiT3frz5mG6Qhnn817266\n\tSyg9Nwj3lDdUoNTm5fxQLeTszw9t2DczlufovVTvEp2LQB9VQhir0+TOAsOf6yWu8pjKM=","X-Google-Smtp-Source":"AGHT+IEdl30USogqQJSCxFyuRgbIhrtp1NYuu50AEr+QIbOv48iKxFdSCfST8lfTP93VpiucxLMLcA==","X-Received":"by 2002:a05:600c:3115:b0:477:b48d:ba7a with SMTP id\n\t5b1f17b1804b1-477c01fd202mr2764685e9.32.1763681665351; \n\tThu, 20 Nov 2025 15:34:25 -0800 (PST)","From":"Bryan O'Donoghue ","To":"libcamera-devel@lists.libcamera.org","Cc":"pavel@ucw.cz,\n\tBryan O'Donoghue ","Subject":"[PATCH v4 18/23] ipa: Add a new Algorithm::init() to support\n\tself-initalising algorithms","Date":"Thu, 20 Nov 2025 23:33:42 +0000","Message-ID":"<20251120233347.5046-19-bryan.odonoghue@linaro.org>","X-Mailer":"git-send-email 2.51.2","In-Reply-To":"<20251120233347.5046-1-bryan.odonoghue@linaro.org>","References":"<20251120233347.5046-1-bryan.odonoghue@linaro.org>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Add in an algorithm init() routine which can be called in the absence of a\nYaml input. Do this to allow an algorithm to set up a default set of\nparameters.\n\nSigned-off-by: Bryan O'Donoghue \n---\n src/ipa/libipa/algorithm.cpp | 13 ++++++++++++-\n src/ipa/libipa/algorithm.h | 5 +++++\n 2 files changed, 17 insertions(+), 1 deletion(-)","diff":"diff --git a/src/ipa/libipa/algorithm.cpp b/src/ipa/libipa/algorithm.cpp\nindex 201efdfdb..da44c77ca 100644\n--- a/src/ipa/libipa/algorithm.cpp\n+++ b/src/ipa/libipa/algorithm.cpp\n@@ -38,7 +38,7 @@ namespace ipa {\n */\n \n /**\n- * \\fn Algorithm::init()\n+ * \\fn Algorithm::init(typename Module::Context &context, const YamlObject &tuningData)\n * \\brief Initialize the Algorithm with tuning data\n * \\param[in] context The shared IPA context\n * \\param[in] tuningData The tuning data for the algorithm\n@@ -50,6 +50,17 @@ namespace ipa {\n * \\return 0 if successful, an error code otherwise\n */\n \n+/**\n+ * \\fn Algorithm::init(typename Module::Context &context)\n+ * \\brief Initialize the algorithm with default parameters\n+ *\n+ * This method is called when no tuning data is available. The algorithm\n+ * should initialize with sensible default values.\n+ *\n+ * \\param context The IPA context containing algorithm state\n+ * \\return 0 on success, negative error code on failure\n+ */\n+\n /**\n * \\fn Algorithm::configure()\n * \\brief Configure the Algorithm given an IPAConfigInfo\ndiff --git a/src/ipa/libipa/algorithm.h b/src/ipa/libipa/algorithm.h\nindex 9a19dbd61..9fcbe23a9 100644\n--- a/src/ipa/libipa/algorithm.h\n+++ b/src/ipa/libipa/algorithm.h\n@@ -32,6 +32,11 @@ public:\n \t\treturn 0;\n \t}\n \n+\tvirtual int init([[maybe_unused]] typename Module::Context &context)\n+\t{\n+\t\treturn 0;\n+\t}\n+\n \tvirtual int configure([[maybe_unused]] typename Module::Context &context,\n \t\t\t [[maybe_unused]] const typename Module::Config &configInfo)\n \t{\n","prefixes":["v4","18/23"]}