{"id":25140,"url":"https://patchwork.libcamera.org/api/1.1/patches/25140/?format=json","web_url":"https://patchwork.libcamera.org/patch/25140/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20251120233347.5046-17-bryan.odonoghue@linaro.org>","date":"2025-11-20T23:33:40","name":"[v4,16/23] libcamera: software_isp: Add a gpuisp todo list","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"f01a647225d31b1e58537e0a907e0236cc568a95","submitter":{"id":175,"url":"https://patchwork.libcamera.org/api/1.1/people/175/?format=json","name":"Bryan O'Donoghue","email":"bryan.odonoghue@linaro.org"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/25140/mbox/","series":[{"id":5600,"url":"https://patchwork.libcamera.org/api/1.1/series/5600/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5600","date":"2025-11-20T23:33:24","name":"Add GLES 2.0 GPUISP to libcamera","version":4,"mbox":"https://patchwork.libcamera.org/series/5600/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/25140/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/25140/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 9C110BD80A\n\tfor ;\n\tThu, 20 Nov 2025 23:34:25 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 52CA260ABD;\n\tFri, 21 Nov 2025 00:34:25 +0100 (CET)","from mail-wr1-x436.google.com (mail-wr1-x436.google.com\n\t[IPv6:2a00:1450:4864:20::436])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3B18E60AC8\n\tfor ;\n\tFri, 21 Nov 2025 00:34:23 +0100 (CET)","by mail-wr1-x436.google.com with SMTP id\n\tffacd0b85a97d-42b32900c8bso864615f8f.0\n\tfor ;\n\tThu, 20 Nov 2025 15:34:23 -0800 (PST)","from inspiron14p-linux.ht.home (188-141-3-146.dynamic.upc.ie.\n\t[188.141.3.146]) by smtp.gmail.com with ESMTPSA id\n\tffacd0b85a97d-42cb7fa3a81sm7984139f8f.26.2025.11.20.15.34.20\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tThu, 20 Nov 2025 15:34:21 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"CqnKy3nW\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=linaro.org; s=google; t=1763681662; x=1764286462;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=wNqHKfrdqEnCd6e0vklefM1kTOpuhhmzodWah3Zo3gc=;\n\tb=CqnKy3nWwYwaUhj3zsRDEw6nyIp5iJ6dDwxpN47JKFSsCcXzuyqdfWj2FYJpAA5m1m\n\tRmQQ4HYmdrF4dhPeyOwq3Ff1oWCH53AXHLlba4A0FfLXqb9JLyPCYq/zkk0lwW4Gc8L3\n\tgpvkrlqkuwFUPtn7llyvKC5lbD6oeBscAx3l9jgeVXBkKOp4ucqXHVGqYMshvTLVwmWD\n\tDWr/osD4/5NSUsUTYJYgJB0+pHFd5N3rYzTIgdM4Yf3jJX+YunW3r6NwxZ+z9YiVqL4u\n\tqv+clywr1AtMPTNGoJ1lMYvQ8YgE4M5S4LV5J5CI7wj25UUk2jBuhSWhl3k/JDJ+TKuU\n\tIQLA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1763681662; x=1764286462;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n\t:to:cc:subject:date:message-id:reply-to;\n\tbh=wNqHKfrdqEnCd6e0vklefM1kTOpuhhmzodWah3Zo3gc=;\n\tb=MsnnOiIjJlRma1J8p75yqusquIhNYu9J0UrVqdzb5F0Frg5VOqekjdpcDAUMkHYPBL\n\t4nESSWoCTcc4vKu8rqtgmzIs6c3CupfFhbVuS/cQpcV96OmXiOtzkQ72smR0U1Sf3QUK\n\tWlw+ji8LpktDRKbBR8QL+lIhs40Oip4EvO4SuYHJFatkNVfLGfxIBRFPokWadtv0ROIk\n\tdkOAZ42DmIMsN7KvDewEcrinu2BKWUoVYNCz4HmcGlcLfmcLen6d9L1xzsAjD766kxVN\n\tHsT8KZqtBtgj4nANr9BN5Zb/UoDuTUeVVahyvmUk6QfDcXmx/F/Vfgg4qu1gEK47Y5ml\n\thiaw==","X-Gm-Message-State":"AOJu0YxLYs5LSCs1FVagKol/+LIuRbEvubibWnEestWntVBeCGNQ1vzh\n\tAdVnW5CEaZURcRCj4oPpxgR6RBJ+u9hghKrfkbKBz6N/mP9n9IaCP/Iauq0H4F7sMH7Ke2+sspx\n\tg4wm8V5k=","X-Gm-Gg":"ASbGncsgn5ZxQIWYxg01k53Aqk7+MmkWLtev81BXfvUeKj51iE7O5fEMfNjgdm8Av9E\n\tvuSdgM+DzuQQ+eVGmDmB8C19jTs4QxJtJ8iAKeNfPWwRzyqdALJwI9WJbhTf1UFoPbyxLglfpui\n\tXDpAXzOKjgXxrurrLHGP1YLK4QAoVP6SyTw5+C36bsysN6pvi+fKklPIoEJn5JGKofurhMzA8Ey\n\tZ2gKAln83r2Xqeh/+QhtSZZyTjDxqX9XW34rH7jmCgYWFBi+zVHAPsNUk4kbC/1lCY8BG02kZo5\n\tvBq+aZmTVyGm/1I/t27NXmWXdiUeebyngvdinQx7ZkD4NhiTJhZH8/wOQkbBLrc/7pItqJ1cjza\n\t3HK6j0WeEkg0oLADiDQbvNZF+cNIJUWF15ulCPIBK5LHQSCNsgg9iZrtiexlSnEa+3dtTqjVg2I\n\tInvQb31ANoXI8GyAg7McysLh1m9b7h+eSG7qQbujFQkbKbHvcSJTT6C6RmNcWqquyC1ng=","X-Google-Smtp-Source":"AGHT+IEmPtujz+inUvV9REl0YbdLSmwuUj/KiK1njySFp2i+qVnTqISaODHpTwM+UouG0/IA6Uk51w==","X-Received":"by 2002:a05:6000:400f:b0:42b:3c3e:5d53 with SMTP id\n\tffacd0b85a97d-42cc1cedbf7mr78922f8f.16.1763681662475; \n\tThu, 20 Nov 2025 15:34:22 -0800 (PST)","From":"Bryan O'Donoghue ","To":"libcamera-devel@lists.libcamera.org","Cc":"pavel@ucw.cz, Bryan O'Donoghue ,\n\tKieran Bingham ","Subject":"[PATCH v4 16/23] libcamera: software_isp: Add a gpuisp todo list","Date":"Thu, 20 Nov 2025 23:33:40 +0000","Message-ID":"<20251120233347.5046-17-bryan.odonoghue@linaro.org>","X-Mailer":"git-send-email 2.51.2","In-Reply-To":"<20251120233347.5046-1-bryan.odonoghue@linaro.org>","References":"<20251120233347.5046-1-bryan.odonoghue@linaro.org>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"List the series of things to do in GPU ISP in perceived order of\ndifficulty.\n\nAcked-by: Kieran Bingham \nSigned-off-by: Bryan O'Donoghue \n---\n src/libcamera/software_isp/gpuisp-todo.txt | 83 ++++++++++++++++++++++\n 1 file changed, 83 insertions(+)\n create mode 100644 src/libcamera/software_isp/gpuisp-todo.txt","diff":"diff --git a/src/libcamera/software_isp/gpuisp-todo.txt b/src/libcamera/software_isp/gpuisp-todo.txt\nnew file mode 100644\nindex 000000000..768dcc320\n--- /dev/null\n+++ b/src/libcamera/software_isp/gpuisp-todo.txt\n@@ -0,0 +1,83 @@\n+List the TODOs in perceived order of ease.\n+\n+Version 3:\n+Use dma-buf handle to generate upload texture:\n+\t- eglCreateImageKHR can be used to generate the upload texture i.e.\n+\t to feed the bayer data into the GPU.\n+\n+Denoising:\n+\t- As below still TBD\n+\n+Dead pixel correction:\n+\t- As below still TBD\n+\n+Lense shading correction:\n+\t- This is WIP but as yet still TBD\n+\n+Lense flare correction:\n+\t- Not WIP still TBD\n+\n+processFrame() to run in its own thread:\n+\t- processFrame() runs in the context of the Debayer::process()\n+\t thread. Robert Mader suggested and it seems like a good\n+\t suggestion too to run processFrame() in its own thread.\n+\n+Version 2:\n+Make GPUISP default:\n+\t- Right now the environment variable allows over-riding to swtich\n+\t from CPU to GPU.\n+\t- Once we support 24 BPP output on GPUISP we will have the same\n+\t pixel format support as CPU and can set the default to GPU without\n+\t regressing functionality\n+\n+glTexture1D:\n+\t- Initial code was developed for < GLES 2.O but since we have fixed\n+\t on GLES >= 2.0 this means we can use glTexture1D\n+\t- Provided this is so amend the shaders to do val = texture(x, y, 0);\n+\t not texture(x, y, 0.5) the 0.5 is because of using glTexture2D\n+\n+Denoising:\n+\t- Run a denoise algorithm in the shaders\n+\t- Supply a control to influence the noise-floor ?\n+\n+Dead pixel correction:\n+\t- Add logic to correct dead pixels in the fragment shaders\n+\n+Version 1:\n+24 bit output support:\n+\t- Take the BPP we already capture and get a 24 bit GBM surface\n+\t- Pass a compile-time parameter to the shaders to tell them to do\n+\t gl_FragColor = rgb not gl_FragColor = rgba\n+\t- Version 2:\n+\t This is not possible.\n+\t gl_FragColor expects vec4 not vec3 on the output.\n+\t If you really want RGB888 run cpuisp.\n+\n+Surfaceless GBM:\n+\t- We get a GBM surface and then have to swap buffers\n+\t If we rework for surfaceless GBM and EGL then the swap buffer can\n+\t be dropped.\n+\t- Version 2:\n+\t Complete GBM surface removed, memcpy() phase removed also\n+\n+dma-buf texture upload:\n+\t- Currently we pass the input buffer to glCreateTexture2D.\n+\t We should be able to make the upload of the input buffer go faster\n+\t by using eglCreateImageKHR and enumerated the dma-buf contents.\n+\t- Version 2:\n+\t Complete sm8250 test platform shows 20x performance increase\n+\t with CCM.\n+\n+Render-to-texture:\n+\t- Right now we render to the GBM provided surface framebuffer\n+\t and then memcpy from that buffer to the target output buffer.\n+\t This necessitates flushing the cache on the target buffer in\n+\t addition to the memcpy().\n+\t- Render-to-texture where we generate the target framebuffer\n+\t directly from a dma-buf handle will mitigate the memcpy() phase.\n+\t- It should be the case then that the consumer of the output buffer\n+\t i.e. the thing that's not libcamera is responsible to flush the cache\n+\t if-and-only-if that user writes to the buffer.\n+\t- We need to flush the cache on the buffer because we are memcpying() to it.\n+\t- Version 2:\n+\t Done in version 2\n","prefixes":["v4","16/23"]}