{"id":2513,"url":"https://patchwork.libcamera.org/api/1.1/patches/2513/?format=json","web_url":"https://patchwork.libcamera.org/patch/2513/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20200104060031.17140-1-laurent.pinchart@ideasonboard.com>","date":"2020-01-04T06:00:31","name":"[libcamera-devel] libcamera: control_serializer: Initialize serial_","commit_ref":"618b5512a8113bcc785ff57afaf7c77e6c489f3b","pull_url":null,"state":"accepted","archived":false,"hash":"2239a80efb8e7e7fd6c20b8666b32825f8cba3fa","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/1.1/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/2513/mbox/","series":[{"id":603,"url":"https://patchwork.libcamera.org/api/1.1/series/603/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=603","date":"2020-01-04T06:00:31","name":"[libcamera-devel] libcamera: control_serializer: Initialize serial_","version":1,"mbox":"https://patchwork.libcamera.org/series/603/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/2513/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/2513/checks/","tags":{},"headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 85DD960461\n\tfor ;\n\tSat, 4 Jan 2020 07:00:46 +0100 (CET)","from pendragon.bb.dnainternet.fi (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 022C1A49\n\tfor ;\n\tSat, 4 Jan 2020 07:00:45 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1578117646;\n\tbh=FyalGOSqD/0Ddg2IVA1FHmOG4H3+KApUKAambj0u6wE=;\n\th=From:To:Subject:Date:From;\n\tb=TGLDs15MyUh0G02gIYP7fWWP2Ab0YIkvbGxVnByf6EJPymxBoSZQiD8cpl7W26oDY\n\toGSgYJmOKyc9i2oT6Y2VOpXFPrqk2jwx/kZ1qBZpN+ZKxZfuSzpvUx89Kqx4pGtaR1\n\t3RHCAt4+lgcDHco71ZF5s6Ypt5VPDyINyTgqiBeM=","From":"Laurent Pinchart ","To":"libcamera-devel@lists.libcamera.org","Date":"Sat, 4 Jan 2020 08:00:31 +0200","Message-Id":"<20200104060031.17140-1-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.24.1","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH] libcamera: control_serializer: Initialize\n\tserial_","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Sat, 04 Jan 2020 06:00:46 -0000"},"content":"The ControlSerializer::serial_ member variable isn't initialized. Add a\nconstructor to the class to initialize it.\n\nSigned-off-by: Laurent Pinchart \n---\n src/libcamera/control_serializer.cpp | 5 +++++\n src/libcamera/include/control_serializer.h | 2 ++\n 2 files changed, 7 insertions(+)","diff":"diff --git a/src/libcamera/control_serializer.cpp b/src/libcamera/control_serializer.cpp\nindex b787655e6769..a5d6d875c76f 100644\n--- a/src/libcamera/control_serializer.cpp\n+++ b/src/libcamera/control_serializer.cpp\n@@ -84,6 +84,11 @@ static constexpr size_t ControlValueSize[] = {\n * proceed with care to avoid stale references.\n */\n \n+ControlSerializer::ControlSerializer()\n+\t: serial_(0)\n+{\n+}\n+\n /**\n * \\brief Reset the serializer\n *\ndiff --git a/src/libcamera/include/control_serializer.h b/src/libcamera/include/control_serializer.h\nindex bb3cb8e7b904..55259913a2ca 100644\n--- a/src/libcamera/include/control_serializer.h\n+++ b/src/libcamera/include/control_serializer.h\n@@ -20,6 +20,8 @@ class ByteStreamBuffer;\n class ControlSerializer\n {\n public:\n+\tControlSerializer();\n+\n \tvoid reset();\n \n \tstatic size_t binarySize(const ControlInfoMap &info);\n","prefixes":["libcamera-devel"]}