{"id":25125,"url":"https://patchwork.libcamera.org/api/1.1/patches/25125/?format=json","web_url":"https://patchwork.libcamera.org/patch/25125/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20251120233347.5046-2-bryan.odonoghue@linaro.org>","date":"2025-11-20T23:33:25","name":"[v4,01/23] libcamera: software_isp: gbm: Add a GBM helper class for GPU surface access","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"1a501f170b49a21b6ee44850db635167182a6665","submitter":{"id":175,"url":"https://patchwork.libcamera.org/api/1.1/people/175/?format=json","name":"Bryan O'Donoghue","email":"bryan.odonoghue@linaro.org"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/25125/mbox/","series":[{"id":5600,"url":"https://patchwork.libcamera.org/api/1.1/series/5600/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5600","date":"2025-11-20T23:33:24","name":"Add GLES 2.0 GPUISP to libcamera","version":4,"mbox":"https://patchwork.libcamera.org/series/5600/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/25125/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/25125/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 9F459BD80A\n\tfor ;\n\tThu, 20 Nov 2025 23:33:57 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 6BC4960A86;\n\tFri, 21 Nov 2025 00:33:57 +0100 (CET)","from mail-wm1-x329.google.com (mail-wm1-x329.google.com\n\t[IPv6:2a00:1450:4864:20::329])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A71EF606A0\n\tfor ;\n\tFri, 21 Nov 2025 00:33:55 +0100 (CET)","by mail-wm1-x329.google.com with SMTP id\n\t5b1f17b1804b1-4775e891b5eso6648935e9.2\n\tfor ;\n\tThu, 20 Nov 2025 15:33:55 -0800 (PST)","from inspiron14p-linux.ht.home (188-141-3-146.dynamic.upc.ie.\n\t[188.141.3.146]) by smtp.gmail.com with ESMTPSA id\n\tffacd0b85a97d-42cb7fa3a81sm7984139f8f.26.2025.11.20.15.33.52\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tThu, 20 Nov 2025 15:33:53 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"A7Ws+7lz\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=linaro.org; s=google; t=1763681635; x=1764286435;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=iucmzPJRyyFFPoxeUBz8sxRzHoEk6MZ17eyAcHe13fo=;\n\tb=A7Ws+7lz6a/vOyISpy2QZv2HJ49Rb/l5csw4/9lnmnjYXJA2ncWhmyeq8kpgjlOZqD\n\tJw0jn4970bjZC83OyEIczHpvYnQxUlUI28ZvWIFLe06pR2pByLjq2Qx6hJTtqeDtUprH\n\tKatteMbdSDgrfuI/4dCsXcWqTxgJeGLnlebI4cslx55QaNPcPNzoyjRG2mxt5VJDpLMu\n\teqtBo7+C0yZiGMDlUbKE0Z82Vf8RGW+9ujtuySf3oU9eSobt5MyYX3ESbHteCzEmLc+d\n\tJhw5sxHk7BHtouh1imgVqX1Eic8Z2cizMcvzGphm+8s2PM3Vn5CFA5zg0mbamfYKMOBc\n\t16lw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1763681635; x=1764286435;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n\t:to:cc:subject:date:message-id:reply-to;\n\tbh=iucmzPJRyyFFPoxeUBz8sxRzHoEk6MZ17eyAcHe13fo=;\n\tb=sVi/YO/Rjog60Fi89OGuo666eNgYfDQRy2WGGdi6o7lWlW8iTwWHJgANIIJTF2T01t\n\t41GO4zzYKmDIkGrZkl9T/n7S3koCRLkKhIYaSphVoe0P/Pg3EJOT5X5pYYsxP0TzsTLT\n\tS2XWJ6e7kSSolLrtKu8aiM5iHchVHNzgbwxtL2exH8uLaNw3oHDAOOVe7vW20vwcjlnS\n\tP3+y0ICjRSbtTs7H+wRBS6o3ILlkU/ZeC5CcxXWil0ezcZUPzDZcx1IgsNuc9Ygz7Elh\n\tGdhb2S2yYgQ4xfNkMOB+jyvGON/VLUb48CIoE6lVO0jATMB7RAXps8hIYbDVqejNOV26\n\tysgQ==","X-Gm-Message-State":"AOJu0YyJ7VW8CeM8hAefeC1lLNd58s4HSdpiV7YqmRSRjeatuOPBccFa\n\tJyXlHsvbuHMhl7dTUNllJ9LFljawpxZn/KbULsakieToxxkBVsvbc+xNhQyt+MoCp7cnlz78Vs6\n\tUva5SgNY=","X-Gm-Gg":"ASbGnct1wy1Vl5/9pbzzwYcut2cb/e5FMdHg7uA6UVWjpCpE/AF+6go62CSB72749DV\n\tEp5xkANczYu9j+tKG9X8Ezl4FZNe1HCBS9jWRuOdr4d3xs8yqIOvTdqnApvWxeRjuaOjN5D+IIx\n\thwCcDDxXqVKrSbBLmyconUJD9jEqds7vsuv1Q/6F3JCL0AC+k680D/+JQ9PWtJhw6AiHF9Cjl37\n\tkPSz4XjS6dCnLED57knr1WXCWOkonoiq2sZf+LejluGJlvYPU6hCbhNnSWuUuqhV9l8zeYSeRsi\n\tZZLH1+ZxUkyf57F18m0ewoPanVyJRT2Q2FpUpiTdvLY+cS1+wn1hCQBSa3y3tWf/hIu8/JW8uBk\n\tuuqlP3q80QxckvNiekk9geQ1fJGQxASbGCOLAyBXJXeDgsPA/dAfTYthcT5T+qbtWFFNZ3Fx13a\n\teF6ymLNaMqfehR1JOn+O7T/9wY4HcEXrlI3kTVbAVX1GXeaz2s5hqxgrZs3UNl4cQqD41QPWv0K\n\tPIOBQ==","X-Google-Smtp-Source":"AGHT+IGTjWV6hXGyzKVwyiIRM0X5EfxOZv+NuPQ3cTbMfZ65g9VNhW1w13Q1e0v6kRfyIBNVm93GGA==","X-Received":"by 2002:a05:600c:4e87:b0:46d:a04:50c6 with SMTP id\n\t5b1f17b1804b1-477c01ebc76mr3292465e9.30.1763681635017; \n\tThu, 20 Nov 2025 15:33:55 -0800 (PST)","From":"Bryan O'Donoghue ","To":"libcamera-devel@lists.libcamera.org","Cc":"pavel@ucw.cz, Bryan O'Donoghue ,\n\tKieran Bingham ","Subject":"[PATCH v4 01/23] libcamera: software_isp: gbm: Add a GBM helper\n\tclass for GPU surface access","Date":"Thu, 20 Nov 2025 23:33:25 +0000","Message-ID":"<20251120233347.5046-2-bryan.odonoghue@linaro.org>","X-Mailer":"git-send-email 2.51.2","In-Reply-To":"<20251120233347.5046-1-bryan.odonoghue@linaro.org>","References":"<20251120233347.5046-1-bryan.odonoghue@linaro.org>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"A helper class to interact with GBM. This will allow us to specify the\ninternal storage format of the GPU when making a texture for the Debayer\nvertex/fragment shaders and thus ensure we receive an uncompressed and\nuntiled output buffer.\n\nAcked-by: Kieran Bingham \nSigned-off-by: Bryan O'Donoghue \n---\n include/libcamera/internal/gbm.h | 84 ++++++++++++++++++++++++++\n include/libcamera/internal/meson.build | 1 +\n src/libcamera/gbm.cpp | 61 +++++++++++++++++++\n src/libcamera/meson.build | 11 ++++\n 4 files changed, 157 insertions(+)\n create mode 100644 include/libcamera/internal/gbm.h\n create mode 100644 src/libcamera/gbm.cpp","diff":"diff --git a/include/libcamera/internal/gbm.h b/include/libcamera/internal/gbm.h\nnew file mode 100644\nindex 000000000..8a908ddc8\n--- /dev/null\n+++ b/include/libcamera/internal/gbm.h\n@@ -0,0 +1,84 @@\n+/* SPDX-License-Identifier: LGPL-2.1-or-later */\n+/*\n+ * Copyright (C) 2024, Linaro Ltd.\n+ *\n+ * Authors:\n+ * Bryan O'Donoghue \n+ *\n+ * gbm.h - Helper class for managing GBM interactions.\n+ */\n+\n+#pragma once\n+\n+#include \n+\n+#include \n+\n+#include \n+\n+namespace libcamera {\n+\n+LOG_DECLARE_CATEGORY(GBM)\n+\n+/**\n+ * \\brief Helper class for managing GBM interactions\n+ *\n+ * The GBM class provides a simplified interface for creating and managing\n+ * GBM devices. It handles the initialization and teardown of GBM devices\n+ * used for buffer allocation in graphics and camera pipelines.\n+ *\n+ * This class is responsible for opening a DRI render node, creating a GBM\n+ * device, and providing access to the device and its associated pixel format.\n+ */\n+class GBM\n+{\n+public:\n+\t/**\n+\t *\\brief GBM constructor.\n+\t *\n+\t * Creates a GBM instance with unitialised state.\n+\t */\n+\tGBM();\n+\n+\t/**\n+\t *\\brief GBM destructor\n+\t *\n+\t * Cleans up the GBM device if it was successfully created, and closes\n+\t * the associated file descriptor.\n+\t */\n+\t~GBM();\n+\n+\t/**\n+\t * \\brief Create and initialize a GBM device\n+\t *\n+\t * Opens the DRI render node (/dev/dri/renderD128) and creates a GBM\n+\t * device using the libgbm library. Sets the default pixel format to\n+\t * ARGB8888.\n+\t *\n+\t * \\return 0 on success, or a negative error code on failure\n+\t */\n+\tint createDevice();\n+\n+\n+\t/**\n+\t * \\brief Retrieve the GBM device handle\n+\t *\n+\t * \\return Pointer to the gbm_device structure, or nullptr if the device\n+\t * has not been created\n+\t */\n+\tstruct gbm_device *getDevice() { return gbm_device_; }\n+\n+\t/**\n+\t * \\brief Retrieve the pixel format\n+\t *\n+\t * \\return The PixelFormat used by this GBM instance (ARGB8888)\n+\t */\n+\tPixelFormat getPixelFormat() { return format_; }\n+\n+private:\n+\tint fd_;\n+\tstruct gbm_device *gbm_device_;\n+\tPixelFormat format_;\n+};\n+\n+} // namespace libcamera\ndiff --git a/include/libcamera/internal/meson.build b/include/libcamera/internal/meson.build\nindex ecb7c9fa8..01a365955 100644\n--- a/include/libcamera/internal/meson.build\n+++ b/include/libcamera/internal/meson.build\n@@ -24,6 +24,7 @@ libcamera_internal_headers = files([\n 'dma_buf_allocator.h',\n 'formats.h',\n 'framebuffer.h',\n+ 'gbm.h',\n 'global_configuration.h',\n 'ipa_data_serializer.h',\n 'ipa_manager.h',\ndiff --git a/src/libcamera/gbm.cpp b/src/libcamera/gbm.cpp\nnew file mode 100644\nindex 000000000..fa15b709a\n--- /dev/null\n+++ b/src/libcamera/gbm.cpp\n@@ -0,0 +1,61 @@\n+/* SPDX-License-Identifier: LGPL-2.1-or-later */\n+/*\n+ * Copyright (C) 2024, Linaro Ltd.\n+ *\n+ * Authors:\n+ * Bryan O'Donoghue \n+ *\n+ * egl.cpp - Helper class for managing GBM interactions.\n+ */\n+\n+#include \"libcamera/internal/gbm.h\"\n+\n+#include \n+#include \n+#include \n+#include \n+#include \n+\n+#include \n+#include \n+\n+namespace libcamera {\n+\n+LOG_DEFINE_CATEGORY(GBM)\n+\n+GBM::GBM()\n+{\n+\tfd_ = 0;\n+\tgbm_device_ = NULL;\n+}\n+\n+GBM::~GBM()\n+{\n+\tif (gbm_device_)\n+\t\tgbm_device_destroy(gbm_device_);\n+}\n+\n+int GBM::createDevice()\n+{\n+\tconst char *dri_node = \"/dev/dri/renderD128\"; //TODO: get from an env or config setting\n+\n+\tfd_ = open(dri_node, O_RDWR | O_CLOEXEC);\n+\tif (fd_ < 0) {\n+\t\tLOG(GBM, Error) << \"Open \" << dri_node << \" fail \" << fd_;\n+\t\treturn fd_;\n+\t}\n+\n+\tgbm_device_ = gbm_create_device(fd_);\n+\tif (!gbm_device_) {\n+\t\tLOG(GBM, Error) << \"gbm_crate_device fail\";\n+\t\tgoto fail;\n+\t}\n+\n+\tformat_ = libcamera::formats::ARGB8888;\n+\n+\treturn 0;\n+fail:\n+\tclose(fd_);\n+\treturn -errno;\n+}\n+} //namespace libcamera\ndiff --git a/src/libcamera/meson.build b/src/libcamera/meson.build\nindex 5b9b86f21..fe60c8752 100644\n--- a/src/libcamera/meson.build\n+++ b/src/libcamera/meson.build\n@@ -69,6 +69,16 @@ libcamera_deps = []\n libatomic = cc.find_library('atomic', required : false)\n libthreads = dependency('threads')\n \n+libgbm = cc.find_library('gbm', required: false)\n+gbm_works = cc.check_header('gbm.h', required: false)\n+\n+if libgbm.found() and gbm_works\n+ config_h.set('HAVE_GBM', 1)\n+ libcamera_internal_sources += files([\n+ 'gbm.cpp',\n+ ])\n+endif\n+\n subdir('base')\n subdir('converter')\n subdir('ipa')\n@@ -176,6 +186,7 @@ libcamera_deps += [\n libcamera_base_private,\n libcrypto,\n libdl,\n+ libgbm,\n liblttng,\n libudev,\n libyaml,\n","prefixes":["v4","01/23"]}