{"id":25117,"url":"https://patchwork.libcamera.org/api/1.1/patches/25117/?format=json","web_url":"https://patchwork.libcamera.org/patch/25117/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20251120232019.3590-17-bryan.odonoghue@linaro.org>","date":"2025-11-20T23:20:13","name":"[16/22] libcamera: software_isp: Move configure to worker thread","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"e843334eee03f6e4e74c0af75b16b9052ae9e8ab","submitter":{"id":175,"url":"https://patchwork.libcamera.org/api/1.1/people/175/?format=json","name":"Bryan O'Donoghue","email":"bryan.odonoghue@linaro.org"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/25117/mbox/","series":[{"id":5599,"url":"https://patchwork.libcamera.org/api/1.1/series/5599/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5599","date":"2025-11-20T23:19:57","name":"GPUISP precursor series","version":1,"mbox":"https://patchwork.libcamera.org/series/5599/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/25117/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/25117/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A75B5C3330\n\tfor ;\n\tThu, 20 Nov 2025 23:20:55 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5EEEF60B0B;\n\tFri, 21 Nov 2025 00:20:55 +0100 (CET)","from mail-wm1-x329.google.com (mail-wm1-x329.google.com\n\t[IPv6:2a00:1450:4864:20::329])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9F2AF60AAF\n\tfor ;\n\tFri, 21 Nov 2025 00:20:52 +0100 (CET)","by mail-wm1-x329.google.com with SMTP id\n\t5b1f17b1804b1-47774d3536dso11138655e9.0\n\tfor ;\n\tThu, 20 Nov 2025 15:20:52 -0800 (PST)","from inspiron14p-linux.ht.home (188-141-3-146.dynamic.upc.ie.\n\t[188.141.3.146]) by smtp.gmail.com with ESMTPSA id\n\t5b1f17b1804b1-477bf3af0ecsm11618415e9.9.2025.11.20.15.20.50\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tThu, 20 Nov 2025 15:20:51 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"All0US39\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=linaro.org; s=google; t=1763680852; x=1764285652;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=KaV04Bxgis4mNG/lyi1+ASdW7XQgEYuf59tHgnfd3u4=;\n\tb=All0US39BUpkpZs6opGdVRIsxLi0vSw6oSewAkfCtUXONY/y1pWZcCltRayZSUoF1f\n\taE7O9XQclAboAd+EKDOqWEoTBBSNwebQOmZIwAaOy+MJObViG30dZUMPXRGqzv3tASYF\n\ty6JXoWoQVSFG1mNO08b4XjrQEKvCQSIcHqnZjY4letnTTSFM2bjVyY7tCSdvbqq/JJ0X\n\tjt/H/qtJtXk2p6gCkbqwmncltCGff+zv66APUq06Dt7sEL7Ci/busaZJ9w8R4J1Rmtn5\n\tpbG/6jWGtbre05t8VqYs2jm1kZSix/0iUhF0MModHeCE7k5w1QlBhnDEoCP8SONcQr7v\n\tYz2A==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1763680852; x=1764285652;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n\t:to:cc:subject:date:message-id:reply-to;\n\tbh=KaV04Bxgis4mNG/lyi1+ASdW7XQgEYuf59tHgnfd3u4=;\n\tb=WN2saLwOkzCxv4quJhYwC4oJUg5Eo0SVOWQNKHbUOcoW1WQnelHoaqadMtccleTFm/\n\tjAj5KtBttSn44wPCTNINJlFN82eDNic2yyxkCzoRnaEl6ySPIP52JElzVjAXDDtXmYLN\n\tTxnxd7wOtvqHQ66ukD3/zZ1pbLvIRe8a7bFmH+3In4nP929Zr0du7KCj8JhaYTVREOFL\n\tg9nyFhGYpM2dWJjh0c+qqIJWKIkZypucYOdf3kh4Kw9o8H0AiLoALu6gaLU6H5FQt77y\n\tELv4wG6hlSxyAQub9oAdsUm2HP7q8di3YXm7aHuDWtm2FfT0gK1V+pf66eODEXkzyZqh\n\tJM/Q==","X-Gm-Message-State":"AOJu0YxcbVcGXe8iqHOVU8pQvRJui0h5XxEC1MIPXcDyfz9ZSvMelwzw\n\tVeT/zuHmoYJHH83F22vUJt37V+rPbgU9ogrXljPtV8kxC7qKch/luGZIWXMAUK1RcCF5zLFoLyU\n\tlctzyidw=","X-Gm-Gg":"ASbGncsw8mjtSws3TRH9W6waSefDWHEsX2Ar31WbJdnikflw/vd08sRuslzf9oWO9N8\n\tCqSOB1BFdZtC9WECPSQkX+gJXEEOFjlKoZwRZFIxb2KdzoxU1U+bZh/zIwNz6CTzyLitGS1ssiJ\n\tt70J7XcDRLjGFc7250aunPxAWVqjYGPwdhq39EBYi7M2wqv3WofTHiFEmC2uIi0dnMx0XnyppU6\n\t3FGBmHFViqQBjzxUM3/6eZ9HkG29qi8fAaM5doyH0Jh1hWC+IR4aPKUNZFJwNlNGB97/D31bYHR\n\tC6Q+MO1BRJDI8pgBoKwqrO+J7zN25zxZj/SGWYprA6rC4GR+qKCgraMBDpsEtGtuWO5mY9qfYpe\n\tL8YCmmpwWRUuoFbmsN7B8jGiKG4fAcGIujDzFIu9FVL4n2vNnHA2qXsAirGucCoYCcxDhQxJ4ED\n\tW7fkID4ARFU/ZtfrlxGGTsrKFdYXXHVQJPNH7PioIW1A16cCLLW9M0oqmww3p+486vET4=","X-Google-Smtp-Source":"AGHT+IHhGmh/RDHP45IYLyYaVUdsVYtEgSZ/RPgEH+7rVDtYp+oOSej4EvudkQel7oELsNrNykR7Og==","X-Received":"by 2002:a05:600c:4685:b0:475:ddad:c3a9 with SMTP id\n\t5b1f17b1804b1-477c052f04bmr2490385e9.13.1763680851947; \n\tThu, 20 Nov 2025 15:20:51 -0800 (PST)","From":"Bryan O'Donoghue ","To":"libcamera-devel@lists.libcamera.org","Cc":"pavel@ucw.cz,\n\tBryan O'Donoghue ","Subject":"[PATCH 16/22] libcamera: software_isp: Move configure to worker\n\tthread","Date":"Thu, 20 Nov 2025 23:20:13 +0000","Message-ID":"<20251120232019.3590-17-bryan.odonoghue@linaro.org>","X-Mailer":"git-send-email 2.51.2","In-Reply-To":"<20251120232019.3590-1-bryan.odonoghue@linaro.org>","References":"<20251120232019.3590-1-bryan.odonoghue@linaro.org>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"EGL requires both configure() and process() to operate on the same\nthread. As preparation for that, move current CPU configure into the\nWorkerThread with a ConnectionTypeBlocking invocation of\n&DebayerCpu::configure.\n\nSigned-off-by: Bryan O'Donoghue \n---\n src/libcamera/software_isp/software_isp.cpp | 12 ++++++++++--\n 1 file changed, 10 insertions(+), 2 deletions(-)","diff":"diff --git a/src/libcamera/software_isp/software_isp.cpp b/src/libcamera/software_isp/software_isp.cpp\nindex afa4eb7a8..4c232339b 100644\n--- a/src/libcamera/software_isp/software_isp.cpp\n+++ b/src/libcamera/software_isp/software_isp.cpp\n@@ -267,7 +267,15 @@ int SoftwareIsp::configure(const StreamConfiguration &inputCfg,\n \n \tispWorkerThread_.start();\n \n-\treturn debayer_->configure(inputCfg, outputCfgs, ccmEnabled_);\n+\tret = debayer_->invokeMethod(&Debayer::configure,\n+\t\t\t\t ConnectionTypeBlocking, inputCfg,\n+\t\t\t\t outputCfgs, ccmEnabled_);\n+\tif (ret) {\n+\t\tispWorkerThread_.exit();\n+\t\tispWorkerThread_.wait();\n+\t}\n+\n+\treturn ret;\n }\n \n /**\n@@ -391,7 +399,7 @@ void SoftwareIsp::stop()\n void SoftwareIsp::process(uint32_t frame, FrameBuffer *input, FrameBuffer *output)\n {\n \tipa_->computeParams(frame);\n-\tdebayer_->invokeMethod(&DebayerCpu::process,\n+\tdebayer_->invokeMethod(&Debayer::process,\n \t\t\t ConnectionTypeQueued, frame, input, output, debayerParams_);\n }\n \n","prefixes":["16/22"]}