{"id":25116,"url":"https://patchwork.libcamera.org/api/1.1/patches/25116/?format=json","web_url":"https://patchwork.libcamera.org/patch/25116/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20251120232019.3590-16-bryan.odonoghue@linaro.org>","date":"2025-11-20T23:20:12","name":"[15/22] libcamera: software_isp: Start the ISP thread in configure","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"f15eebb7c60746935ec55f953c786798ff77e881","submitter":{"id":175,"url":"https://patchwork.libcamera.org/api/1.1/people/175/?format=json","name":"Bryan O'Donoghue","email":"bryan.odonoghue@linaro.org"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/25116/mbox/","series":[{"id":5599,"url":"https://patchwork.libcamera.org/api/1.1/series/5599/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5599","date":"2025-11-20T23:19:57","name":"GPUISP precursor series","version":1,"mbox":"https://patchwork.libcamera.org/series/5599/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/25116/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/25116/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D5EDAC3330\n\tfor ;\n\tThu, 20 Nov 2025 23:20:53 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9691160AB3;\n\tFri, 21 Nov 2025 00:20:53 +0100 (CET)","from mail-wr1-x42a.google.com (mail-wr1-x42a.google.com\n\t[IPv6:2a00:1450:4864:20::42a])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D4CA260AAF\n\tfor ;\n\tFri, 21 Nov 2025 00:20:50 +0100 (CET)","by mail-wr1-x42a.google.com with SMTP id\n\tffacd0b85a97d-429c7869704so1230305f8f.2\n\tfor ;\n\tThu, 20 Nov 2025 15:20:50 -0800 (PST)","from inspiron14p-linux.ht.home (188-141-3-146.dynamic.upc.ie.\n\t[188.141.3.146]) by smtp.gmail.com with ESMTPSA id\n\t5b1f17b1804b1-477bf3af0ecsm11618415e9.9.2025.11.20.15.20.48\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tThu, 20 Nov 2025 15:20:49 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"WnU+HEeh\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=linaro.org; s=google; t=1763680850; x=1764285650;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=0FUA8kH36pvKSfSDc4qeO8M3Vhl+74knCB5rIoM7BX0=;\n\tb=WnU+HEehTy4PQIMU+0tZUKnsJfnW3VGNyOwIwRdYBCrAyGdg5Mb9Vc3SsJoOrEtsmF\n\t3lwS58R8I3RCWNuN5secw5hhzi2tT4mnlB7bzHsg1k/aMWBNNrqZsoKEqhpee3JGTPR2\n\t/Cpfo7wyxO9OlM8wsE7wybWXb9+2frqQ/LqO/oNjW3gh0ouxuij3Zs/BHWJHkRO3V+Ul\n\t5+YE4qmu4QMF+nbe74unUwxg0QJ0v8KlsZXTXPiE2b7oTZ/0Npdh4GCWUNgapOO1LX9p\n\tXMs2OfFCsksNXsALE8MPe3nVPZGQc8sxq5V3wwMTlxLlqpWA3OiaYtzQdJlj8Z+kWHYG\n\to/cA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1763680850; x=1764285650;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n\t:to:cc:subject:date:message-id:reply-to;\n\tbh=0FUA8kH36pvKSfSDc4qeO8M3Vhl+74knCB5rIoM7BX0=;\n\tb=RNnN5oJicqS/2bVUEWjQTfyb5dQihS91VjHnBZyLcY4vFcAD1TqiIsohidTouSazMA\n\tZXAnJI3i1S9iHv66Mwfz3o2mKdhXHDWC2WPZ2nFnfjtOe0/AaIymSLESRZ7NNgWuDcEg\n\tG0Mtz4QS6xx4BBoZK1HymZCLQHVuFB+08szN3Ga1oqrKLKEPkPbhZK552zaLVOXsJFe2\n\t3HzRfcXAlJOekPI8icuk0DWzO9OZeAbkd+K5qmjoQDeiXhT6VBTUv7xk1p0ETKS7Zqsq\n\t0sAZsPbxDmx/lTnQ0liuvKh8kaylqCLdH58rOd14EELj1RgyMzSLP2DvKKqpRx4d5SFz\n\tY1Dg==","X-Gm-Message-State":"AOJu0YyfluCd74iyvixhjM5S2vW0xMsiCaVVu2lLhxnYCFrYOn1ommWr\n\t2XVOY8eRwZg0l3aJR6InvV4KQr8+K+eqWqh1YRyJlcm0T61Mb1S4ykz5r2z7uOT/K6tWxzNy4H5\n\tKXsBWSU0=","X-Gm-Gg":"ASbGncsUaHJn/nJmlf0uojp4afbywbUynJvidz30hoAknnZVDxR0qcuq5LAkCjwhqDi\n\tSMm/XSkkz6LUy/6dh1ArtA5aPYPjlbbKR9O2t3aZYhhsNfb0gQRlSy5HiaLPSPgmyJixGPRCFpM\n\tafdOGKD6gXYnsNVHXKZ2+O64xJBXDEwg4Hl9O93rnEnOGe7D6XDKArkmML8lcYLz6DN4ELWwRUY\n\toHEsIDyp86o5n2yXT7nmFh0I6Y3uNdR1RmmM5Ezn1SV5IaNSB3h+08LS8yo6ZVuifmq6WtPilL+\n\twtO79/kWxE7qbXerb9XutqQD5LXhLr5HvvxQCr+BRGqdAe0L7sHib8ovSvUflVr01OJNYkkemjh\n\tccMQ3RhYK3Y9WXeRMQN+/4X6xa6udIvweT/svwMSYYdY7KkvUsIkx2nDnBWo2Z7Gz4Pv61BTtWy\n\twqHvJjIOEo7iokX2joJ0EMHyn9W12ktZJh8r/adn2mPNzgxQNtJXQlyM882Bn9BthY6SE=","X-Google-Smtp-Source":"AGHT+IGwpZ/PVbs9VQq8dpseNsXDlDCkylAjbElujHuno/VPeyiRieeQbvg5MZPlXZafwU/3nXpQgw==","X-Received":"by 2002:a05:6000:2585:b0:42b:4247:b07e with SMTP id\n\tffacd0b85a97d-42cc1cf46b8mr85562f8f.25.1763680850126; \n\tThu, 20 Nov 2025 15:20:50 -0800 (PST)","From":"Bryan O'Donoghue ","To":"libcamera-devel@lists.libcamera.org","Cc":"pavel@ucw.cz, Bryan O'Donoghue ,\n\tRobert Mader ","Subject":"[PATCH 15/22] libcamera: software_isp: Start the ISP thread in\n\tconfigure","Date":"Thu, 20 Nov 2025 23:20:12 +0000","Message-ID":"<20251120232019.3590-16-bryan.odonoghue@linaro.org>","X-Mailer":"git-send-email 2.51.2","In-Reply-To":"<20251120232019.3590-1-bryan.odonoghue@linaro.org>","References":"<20251120232019.3590-1-bryan.odonoghue@linaro.org>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"EGL is not thread-safe and in fact associates invisible handles with the\nthreadid of the calling context.\n\nAs a result we need to make Deabyer::configure() and Debayer::process() in SoftISP execute on\nthe same thread.\n\nWhen we call Debayer::configure() in the egl class this will setup and egl context\nfor us which is associated with the calling thread context. Hence when\nDebayer::process(); runs it must run in the same thread as\nDebayer::configure() or the hidden Gegl context handles will not point\nto the same place.\n\nMove start thread into configure() as a first step towards this.\n\nCo-developed-by: Robert Mader \nSigned-off-by: Robert Mader \nSigned-off-by: Bryan O'Donoghue \n---\n src/libcamera/software_isp/software_isp.cpp | 3 ++-\n 1 file changed, 2 insertions(+), 1 deletion(-)","diff":"diff --git a/src/libcamera/software_isp/software_isp.cpp b/src/libcamera/software_isp/software_isp.cpp\nindex 928a2520c..afa4eb7a8 100644\n--- a/src/libcamera/software_isp/software_isp.cpp\n+++ b/src/libcamera/software_isp/software_isp.cpp\n@@ -265,6 +265,8 @@ int SoftwareIsp::configure(const StreamConfiguration &inputCfg,\n \tif (ret < 0)\n \t\treturn ret;\n \n+\tispWorkerThread_.start();\n+\n \treturn debayer_->configure(inputCfg, outputCfgs, ccmEnabled_);\n }\n \n@@ -346,7 +348,6 @@ int SoftwareIsp::start()\n \tif (ret)\n \t\treturn ret;\n \n-\tispWorkerThread_.start();\n \treturn 0;\n }\n \n","prefixes":["15/22"]}