{"id":25100,"url":"https://patchwork.libcamera.org/api/1.1/patches/25100/?format=json","web_url":"https://patchwork.libcamera.org/patch/25100/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20251120134101.72892-1-isaac.scott@ideasonboard.com>","date":"2025-11-20T13:41:01","name":"[v2] libipa: module: Allow algorithms to be disabled via the tuning file","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"e52e4abaca645a28b6929730f929a4bc16184c24","submitter":{"id":215,"url":"https://patchwork.libcamera.org/api/1.1/people/215/?format=json","name":"Isaac Scott","email":"isaac.scott@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/25100/mbox/","series":[{"id":5598,"url":"https://patchwork.libcamera.org/api/1.1/series/5598/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5598","date":"2025-11-20T13:41:01","name":"[v2] libipa: module: Allow algorithms to be disabled via the tuning file","version":2,"mbox":"https://patchwork.libcamera.org/series/5598/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/25100/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/25100/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B368FC3336\n\tfor ;\n\tThu, 20 Nov 2025 13:41:16 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0B79C60A8B;\n\tThu, 20 Nov 2025 14:41:16 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6F5B26069A\n\tfor ;\n\tThu, 20 Nov 2025 14:41:14 +0100 (CET)","from isaac-ThinkPad-T16-Gen-2.infra.iob\n\t(cpc90716-aztw32-2-0-cust408.18-1.cable.virginm.net [86.26.101.153])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 8BF669CA;\n\tThu, 20 Nov 2025 14:39:08 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"EBBqpaQH\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1763645948;\n\tbh=EtEtF4jHaZ8G5dd9YkvK943xM933Xv/bSmhmmcW7XZs=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=EBBqpaQH+MHLp5JOU9WvRMRm1TFiU9plBR/kCdgWwYYwYJDUUDMjJ1HQ3GsRXXPyf\n\taAv85+VPGj6LPaz/vHcai+x51aXnYMS+eeINy3+8Ac+9+mCfqpvgeQQciWb7tfLb2O\n\t1TRZytowVLb0mdL0jn2+xRg2KiuNeh4ZR13ujcsc=","From":"Isaac Scott ","To":"libcamera-devel@lists.libcamera.org","Cc":"Isaac Scott ","Subject":"[PATCH v2] libipa: module: Allow algorithms to be disabled via the\n\ttuning file","Date":"Thu, 20 Nov 2025 13:41:01 +0000","Message-ID":"<20251120134101.72892-1-isaac.scott@ideasonboard.com>","X-Mailer":"git-send-email 2.43.0","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"It is beneficial to have the option during development to disable and\nenable algorithms via the tuning file without having to delete their\nentries.\n\nAdd support for an optional \"enabled\" parameter to accomplish this.\n\nUsage example:\nversion: 1\nalgorithms:\n - Agc:\n enabled: true\n - Awb:\n enabled: false\n\nThis will enable AGC, and disable AWB. If the enabled flag is not\npresent, the algorithm will be enabled.\n\nSigned-off-by: Isaac Scott \n\n---\n\nv1 of this patch can be found here:\n\nhttps://patchwork.libcamera.org/patch/23299/\n\nChangelog:\n\nv1 -> v2:\n- Moved parsing to createAlgorithms() instead of createAlgorithm()\n- Changed \"disabled\" flag to \"enabled: [boolean]\"\n---\n src/ipa/libipa/module.h | 9 +++++++++\n 1 file changed, 9 insertions(+)","diff":"diff --git a/src/ipa/libipa/module.h b/src/ipa/libipa/module.h\nindex 0fb51916f..f8c4bb664 100644\n--- a/src/ipa/libipa/module.h\n+++ b/src/ipa/libipa/module.h\n@@ -55,6 +55,15 @@ public:\n \t\t\t\treturn -EINVAL;\n \t\t\t}\n \n+\t\t\tif (algo.contains(\"enabled\")) {\n+\t\t\t\tif (algo[\"enabled\"].get() == false) {\n+\t\t\t\t\tLOG(IPAModuleAlgo, Debug)\n+\t\t\t\t\t\t<< \"Algorithm \" << i\n+\t\t\t\t\t\t<< \" is disabled via tuning file\";\n+\t\t\t\t\tcontinue;\n+\t\t\t\t}\n+\t\t\t}\n+\n \t\t\tint ret = createAlgorithm(context, algo);\n \t\t\tif (ret) {\n \t\t\t\talgorithms_.clear();\n","prefixes":["v2"]}