{"id":25028,"url":"https://patchwork.libcamera.org/api/1.1/patches/25028/?format=json","web_url":"https://patchwork.libcamera.org/patch/25028/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20251113122450.287633-14-kieran.bingham@ideasonboard.com>","date":"2025-11-13T12:24:48","name":"[v3,13/14] ipa: rkisp1: cproc: Provide a Hue control","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"68e646b1edbc8d4088e459ac18ce8e339951d450","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/1.1/people/4/?format=json","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/25028/mbox/","series":[{"id":5587,"url":"https://patchwork.libcamera.org/api/1.1/series/5587/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5587","date":"2025-11-13T12:24:35","name":"libipa: Introduce a Quantized type","version":3,"mbox":"https://patchwork.libcamera.org/series/5587/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/25028/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/25028/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 52FFFC3317\n\tfor ;\n\tThu, 13 Nov 2025 12:25:14 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0939260AB0;\n\tThu, 13 Nov 2025 13:25:14 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7315560AA8\n\tfor ;\n\tThu, 13 Nov 2025 13:24:57 +0100 (CET)","from Monstersaurus.infra.iob\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 5ECC11E39;\n\tThu, 13 Nov 2025 13:22:57 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Nl7BTwtZ\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1763036577;\n\tbh=KEm3cjcPvuJ/XLjKXZY0QTVsPROeEFLxJiinNDBZFzE=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=Nl7BTwtZ7SiUBQp+m189KNYPbhrhNJYt/xobFC+eFMrFb/JjTFT0QTjwrFFAe/dme\n\tQO7vCtD5enMDQJXh9mAKiblwtaRjxSINfVZrHK1wCm6SoMx+OxBrazCeGYw3NMiyxL\n\tp9xP2Cr5JdkvNODJnT7SSfjAv3G1UVb7Q6QuHS1w=","From":"Kieran Bingham ","To":"libcamera devel ","Cc":"Kieran Bingham ","Subject":"[PATCH v3 13/14] ipa: rkisp1: cproc: Provide a Hue control","Date":"Thu, 13 Nov 2025 12:24:48 +0000","Message-ID":"<20251113122450.287633-14-kieran.bingham@ideasonboard.com>","X-Mailer":"git-send-email 2.50.1","In-Reply-To":"<20251113122450.287633-1-kieran.bingham@ideasonboard.com>","References":"<20251113122450.287633-1-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The RKISP1 supports a configurable Hue as part of the colour processing\nunit (cproc).\n\nThis is implemented as a phase shift of the chrominance values between\n-90 and +87.188 degrees according to the datasheet however the type\nitself would imply that this is a range between -90 and 89.2969.\n\nImplement the new control converting to the hardware scale accordingly\nand report the applied control in the completed request metadata.\n\nSigned-off-by: Kieran Bingham \n---\n src/ipa/rkisp1/algorithms/cproc.cpp | 18 ++++++++++++++++++\n src/ipa/rkisp1/ipa_context.h | 3 +++\n 2 files changed, 21 insertions(+)","diff":"diff --git a/src/ipa/rkisp1/algorithms/cproc.cpp b/src/ipa/rkisp1/algorithms/cproc.cpp\nindex 7475e6c1b609..5389882c1685 100644\n--- a/src/ipa/rkisp1/algorithms/cproc.cpp\n+++ b/src/ipa/rkisp1/algorithms/cproc.cpp\n@@ -39,6 +39,7 @@ namespace {\n \n constexpr float kDefaultBrightness = 0.0f;\n constexpr float kDefaultContrast = 1.0f;\n+constexpr float kDefaultHue = 0.0f;\n constexpr float kDefaultSaturation = 1.0f;\n \n } /* namespace */\n@@ -53,6 +54,8 @@ int ColorProcessing::init(IPAContext &context,\n \n \tcmap[&controls::Brightness] = ControlInfo(-1.0f, 0.993f, kDefaultBrightness);\n \tcmap[&controls::Contrast] = ControlInfo(0.0f, 1.993f, kDefaultContrast);\n+\tcmap[&controls::Hue] = ControlInfo(HueQ::TraitsType::min,\n+\t\t\t\t\t HueQ::TraitsType::max, kDefaultHue);\n \tcmap[&controls::Saturation] = ControlInfo(0.0f, 1.993f, kDefaultSaturation);\n \n \treturn 0;\n@@ -68,6 +71,7 @@ int ColorProcessing::configure(IPAContext &context,\n \n \tcproc.brightness = BrightnessQ(kDefaultBrightness);\n \tcproc.contrast = ContrastQ(kDefaultContrast);\n+\tcproc.hue = HueQ(kDefaultHue);\n \tcproc.saturation = SaturationQ(kDefaultSaturation);\n \n \treturn 0;\n@@ -109,6 +113,17 @@ void ColorProcessing::queueRequest(IPAContext &context,\n \t\tLOG(RkISP1CProc, Debug) << \"Set contrast to \" << value.value();\n \t}\n \n+\tconst auto &hue = controls.get(controls::Hue);\n+\tif (hue) {\n+\t\tHueQ value = *hue;\n+\t\tif (cproc.hue != value) {\n+\t\t\tcproc.hue = value;\n+\t\t\tupdate = true;\n+\t\t}\n+\n+\t\tLOG(RkISP1CProc, Debug) << \"Set hue to \" << value.value();\n+\t}\n+\n \tconst auto saturation = controls.get(controls::Saturation);\n \tif (saturation) {\n \t\tSaturationQ value = *saturation;\n@@ -122,6 +137,7 @@ void ColorProcessing::queueRequest(IPAContext &context,\n \n \tframeContext.cproc.brightness = cproc.brightness;\n \tframeContext.cproc.contrast = cproc.contrast;\n+\tframeContext.cproc.hue = cproc.hue;\n \tframeContext.cproc.saturation = cproc.saturation;\n \tframeContext.cproc.update = update;\n }\n@@ -142,6 +158,7 @@ void ColorProcessing::prepare([[maybe_unused]] IPAContext &context,\n \tconfig.setEnabled(true);\n \tconfig->brightness = frameContext.cproc.brightness.quantized();\n \tconfig->contrast = frameContext.cproc.contrast.quantized();\n+\tconfig->hue = frameContext.cproc.hue.quantized();\n \tconfig->sat = frameContext.cproc.saturation.quantized();\n }\n \n@@ -154,6 +171,7 @@ void ColorProcessing::process([[maybe_unused]] IPAContext &context, [[maybe_unus\n {\n \tmetadata.set(controls::Brightness, frameContext.cproc.brightness.value());\n \tmetadata.set(controls::Contrast, frameContext.cproc.contrast.value());\n+\tmetadata.set(controls::Hue, frameContext.cproc.hue.value());\n \tmetadata.set(controls::Saturation, frameContext.cproc.saturation.value());\n }\n \ndiff --git a/src/ipa/rkisp1/ipa_context.h b/src/ipa/rkisp1/ipa_context.h\nindex 651558bdf42d..52d458a90cc3 100644\n--- a/src/ipa/rkisp1/ipa_context.h\n+++ b/src/ipa/rkisp1/ipa_context.h\n@@ -36,6 +36,7 @@ namespace ipa::rkisp1 {\n /* Fixed point types used by CPROC */\n using BrightnessQ = Q1_7;\n using ContrastQ = UQ1_7;\n+using HueQ = Quantized>;\n using SaturationQ = UQ1_7;\n \n struct IPAHwSettings {\n@@ -123,6 +124,7 @@ struct IPAActiveState {\n \tstruct {\n \t\tBrightnessQ brightness;\n \t\tContrastQ contrast;\n+\t\tHueQ hue;\n \t\tSaturationQ saturation;\n \t} cproc;\n \n@@ -177,6 +179,7 @@ struct IPAFrameContext : public FrameContext {\n \tstruct {\n \t\tBrightnessQ brightness;\n \t\tContrastQ contrast;\n+\t\tHueQ hue;\n \t\tSaturationQ saturation;\n \n \t\tbool update;\n","prefixes":["v3","13/14"]}