{"id":24895,"url":"https://patchwork.libcamera.org/api/1.1/patches/24895/?format=json","web_url":"https://patchwork.libcamera.org/patch/24895/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20251029172439.1513907-7-kieran.bingham@ideasonboard.com>","date":"2025-10-29T17:24:31","name":"[v2,06/13] test: libipa: Add Q4.7 type and tests to match existing use case tests","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"464fb0c01ec33a6ef3fa68218aef3eb962232284","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/1.1/people/4/?format=json","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/24895/mbox/","series":[{"id":5544,"url":"https://patchwork.libcamera.org/api/1.1/series/5544/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5544","date":"2025-10-29T17:24:25","name":"libipa: Introduce a Quantized type","version":2,"mbox":"https://patchwork.libcamera.org/series/5544/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/24895/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/24895/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id BC86BC32D4\n\tfor ;\n\tWed, 29 Oct 2025 17:25:04 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0B9A460875;\n\tWed, 29 Oct 2025 18:25:04 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D12D360869\n\tfor ;\n\tWed, 29 Oct 2025 18:24:47 +0100 (CET)","from Monstersaurus.hippo-penny.ts.net\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 78CFD11DD;\n\tWed, 29 Oct 2025 18:22:58 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"vadAB4Wx\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1761758578;\n\tbh=SZQYT53r5Ox7Ud7HzN///PZjUGCxZfuCQ4pvDrFIiCY=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=vadAB4WxqivO+MqbfKTro5xMTFx+o4m8+aA02iopJyhfHAAKlTSUrOIC/hjqTcjYW\n\tmUO1jUlSLaFfMdrh2xMd93cFIQ/JL8QXiQ5MmXNndGq/9mYI8N7mGf4yAYx9k0x0Zq\n\tPbfYNN+EmeYNWSdqRJiy2sLIwBylCzsfzptX7x9A=","From":"Kieran Bingham ","To":"libcamera devel ","Cc":"Kieran Bingham ","Subject":"[PATCH v2 06/13] test: libipa: Add Q4.7 type and tests to match\n\texisting use case tests","Date":"Wed, 29 Oct 2025 17:24:31 +0000","Message-ID":"<20251029172439.1513907-7-kieran.bingham@ideasonboard.com>","X-Mailer":"git-send-email 2.50.1","In-Reply-To":"<20251029172439.1513907-1-kieran.bingham@ideasonboard.com>","References":"<20251029172439.1513907-1-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The existing fixed point test cases utilise a signed Q4.7 format. Add\nmatching tests covering the same values and extend to validate the full\ntype.\n\nSigned-off-by: Kieran Bingham \n---\n test/ipa/libipa/fixedpoint.cpp | 18 ++++++++++++++++++\n 1 file changed, 18 insertions(+)","diff":"diff --git a/test/ipa/libipa/fixedpoint.cpp b/test/ipa/libipa/fixedpoint.cpp\nindex 6f6ef4ce258e..4bffd40f5a63 100644\n--- a/test/ipa/libipa/fixedpoint.cpp\n+++ b/test/ipa/libipa/fixedpoint.cpp\n@@ -20,6 +20,9 @@ using namespace std;\n using namespace libcamera;\n using namespace ipa;\n \n+/* Q4_7(-8 .. 7.99219) Min: Q:0x0400 V:-8 -- Max: Q:0x03ff V:7.99219 Step:0.0078125 */\n+using Q4_7 = Quantized>;\n+\n class FixedPointUtilsTest : public Test\n {\n protected:\n@@ -171,6 +174,21 @@ protected:\n \t\tfails += quantizedCheck(1.0f, 0b1'0000000, 1.0f);\t\t/* Mid */\n \t\tfails += quantizedCheck(1.992f, 0b1'1111111, 1.99219f);\t\t/* Max */\n \n+\t\t/* Q4_7(-8 .. 7.99219) Min: Q:0x0400 F:-8 -- Max: Q:0x03FF V:7.99219 Step:0.0078125 */\n+\t\tintroduce(\"Q4_7\"); /* No Sign Extension */\n+\t\tfails += quantizedCheck(-8.0f, 0b1000'0000000, -8.0f);\t\t/* Min */\n+\t\tfails += quantizedCheck(-0.008f, 0b1111'1111111, -0.0078125);\t/* -1 step */\n+\t\tfails += quantizedCheck( 0.0f, 0b0000'0000000, 0.0f);\t\t/* Zero */\n+\t\tfails += quantizedCheck( 0.008f, 0b0000'0000001, 0.0078125f);\t/* +1 step */\n+\t\tfails += quantizedCheck( 7.992f, 0b0111'1111111, 7.99219f);\t/* Max */\n+\n+\t\t/* Retain additional tests from original testFixedPoint() */\n+\t\tfails += quantizedCheck( 0.2f, 0b0000'0011010, 0.203125f);\t/* 0x01a */\n+\t\tfails += quantizedCheck(-0.2f, 0b1111'1100110, -0.203125f);\t/* 0x7e6 */\n+\t\tfails += quantizedCheck(-0.8f, 0b1111'0011010, -0.796875f);\t/* 0x79a */\n+\t\tfails += quantizedCheck(-0.4f, 0b1111'1001101, -0.398438f);\t/* 0x7cd */\n+\t\tfails += quantizedCheck(-1.4f, 0b1110'1001101, -1.39844f);\t/* 0x74d */\n+\n \t\t/* Test Q12.4 */\n \t\tintroduce(\"Q12.4\");\n \n","prefixes":["v2","06/13"]}