{"id":24876,"url":"https://patchwork.libcamera.org/api/1.1/patches/24876/?format=json","web_url":"https://patchwork.libcamera.org/patch/24876/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20251028211751.2761420-6-rui.wang@ideasonboard.com>","date":"2025-10-28T21:17:39","name":"[v1,06/17] ipa: rkisp1: algorithms: dpf: add Dpf parseConfig","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"1de43424acd6586fbc5e867a1851c94241be5220","submitter":{"id":241,"url":"https://patchwork.libcamera.org/api/1.1/people/241/?format=json","name":"Rui Wang","email":"rui.wang@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/24876/mbox/","series":[{"id":5542,"url":"https://patchwork.libcamera.org/api/1.1/series/5542/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5542","date":"2025-10-28T21:17:34","name":"[v1,01/17] ipa: rkisp1: algorithms: add Denoise base class shell","version":1,"mbox":"https://patchwork.libcamera.org/series/5542/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/24876/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/24876/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id CC244BE080\n\tfor ;\n\tTue, 28 Oct 2025 21:18:40 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8C5AA60810;\n\tTue, 28 Oct 2025 22:18:40 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id CD4B560857\n\tfor ;\n\tTue, 28 Oct 2025 22:18:38 +0100 (CET)","from rui-Precision-7560.local (unknown [209.216.122.90])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 87BE8AD0;\n\tTue, 28 Oct 2025 22:16:49 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"jZpLwstd\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1761686210;\n\tbh=Trv+AgvvlCtuEhbgOacWmb+5oWJPm9tv6x2/CUl7rp8=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=jZpLwstdausn2z9U4xcyfV39ojzgX0RUIh4Xp+SmbtCwZBFVmPJK3p0z7GMwP3MH7\n\tEhfRJT1UETI4/Qpc9mjjUl7Ipgn3Y2K5T0WoFVgPdnz7aDxCuNXhZQINmJexvOX8Jo\n\t7EUceZ6E0cs5zkfWulW5he5D9LqPpOJRrJfBWkWI=","From":"Rui Wang ","To":"libcamera-devel@lists.libcamera.org","Cc":"Rui Wang ","Subject":"[PATCH v1 06/17] ipa: rkisp1: algorithms: dpf: add Dpf parseConfig","Date":"Tue, 28 Oct 2025 17:17:39 -0400","Message-ID":"<20251028211751.2761420-6-rui.wang@ideasonboard.com>","X-Mailer":"git-send-email 2.43.0","In-Reply-To":"<20251028211751.2761420-1-rui.wang@ideasonboard.com>","References":"<20251028211751.2761420-1-rui.wang@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Load tuning flags and ISO levels on top of the single-config helper.\nThe parseConfig() function wraps parseSingleConfig() to load the base\nconfiguration, then parses optional enable/devmode flags and any\nISO-banded overrides.\n\nISO levels are sorted by maxIso threshold for efficient band selection\nat runtime.\n\nSigned-off-by: Rui Wang \n---\n src/ipa/rkisp1/algorithms/denoise.h | 1 +\n src/ipa/rkisp1/algorithms/dpf.cpp | 42 +++++++++++++++++++++++++++++\n src/ipa/rkisp1/algorithms/dpf.h | 21 +++++++++++++--\n 3 files changed, 62 insertions(+), 2 deletions(-)","diff":"diff --git a/src/ipa/rkisp1/algorithms/denoise.h b/src/ipa/rkisp1/algorithms/denoise.h\nindex f40e5aa1..5fc78588 100644\n--- a/src/ipa/rkisp1/algorithms/denoise.h\n+++ b/src/ipa/rkisp1/algorithms/denoise.h\n@@ -36,6 +36,7 @@ protected:\n \t\t\t const IPAFrameContext &frameContext) const;\n \ttemplate\n \tint selectIsoBand(unsigned iso, const LevelContainer &levels) const;\n+\tvirtual bool parseConfig(const YamlObject &tuningData) = 0;\n \n private:\n \tbool manualMode_ = false; /**< Current manual/auto mode state */\ndiff --git a/src/ipa/rkisp1/algorithms/dpf.cpp b/src/ipa/rkisp1/algorithms/dpf.cpp\nindex 9d1e6435..d1b89691 100644\n--- a/src/ipa/rkisp1/algorithms/dpf.cpp\n+++ b/src/ipa/rkisp1/algorithms/dpf.cpp\n@@ -171,6 +171,48 @@ int Dpf::init([[maybe_unused]] IPAContext &context,\n \treturn 0;\n }\n \n+bool Dpf::parseConfig(const YamlObject &tuningData)\n+{\n+\t// Parse base config\n+\tif (!parseSingleConfig(tuningData, config_, strengthConfig_))\n+\t\treturn false;\n+\n+\tbaseConfig_ = config_;\n+\tbaseStrengthConfig_ = strengthConfig_;\n+\n+\t/* Optional master enable flag (default true). If false, we parse but won't program. */\n+\tyamlHelper::optbool(tuningData, \"enable\", enableDpf_, true);\n+\n+\t/* Optional developer mode flag (default true). If false, only basic manual controls available. */\n+\tbool devMode = true;\n+\tyamlHelper::optbool(tuningData, \"devmode\", devMode, true);\n+\tsetDevMode(devMode);\n+\n+\t// Parse ISO levels\n+\tif (tuningData.contains(\"IsoLevels\")) {\n+\t\tuseIsoLevels_ = true;\n+\t\tisoLevels_.clear();\n+\t\tfor (const auto &entry : tuningData[\"IsoLevels\"].asList()) {\n+\t\t\tstd::optional maxIsoOpt = entry[\"maxIso\"].get();\n+\t\t\tif (!maxIsoOpt) {\n+\t\t\t\tLOG(RkISP1Dpf, Error) << \"IsoLevels entry missing maxIso\";\n+\t\t\t\tcontinue;\n+\t\t\t}\n+\t\t\tIsoLevelConfig lvl{};\n+\t\t\tlvl.maxIso = *maxIsoOpt;\n+\t\t\tif (!parseSingleConfig(entry, lvl.dpf, lvl.strength))\n+\t\t\t\tcontinue;\n+\t\t\tisoLevels_.push_back(lvl);\n+\t\t}\n+\t\tstd::sort(isoLevels_.begin(), isoLevels_.end(),\n+\t\t\t [](const IsoLevelConfig &a, const IsoLevelConfig &b) {\n+\t\t\t\t return a.maxIso < b.maxIso;\n+\t\t\t });\n+\t}\n+\n+\treturn true;\n+}\n+\n bool Dpf::parseSingleConfig(const YamlObject &config,\n \t\t\t rkisp1_cif_isp_dpf_config &cfg,\n \t\t\t rkisp1_cif_isp_dpf_strength_config &strength)\ndiff --git a/src/ipa/rkisp1/algorithms/dpf.h b/src/ipa/rkisp1/algorithms/dpf.h\nindex cfd6ef44..faeb6c27 100644\n--- a/src/ipa/rkisp1/algorithms/dpf.h\n+++ b/src/ipa/rkisp1/algorithms/dpf.h\n@@ -32,8 +32,25 @@ public:\n \t\t RkISP1Params *params) override;\n \n private:\n-\tstruct rkisp1_cif_isp_dpf_config config_;\n-\tstruct rkisp1_cif_isp_dpf_strength_config strengthConfig_;\n+\tstruct rkisp1_cif_isp_dpf_config config_ {\n+\t};\n+\tstruct rkisp1_cif_isp_dpf_strength_config strengthConfig_ {\n+\t};\n+\tstruct rkisp1_cif_isp_dpf_config baseConfig_ {\n+\t};\n+\tstruct rkisp1_cif_isp_dpf_strength_config baseStrengthConfig_ {\n+\t};\n+\tstruct IsoLevelConfig {\n+\t\tunsigned int maxIso; /* inclusive upper bound */\n+\t\tstruct rkisp1_cif_isp_dpf_config dpf;\n+\t\tstruct rkisp1_cif_isp_dpf_strength_config strength;\n+\t};\n+\n+\tstd::vector isoLevels_;\n+\tbool useIsoLevels_ = false;\n+\tbool enableDpf_ = true; /* YAML master enable */\n+\n+\tbool parseConfig(const YamlObject &tuningData) override;\n \tbool parseSingleConfig(const YamlObject &config,\n \t\t\t rkisp1_cif_isp_dpf_config &cfg,\n \t\t\t rkisp1_cif_isp_dpf_strength_config &strength);\n","prefixes":["v1","06/17"]}