{"id":24854,"url":"https://patchwork.libcamera.org/api/1.1/patches/24854/?format=json","web_url":"https://patchwork.libcamera.org/patch/24854/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20251028170847.2673396-2-rui.wang@ideasonboard.com>","date":"2025-10-28T17:08:31","name":"[v1,02/16] ipa: rkisp1: algorithms: add Denoise ISO helpers","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"4f1cf43e77c90efb5cc8e2c318542276cde57790","submitter":{"id":241,"url":"https://patchwork.libcamera.org/api/1.1/people/241/?format=json","name":"Rui Wang","email":"rui.wang@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/24854/mbox/","series":[{"id":5539,"url":"https://patchwork.libcamera.org/api/1.1/series/5539/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5539","date":"2025-10-28T17:08:30","name":"[v1,01/16] ipa: rkisp1: algorithms: add Denoise base class shell","version":1,"mbox":"https://patchwork.libcamera.org/series/5539/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/24854/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/24854/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 7183DC32CE\n\tfor ;\n\tTue, 28 Oct 2025 17:09:07 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 18E93607F4;\n\tTue, 28 Oct 2025 18:09:07 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 39D18607E5\n\tfor ;\n\tTue, 28 Oct 2025 18:09:05 +0100 (CET)","from rui-Precision-7560.local (unknown [209.216.122.90])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 6220A16A7;\n\tTue, 28 Oct 2025 18:07:16 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"nErLtTwr\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1761671236;\n\tbh=c4T8Q10S0W1EbJ7ObczOLcOiIE/Idualcu82YoHQtPk=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=nErLtTwr20e3f9Ga2dFzW+YDQPPgfiFKN13C9Ax5dXbz2Zh1aJBWjG/Y8jnEsOBcx\n\tH4vzVsbjs/gBdM1BSioupmh05gkrBqOdfOWlio8Yk7mOfdBgU6S2dbR9BWfjiV7pX4\n\ttVtOqMiBWxI/n8pwy3zxcXAJizJNnNNYHmQ58oYY=","From":"Rui Wang ","To":"libcamera-devel@lists.libcamera.org","Cc":"Rui Wang ","Subject":"[PATCH v1 02/16] ipa: rkisp1: algorithms: add Denoise ISO helpers","Date":"Tue, 28 Oct 2025 13:08:31 -0400","Message-ID":"<20251028170847.2673396-2-rui.wang@ideasonboard.com>","X-Mailer":"git-send-email 2.43.0","In-Reply-To":"<20251028170847.2673396-1-rui.wang@ideasonboard.com>","References":"<20251028170847.2673396-1-rui.wang@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Provide reusable ISO computation and band selection helpers. computeIso\nderives an effective ISO value from the AGC gain (approx ISO = gain * 100).\nselectIsoBand searches the tuning ISO level table for the appropriate band\ngiven the current ISO, falling back to the last band if ISO exceeds all\ndefined ranges.\n\nSigned-off-by: Rui Wang \n---\n src/ipa/rkisp1/algorithms/denoise.h | 28 ++++++++++++++++++++++++++++\n 1 file changed, 28 insertions(+)","diff":"diff --git a/src/ipa/rkisp1/algorithms/denoise.h b/src/ipa/rkisp1/algorithms/denoise.h\nindex 8f109db4..d97301f0 100644\n--- a/src/ipa/rkisp1/algorithms/denoise.h\n+++ b/src/ipa/rkisp1/algorithms/denoise.h\n@@ -7,6 +7,8 @@\n \n #pragma once\n \n+#include \"../ipa_context.h\"\n+\n #include \"algorithm.h\"\n \n namespace libcamera {\n@@ -27,8 +29,34 @@ class DenoiseBaseAlgorithm : public ipa::rkisp1::Algorithm\n protected:\n \tDenoiseBaseAlgorithm() = default;\n \t~DenoiseBaseAlgorithm() = default;\n+\n+\tunsigned computeIso(const IPAContext &context,\n+\t\t\t const IPAFrameContext &frameContext) const;\n+\ttemplate\n+\tint selectIsoBand(unsigned iso, const LevelContainer &levels) const;\n };\n \n+inline unsigned DenoiseBaseAlgorithm::computeIso(const IPAContext &context,\n+\t\t\t\t\t\t const IPAFrameContext &frameContext) const\n+{\n+\tdouble ag = frameContext.agc.gain ? frameContext.agc.gain\n+\t\t\t\t\t : context.activeState.agc.automatic.gain;\n+\treturn static_cast(ag * 100.0 + 0.5);\n+}\n+\n+template\n+int DenoiseBaseAlgorithm::selectIsoBand(unsigned iso, const LevelContainer &levels) const\n+{\n+\tif (levels.empty())\n+\t\treturn -1;\n+\tint idx = 0;\n+\twhile (idx < static_cast(levels.size()) && iso > levels[idx].maxIso)\n+\t\t++idx;\n+\tif (idx >= static_cast(levels.size()))\n+\t\tidx = static_cast(levels.size()) - 1;\n+\treturn idx;\n+}\n+\n } /* namespace ipa::rkisp1::algorithms */\n \n } /* namespace libcamera */\n","prefixes":["v1","02/16"]}